GNU bug report logs - #10123
24.0.91; [PATCH] make Imenu ignore invisible definitions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10123 in the body.
You can then email your comments to 10123 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.91; [PATCH] make Imenu ignore invisible definitions
Date: Wed, 23 Nov 2011 16:36:42 -0800

[Message part 1 (text/plain, inline)]

The attached patch makes Imenu ignore definitions that are in invisible
text.
 
This is especially useful when combined with code that hides comments,
in which case definitions that are commented out are not included in the
Imenu.  (Obviously, that behavior should be optional, as it is sometimes
helpful to use Imenu to get to commented-out definitions too.)

Someone else might have a more elegant or more performant way to do this,
but this way seems to work OK.

In GNU Emacs 24.0.91.1 (i386-mingw-nt5.1.2600) of 2011-11-21 on MARVIN
 Windowing system distributor `Microsoft Corp.', version 5.1.2600
 configured using `configure --with-gcc (4.6) --no-opt --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-2.10.1/include --ldflags
 -LD:/devel/emacs/libs/gnutls-2.10.1/lib'
 

[imenu-2011-11-23.patch (application/octet-stream, attachment)]

Message #8 received at 10123 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <10123 <at> debbugs.gnu.org>
Subject: RE: bug#10123: 24.0.91;
	[PATCH] make Imenu ignore invisible definitions
Date: Wed, 23 Nov 2011 16:57:50 -0800

[Message part 1 (text/plain, inline)]

Sorry; I sent the wrong patch.  It needs to call `re-search-backward' with a
non-nil, non-t 3rd arg: (re-search-backward regexp nil 'MOVE), not
(re-search-backward regexp nil t).  The attached patch should be OK.

[imenu-2011-11-23b.patch (application/octet-stream, attachment)]

Message #11 received at 10123 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <10123 <at> debbugs.gnu.org>
Subject: RE: bug#10123: 24.0.91;
	[PATCH] make Imenu ignore invisible definitions
Date: Thu, 24 Nov 2011 08:46:50 -0800

[Message part 1 (text/plain, inline)]

Might as well use `invisible-p', so it works for invisibility from overlays as
well as from text properties.  Patch attached.

[imenu-2011-11-24a.patch (application/octet-stream, attachment)]

Message #14 received at 10123 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 10123 <at> debbugs.gnu.org
Subject: Re: bug#10123: 24.0.91;
	[PATCH] make Imenu ignore invisible definitions
Date: Thu, 12 Apr 2012 22:01:27 +0200

"Drew Adams" <drew.adams <at> oracle.com> writes:

> Might as well use `invisible-p', so it works for invisibility from overlays as
> well as from text properties.  Patch attached.

Thanks; I've now applied this to the Emacs trunk (with some white-space
fixes).

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.