GNU bug report logs - #10133
log-view and transient mark mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10133 in the body.
You can then email your comments to 10133 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.91; mark-active
Date: Fri, 25 Nov 2011 14:15:12 +0000

The value of mark-active isn't always correct. (I first noticed this
when I typed `d' in a vc-log-view buffer and got the diff between the
revisions at point and mark, not the diff for the change at point.)

From `emacs -Q',

M-x transient-mark-mode <return>
=> Transient-Mark mode disabled

M-: mark-active <return>
=> nil

C-SPC
=> Mark set

M-: mark-active <return>
=> t


In GNU Emacs 24.0.91.1 (i386-mingw-nt5.1.2600)
 of 2011-11-25 on 57172UHB
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.6) --cflags -fno-omit-frame-pointer'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: ENG
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t

Recent input:
M-x t r a n s i e n t - m a r k - m o d e <return>
M-: m a r k - a c t i v e <return> C-SPC M-: m a r
k - a c t i v e <return> M-x r e p o r t - e m a c
s - b u g <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Transient-Mark mode disabled
nil
Mark set
t

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message format-spec rfc822 mml easymenu
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader
emacsbug cus-start cus-load time-date tooltip ediff-hook vc-hooks
lisp-float-type mwheel dos-w32 disp-table ls-lisp w32-win w32-vars
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer button faces cus-face files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
multi-tty emacs)

Message #8 received at 10133 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: 10133 <at> debbugs.gnu.org
Subject: Re: bug#10133 (24.0.91; mark-active)
Date: Fri, 25 Nov 2011 14:30:25 +0000

Ah, I see that `mark-active' isn't quite what I thought it was. I
guess the bug is that the functions in "log-view.el" should be using
`use-region-p' or `region-active-p' rather than `mark-active'.

Message #11 received at 10133 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Richard Copley <rcopley <at> gmail.com>
Cc: 10133 <at> debbugs.gnu.org
Subject: Re: bug#10133: (24.0.91; mark-active)
Date: Mon, 28 Nov 2011 21:54:24 -0500

Richard Copley wrote:

> I guess the bug is that the functions in "log-view.el" should be using
> `use-region-p' or `region-active-p' rather than `mark-active'.

Why? That would make them dependent on transient mark mode.
Nowhere in the doc of eg log-view-diff does it say that the function
behaves differently if transient mark mode is on. So I don't see that
there is a bug here.

Message #14 received at 10133 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Richard Copley <rcopley <at> gmail.com>, 10133 <at> debbugs.gnu.org
Subject: Re: bug#10133: (24.0.91; mark-active)
Date: Tue, 29 Nov 2011 08:52:30 -0500

>> I guess the bug is that the functions in "log-view.el" should be using
>> `use-region-p' or `region-active-p' rather than `mark-active'.
> Why? That would make them dependent on transient mark mode.

But the current behavior means that without transient-mark-mode, if
you've set the mark at some point in the past, you can't do a "diff with
current file" any more, only a "diff between revision at point and
revision at mark".

> Nowhere in the doc of eg log-view-diff does it say that the function
> behaves differently if transient mark mode is on.  So I don't see that
> there is a bug here.

It's maybe not a bug, but it's a limitation.
I think `use-region-p' would make a lot of sense here nowadays (there
was no temporary tmm back when I wrote the code, so something like
use-region-p would have made the "diff between 2 revisions"
inaccessible to non-tmm users, but this limit has now been lifted).


        Stefan

Message #17 received at 10133 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Richard Copley <rcopley <at> gmail.com>, 10133 <at> debbugs.gnu.org
Subject: Re: bug#10133: (24.0.91; mark-active)
Date: Tue, 29 Nov 2011 12:27:22 -0500

Stefan Monnier wrote:

> But the current behavior means that without transient-mark-mode, if
> you've set the mark at some point in the past, you can't do a "diff with
> current file" any more, only a "diff between revision at point and
> revision at mark".

You can move the mark to point, though I agree it's not ideal.

> I think `use-region-p' would make a lot of sense here nowadays (there
> was no temporary tmm back when I wrote the code, so something like
> use-region-p would have made the "diff between 2 revisions"
> inaccessible to non-tmm users, but this limit has now been lifted).

Some people disable even temporary tmm. :)

Message #24 received at 10133 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Richard Copley <rcopley <at> gmail.com>, Glenn Morris <rgm <at> gnu.org>,
	10133 <at> debbugs.gnu.org
Subject: Re: bug#10133: (24.0.91; mark-active)
Date: Thu, 09 Aug 2012 15:50:25 +0800

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>> Nowhere in the doc of eg log-view-diff does it say that the function
>> behaves differently if transient mark mode is on.  So I don't see that
>> there is a bug here.
>
> It's maybe not a bug, but it's a limitation.
> I think `use-region-p' would make a lot of sense here nowadays (there
> was no temporary tmm back when I wrote the code, so something like
> use-region-p would have made the "diff between 2 revisions"
> inaccessible to non-tmm users, but this limit has now been lifted).

I changed it to use use-region-p.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.