GNU bug report logs - #10464
24.0.92; mouse highlight regression

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10464 in the body.
You can then email your comments to 10464 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.92; mouse highlight regression
Date: Mon, 09 Jan 2012 18:16:38 +0800

With latest trunk, the (non-automated) redisplay testsuite is failing in
Test 2.  Here is a simplified recipe:

emacs -Q

Insert the following:

  (let ((opoint (point))
	overlay)
    (insert "XXX")
    (setq overlay (make-overlay opoint (point)))
    (overlay-put overlay 'display "XXX")
    (overlay-put overlay 'mouse-face 'highlight))

M-x eval-buffer RET
Move the mouse over the XXX that was inserted.

Result: multiple lines are highlighted, from the end of the first buffer
line to the end of the display string.

Expected result (works in Emacs 23): only the XXX is highlighted.


In GNU Emacs 24.0.92.9 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
 of 2012-01-09 on furball
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--with-x-toolkit=gtk3' 'CFLAGS=-g''

Message #8 received at 10464 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 10464 <at> debbugs.gnu.org
Subject: Re: bug#10464: 24.0.92; mouse highlight regression
Date: Mon, 09 Jan 2012 07:32:42 -0500

> From: Chong Yidong <cyd <at> gnu.org>
> Date: Mon, 09 Jan 2012 18:16:38 +0800
> 
> With latest trunk, the (non-automated) redisplay testsuite is failing in
> Test 2.  Here is a simplified recipe:
> 
> emacs -Q
> 
> Insert the following:
> 
>   (let ((opoint (point))
> 	overlay)
>     (insert "XXX")
>     (setq overlay (make-overlay opoint (point)))
>     (overlay-put overlay 'display "XXX")
>     (overlay-put overlay 'mouse-face 'highlight))
> 
> M-x eval-buffer RET
> Move the mouse over the XXX that was inserted.
> 
> Result: multiple lines are highlighted, from the end of the first buffer
> line to the end of the display string.
> 
> Expected result (works in Emacs 23): only the XXX is highlighted.

Did this work with Emacs 24 at some recent time (or ever), i.e. do you
remember this working for you past Emacs 23?  If it did, it will allow
me to consider only the latest changes.

TIA

Message #11 received at 10464 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 10464 <at> debbugs.gnu.org
Subject: Re: bug#10464: 24.0.92; mouse highlight regression
Date: Mon, 09 Jan 2012 22:48:26 +0200

> From: Chong Yidong <cyd <at> gnu.org>
> Date: Mon, 09 Jan 2012 18:16:38 +0800
> 
> With latest trunk, the (non-automated) redisplay testsuite is failing in
> Test 2.  Here is a simplified recipe:
> 
> emacs -Q
> 
> Insert the following:
> 
>   (let ((opoint (point))
> 	overlay)
>     (insert "XXX")
>     (setq overlay (make-overlay opoint (point)))
>     (overlay-put overlay 'display "XXX")
>     (overlay-put overlay 'mouse-face 'highlight))
> 
> M-x eval-buffer RET
> Move the mouse over the XXX that was inserted.
> 
> Result: multiple lines are highlighted, from the end of the first buffer
> line to the end of the display string.
> 
> Expected result (works in Emacs 23): only the XXX is highlighted.

I think I fixed this (trunk revision 106827), but please test,
including any variations on this theme you can come up with.  The
bidi-aware mouse highlight is tricky business, especially when display
strings are involved.

Message #14 received at 10464 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 10464 <at> debbugs.gnu.org
Subject: Re: bug#10464: 24.0.92; mouse highlight regression
Date: Tue, 10 Jan 2012 12:21:10 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> I think I fixed this (trunk revision 106827), but please test,
> including any variations on this theme you can come up with.  The
> bidi-aware mouse highlight is tricky business, especially when display
> strings are involved.

Thanks for the very quick fix.

This specific case is indeed fixed, but there is still a failing corner
case in the redisplay testsuite.  Load test/redisplay-testsuite.el, do
M-x test-redisplay, and go to the very last case in Test 2.

When the mouse is over the XXX, the highlight only extends to the end of
the text, whereas it's expected to go to the end of the line.  This is
the case where there's an overlay with "XXX\n" as the display string and
a mouse face.

Message #17 received at 10464 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 10464 <at> debbugs.gnu.org
Subject: Re: bug#10464: 24.0.92; mouse highlight regression
Date: Tue, 10 Jan 2012 00:26:07 -0500

> From: Chong Yidong <cyd <at> gnu.org>
> Cc: 10464 <at> debbugs.gnu.org
> Date: Tue, 10 Jan 2012 12:21:10 +0800
> 
> When the mouse is over the XXX, the highlight only extends to the end of
> the text, whereas it's expected to go to the end of the line.  This is
> the case where there's an overlay with "XXX\n" as the display string and
> a mouse face.

I will look into it, but (compatibility with Emacs 23 aside) how
important is it to have the entire display line come up in mouse color
in this case?  I could make an argument that what we do in Emacs 24 is
actually better, since the newline is not shown on display as any
tangible glyph.

IOW, are there practical use cases where this difference matters?

Message #22 received at 10464-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 10464-done <at> debbugs.gnu.org
Subject: Re: bug#10464: 24.0.92; mouse highlight regression
Date: Wed, 11 Jan 2012 21:47:26 +0200

> From: Chong Yidong <cyd <at> gnu.org>
> Cc: 10464 <at> debbugs.gnu.org
> Date: Tue, 10 Jan 2012 12:21:10 +0800
> 
> Thanks for the very quick fix.
> 
> This specific case is indeed fixed, but there is still a failing corner
> case in the redisplay testsuite.  Load test/redisplay-testsuite.el, do
> M-x test-redisplay, and go to the very last case in Test 2.
> 
> When the mouse is over the XXX, the highlight only extends to the end of
> the text, whereas it's expected to go to the end of the line.  This is
> the case where there's an overlay with "XXX\n" as the display string and
> a mouse face.

Fixed (trunk revision 106848).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.