GNU bug report logs - #10523
24.0.92; Wrong init value for eshell-windows-shell-file

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10523 in the body.
You can then email your comments to 10523 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.92; Wrong init value for eshell-windows-shell-file
Date: Mon, 16 Jan 2012 22:45:50 +0100

The function eshell-invoke-batch-file expects that
eshell-windows-shell-file points to something with the behaviour of
cmd.exe. Currently it defaults to the path to cmdproxy.exe (the default
value of shell-file-name), which will not work properly.

The patch below solves this issue.

=== modified file 'lisp/eshell/esh-ext.el'
--- lisp/eshell/esh-ext.el	2012-01-05 09:46:05 +0000
+++ lisp/eshell/esh-ext.el	2012-01-16 20:21:27 +0000
@@ -91,7 +91,7 @@

 (defcustom eshell-windows-shell-file
   (if (eshell-under-windows-p)
-      (if (string-match "\\(\\`cmdproxy\\|sh\\)\\.\\(com\\|exe\\)"
+      (if (string-match "\\(cmdproxy\\|sh\\)\\.\\(com\\|exe\\)"
 			shell-file-name)
 	  (or (eshell-search-path "cmd.exe")
 	      (eshell-search-path "command.com"))

Message #10 received at 10523 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ljung <lars <at> matholka.se>
Cc: 10523 <at> debbugs.gnu.org
Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file
Date: Tue, 17 Jan 2012 07:11:18 +0200

> Date: Mon, 16 Jan 2012 22:45:50 +0100
> From: Lars Ljung <lars <at> matholka.se>
> 
> The function eshell-invoke-batch-file expects that
> eshell-windows-shell-file points to something with the behaviour of
> cmd.exe. Currently it defaults to the path to cmdproxy.exe (the default
> value of shell-file-name), which will not work properly.

Why doesn't it work properly?  Can you give a simple test case where
it fails, and explain why?

Thanks.

Message #13 received at 10523 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ljung <lars <at> matholka.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 10523 <at> debbugs.gnu.org
Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file
Date: Tue, 17 Jan 2012 06:53:38 +0100

2012-01-17 06:11, Eli Zaretskii skrev:
> Why doesn't it work properly?  Can you give a simple test case where
> it fails, and explain why?

With cmdproxy.exe it will look like this:

~ $ test.bat arg1 arg2
warning: extra args ignored after 'test.bat'

The warning is printed by cmdproxy.exe and the reason is that the
command gets translated to the following:

cmdproxy.exe /c test.bat arg1 arg2

But cmdproxy.exe expects one single argument after /c, .i.e.
cmdproxy.exe /c "test.bat arg1 arg2". cmd.exe on the other hand uses all
remaining arguments on the command line.

To me it looks like the regexp is used to avoid using cmdproxy.exe, but
it fails because of the extra \\`.

Regards,
Lars Ljung

Message #18 received at 10523-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ljung <lars <at> matholka.se>
Cc: 10523-done <at> debbugs.gnu.org
Subject: Re: bug#10523: 24.0.92; Wrong init value for eshell-windows-shell-file
Date: Sat, 04 Feb 2012 11:58:43 +0200

> Date: Tue, 17 Jan 2012 06:53:38 +0100
> From: Lars Ljung <lars <at> matholka.se>
> CC: 10523 <at> debbugs.gnu.org
> 
> 2012-01-17 06:11, Eli Zaretskii skrev:
> > Why doesn't it work properly?  Can you give a simple test case where
> > it fails, and explain why?
> 
> With cmdproxy.exe it will look like this:
> 
> ~ $ test.bat arg1 arg2
> warning: extra args ignored after 'test.bat'
> 
> The warning is printed by cmdproxy.exe and the reason is that the
> command gets translated to the following:
> 
> cmdproxy.exe /c test.bat arg1 arg2
> 
> But cmdproxy.exe expects one single argument after /c, .i.e.
> cmdproxy.exe /c "test.bat arg1 arg2". cmd.exe on the other hand uses all
> remaining arguments on the command line.
> 
> To me it looks like the regexp is used to avoid using cmdproxy.exe, but
> it fails because of the extra \\`.

Thanks, I installed that change (trunk revision 107089).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.