GNU bug report logs - #10614
[EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to support a prefix argument following suggesion by Juri Linkov

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10614 in the body.
You can then email your comments to 10614 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gideon Stupp <gideon.stupp <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, emacs-devel <at> gnu.org, juri <at> jurta.org
Subject: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to
	support a prefix argument following suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 19:27:06 +0200

[Message part 1 (text/plain, inline)]

Package: emacs
Tags: patch
Severity: wishlist

This experimental patch implements a suggestion by Juri Linkov to extend
isearch-repeat-forward/backward to support a prefix argument. Instead of
pressing C-s / C-r multiple times it is possible with this patch to
enter a prefix argument
which runs the command multiple times for you. If a negative argument
is given for
isearch-repeat-forward then isearch-repeat-backward is run and visa
versa. Visual hints
are added to the matched strings to help figure out what argument
should be given.

Please try it out.

Thanks, Gideon.

[isearchnavjuri.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tassilo <at> member.fsf.org>
To: Gideon Stupp <gideon.stupp <at> gmail.com>
Cc: juri <at> jurta.org, bug-gnu-emacs <at> gnu.org, emacs-devel <at> gnu.org
Subject: Re: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to
	support a prefix argument following suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 19:36:02 +0100

Gideon Stupp <gideon.stupp <at> gmail.com> writes:

Hi Gideon,

> This experimental patch implements a suggestion by Juri Linkov to extend
> isearch-repeat-forward/backward to support a prefix argument.

I like it.  I adapted it a bit to show the hints at the position where
point would be if that one's selected, and I added also a bit
superscript magic, which suits me better, visually.  (Well, that should
be customizable, of course.)

But how the heck is the usage of the prefix arg supposed to work?  When
I do C-s foo C-3, isearch is exited...

Bye,
Tassilo

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tassilo <at> member.fsf.org>
To: Gideon Stupp <gideon.stupp <at> gmail.com>
Cc: juri <at> jurta.org, bug-gnu-emacs <at> gnu.org, emacs-devel <at> gnu.org
Subject: Re: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to
	support a prefix argument following suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 19:46:07 +0100

[Message part 1 (text/plain, inline)]

Tassilo Horn <tassilo <at> member.fsf.org> writes:

>> This experimental patch implements a suggestion by Juri Linkov to
>> extend isearch-repeat-forward/backward to support a prefix argument.
>
> I like it.  I adapted it a bit to show the hints at the position where
> point would be if that one's selected, and I added also a bit
> superscript magic, which suits me better, visually.  (Well, that should
> be customizable, of course.)

Ups, I forgot to attach the patch.

Bye,
Tassilo

[isearchnavjuri.patch (text/x-patch, attachment)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tassilo <at> member.fsf.org>
To: Gideon Stupp <gideon.stupp <at> gmail.com>
Cc: juri <at> jurta.org, bug-gnu-emacs <at> gnu.org, emacs-devel <at> gnu.org
Subject: Re: [EXPERIMENTAL PATCH] Extending Isearch-repeat-forward/backward to
	support a prefix argument following suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 20:11:05 +0100

Tassilo Horn <tassilo <at> member.fsf.org> writes:

> But how the heck is the usage of the prefix arg supposed to work?
> When I do C-s foo C-3, isearch is exited...

That was my fault.  Of course, loading the patched isearch.el didn't
make the changed isearch-mode-map active (defvar).  It works fine, now.

Usability-wise, C-s foo C-<number> C-s makes only sense if that
keystroke is shorter to type than C-s multiple times.  So maybe the
numbering should start with some offset, say, with the 5th next match?

And the typing of C-s after the number is a bit inconvenient, so maybe,
C-7 could jump directly to the match hinted with 7, and only for
two-digit matches C-s was needed, i.e., C-u 1 2 C-s to jump to the 12th
match?

Bye,
Tassilo

Message #17 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: Jérémy Compostella <jeremy.compostella <at> gmail.com>
To: Tassilo Horn <tassilo <at> member.fsf.org>
Cc: 10614 <at> debbugs.gnu.org, Gideon Stupp <gideon.stupp <at> gmail.com>,
	emacs-devel <at> gnu.org
Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending
	Isearch-repeat-forward/backward
	to support a prefix argument following suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 20:28:02 +0100

[Message part 1 (text/plain, inline)]

2012/1/26 Tassilo Horn <tassilo <at> member.fsf.org>

> Tassilo Horn <tassilo <at> member.fsf.org> writes:
>
> > But how the heck is the usage of the prefix arg supposed to work?
> > When I do C-s foo C-3, isearch is exited...
>
> That was my fault.  Of course, loading the patched isearch.el didn't
> make the changed isearch-mode-map active (defvar).  It works fine, now.
>
> Usability-wise, C-s foo C-<number> C-s makes only sense if that
> keystroke is shorter to type than C-s multiple times.  So maybe the
> numbering should start with some offset, say, with the 5th next match?
>
> And the typing of C-s after the number is a bit inconvenient, so maybe,
> C-7 could jump directly to the match hinted with 7, and only for
> two-digit matches C-s was needed, i.e., C-u 1 2 C-s to jump to the 12th
> match?
>
>
I just played play with it too and I really like it. Here my notes:
- I do agree with Tassilo, C-7 should directly jump to match hinted 7.
- When more than lazy-highlight-max-at-a-time are visible in the window,
  the prefix number is restarted from 1 on the next match hinted. It's
confusing
  and I think it should not appear on these items.
- A defcustom variable should be added to enable/disable the match hinted
prefix
  number.

Anyway, it's an very interesting improvement.

Jérémy

[Message part 2 (text/html, inline)]

Message #22 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Tassilo Horn'" <tassilo <at> member.fsf.org>,
	"'Gideon Stupp'" <gideon.stupp <at> gmail.com>
Cc: 10614 <at> debbugs.gnu.org, emacs-devel <at> gnu.org
Subject: RE: bug#10614: [EXPERIMENTAL PATCH]
	ExtendingIsearch-repeat-forward/backward to support a prefix
	argumentfollowing suggesion by Juri Linkov
Date: Thu, 26 Jan 2012 13:43:12 -0800

Please do not send stuff to both emacs-devel and the bug list.

Message #25 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gideon Stupp <gideon.stupp <at> gmail.com>
Cc: juri <at> jurta.org, emacs-devel <at> gnu.org, 10614 <at> debbugs.gnu.org
Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending
 Isearch-repeat-forward/backward to support a prefix argument following
 suggesion by Juri Linkov
Date: Thu, 25 Feb 2016 16:36:15 +1030

Gideon Stupp <gideon.stupp <at> gmail.com> writes:

> This experimental patch implements a suggestion by Juri Linkov to
> extend isearch-repeat-forward/backward to support a prefix
> argument. Instead of pressing C-s / C-r multiple times it is possible
> with this patch to enter a prefix argument which runs the command
> multiple times for you. If a negative argument is given for
> isearch-repeat-forward then isearch-repeat-backward is run and visa
> versa. Visual hints are added to the matched strings to help figure
> out what argument should be given.

Hm...  I guess I can see why this would be attractive, but I'm a bit
sceptical.  Numeric prefixes make sense in many instances, but I would
myself never this "hm, I must repeat the search three times"...  I would
just hit `C-s' four times instead.  That seems faster and more
convenient...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #28 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Gideon Stupp <gideon.stupp <at> gmail.com>, emacs-devel <at> gnu.org,
 10614 <at> debbugs.gnu.org
Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending
 Isearch-repeat-forward/backward to support a prefix argument following
 suggesion by Juri Linkov
Date: Tue, 01 Mar 2016 01:44:52 +0200

>> This experimental patch implements a suggestion by Juri Linkov to
>> extend isearch-repeat-forward/backward to support a prefix
>> argument. Instead of pressing C-s / C-r multiple times it is possible
>> with this patch to enter a prefix argument which runs the command
>> multiple times for you. If a negative argument is given for
>> isearch-repeat-forward then isearch-repeat-backward is run and visa
>> versa. Visual hints are added to the matched strings to help figure
>> out what argument should be given.
>
> Hm...  I guess I can see why this would be attractive, but I'm a bit
> sceptical.  Numeric prefixes make sense in many instances, but I would
> myself never this "hm, I must repeat the search three times"...  I would
> just hit `C-s' four times instead.  That seems faster and more
> convenient...

What if you need to visit a Nth occurrence where N is larger
than the number of keystrokes with numeric prefixes
(while using isearch for navigation)?

Message #31 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: Gideon Stupp <gideon.stupp <at> gmail.com>, emacs-devel <at> gnu.org,
 10614 <at> debbugs.gnu.org
Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending
 Isearch-repeat-forward/backward to support a prefix argument following
 suggesion by Juri Linkov
Date: Tue, 01 Mar 2016 11:43:59 +1100

Juri Linkov <juri <at> jurta.org> writes:

> What if you need to visit a Nth occurrence where N is larger
> than the number of keystrokes with numeric prefixes
> (while using isearch for navigation)?

I still don't think I'd want to enter a number.  I'd either stop doing
isearch if it was too far away (and just move the cursor where I wanted
it to be), or I'd hit `C-s' a lot.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #34 received at 10614 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juri Linkov <juri <at> jurta.org>
Cc: Gideon Stupp <gideon.stupp <at> gmail.com>, 10614 <at> debbugs.gnu.org
Subject: Re: bug#10614: [EXPERIMENTAL PATCH] Extending
 Isearch-repeat-forward/backward to support a prefix argument following
 suggesion by Juri Linkov
Date: Thu, 27 Jun 2019 17:36:57 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Juri Linkov <juri <at> jurta.org> writes:
>
>> What if you need to visit a Nth occurrence where N is larger
>> than the number of keystrokes with numeric prefixes
>> (while using isearch for navigation)?
>
> I still don't think I'd want to enter a number.  I'd either stop doing
> isearch if it was too far away (and just move the cursor where I wanted
> it to be), or I'd hit `C-s' a lot.

Nobody else weighed in three years ago, so I'm closing this bug report.
The "counting and jumping" thing seems so vim-like to me.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.