GNU bug report logs - #10779
24.0.93; ERC: Patch to make server response timestamp format customizable

Previous Next

Package: emacs;

Reported by: Teemu Likonen <tlikonen <at> iki.fi>

Date: Fri, 10 Feb 2012 14:13:01 UTC

Severity: wishlist

Tags: fixed, patch

Found in version 24.0.93

Fixed in version 24.2

Done: Lars Magne Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10779 in the body.
You can then email your comments to 10779 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Fri, 10 Feb 2012 14:13:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Teemu Likonen <tlikonen <at> iki.fi>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 10 Feb 2012 14:13:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Fri, 10 Feb 2012 16:10:27 +0200

[Message part 1 (text/plain, inline)]
[This is a "wishlist" bug report for Emacs IRC client package ERC. This
message includes a patch that fully implements my wish.]

ERC displays various server response messages with timestamps. The
timestamp formats that are hard-coded to ERC code have some unnecessary
variation. Also, it's sometimes even unclear what is the day component
and what is the month component (due to YY/MM or MM/YY differences).

I suggest making those server response timestamp formats customizable
and having the default value in international "%Y-%m-%d %T" format (as
parsed by `format-time-string' function).

This message includes a patch that fully implements this (I believe).


[0001-ERC-Make-server-response-timestamp-format-configurab.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Fri, 10 Feb 2012 15:48:01 GMT) Full text and rfc822 format available.

Message #8 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Michael Olson <mwolson <at> gnu.org>
To: ERC Discussion <erc-discuss <at> gnu.org>, 10779 <at> debbugs.gnu.org
Subject: Re: [Erc-discuss] Make server response timestamp format customizable
	(patch)
Date: Fri, 10 Feb 2012 07:45:18 -0800

[Message part 1 (text/plain, inline)]
The patch looks good to me.

On Fri, Feb 10, 2012 at 6:20 AM, Teemu Likonen <tlikonen <at> iki.fi> wrote:

> ERC displays various server response messages with timestamps. The
> timestamp formats that are hard-coded to ERC code have some unnecessary
> variation. Also, it's sometimes even unclear what is the day component
> and what is the month component (due to YY/MM or MM/YY differences).
>
> I suggest making those server response timestamp formats customizable
> and having the default value in international "%Y-%m-%d %T" format (as
> parsed by `format-time-string' function).
>
> This message includes a patch that fully implements this (I believe).
>
> I have also filed this to Emacs bug tracking system:
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10779
>
>
> _______________________________________________
> Erc-discuss mailing list
> Erc-discuss <at> gnu.org
> https://lists.gnu.org/mailman/listinfo/erc-discuss
>
>


-- 
Michael Olson  |  http://mwolson.org/

[Message part 2 (text/html, inline)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Thu, 12 Apr 2012 20:22:02 GMT) Full text and rfc822 format available.

Message #11 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Teemu Likonen <tlikonen <at> iki.fi>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Thu, 12 Apr 2012 22:20:15 +0200

Teemu Likonen <tlikonen <at> iki.fi> writes:

> I suggest making those server response timestamp formats customizable
> and having the default value in international "%Y-%m-%d %T" format (as
> parsed by `format-time-string' function).
>
> This message includes a patch that fully implements this (I believe).

Looks good to me.  Do you have FSF copyright assignment papers on file,
or if not, would you be willing to sign such papers?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Fri, 13 Apr 2012 03:01:02 GMT) Full text and rfc822 format available.

Message #14 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Fri, 13 Apr 2012 05:59:13 +0300

* Lars Magne Ingebrigtsen [2012-04-12 22:20:15 +0200] wrote:

> Teemu Likonen <tlikonen <at> iki.fi> writes:
>
>> I suggest making those server response timestamp formats customizable
>> and having the default value in international "%Y-%m-%d %T" format
>> (as parsed by `format-time-string' function).
>>
>> This message includes a patch that fully implements this (I believe).
>
> Looks good to me. Do you have FSF copyright assignment papers on file,
> or if not, would you be willing to sign such papers?

No, I don't have but would like to. How do I proceed?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Sun, 29 Apr 2012 18:51:02 GMT) Full text and rfc822 format available.

Message #17 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Sun, 29 Apr 2012 21:49:07 +0300

* Teemu Likonen [2012-04-13 05:59:13 +0300] wrote:

> * Lars Magne Ingebrigtsen [2012-04-12 22:20:15 +0200] wrote:
>> Looks good to me. Do you have FSF copyright assignment papers on
>> file, or if not, would you be willing to sign such papers?
>
> No, I don't have but would like to. How do I proceed?

The papers have been signed now, so I guess you are free to apply my
patch.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Sun, 29 Apr 2012 21:41:02 GMT) Full text and rfc822 format available.

Message #20 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz <at> dogan.se>
To: Teemu Likonen <tlikonen <at> iki.fi>
Cc: 10779 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#10779: 24.0.93; ERC: Patch to make server response timestamp
	format customizable
Date: Sun, 29 Apr 2012 23:38:45 +0200

On 2012-04-29 20:49, Teemu Likonen wrote:
> * Teemu Likonen [2012-04-13 05:59:13 +0300] wrote:
>
>> * Lars Magne Ingebrigtsen [2012-04-12 22:20:15 +0200] wrote:
>>> Looks good to me. Do you have FSF copyright assignment papers on
>>> file, or if not, would you be willing to sign such papers?
>>
>> No, I don't have but would like to. How do I proceed?
>
> The papers have been signed now, so I guess you are free to apply my
> patch.
>

Have you received a confirmation from FSF?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Mon, 30 Apr 2012 04:03:02 GMT) Full text and rfc822 format available.

Message #23 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Deniz Dogan <deniz <at> dogan.se>
Cc: 10779 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Mon, 30 Apr 2012 07:00:43 +0300

* Deniz Dogan [2012-04-29 23:38:45 +0200] wrote:

> Have you received a confirmation from FSF?

Yes.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Sun, 13 May 2012 18:53:02 GMT) Full text and rfc822 format available.

Message #26 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Teemu Likonen <tlikonen <at> iki.fi>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Sun, 13 May 2012 20:51:55 +0200

Teemu Likonen <tlikonen <at> iki.fi> writes:

> The papers have been signed now, so I guess you are free to apply my
> patch.

I've now applied your patch.

Could you send a patch to the erc manual, too, describing the variable?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Sun, 13 May 2012 19:05:02 GMT) Full text and rfc822 format available.

Message #29 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Teemu Likonen <tlikonen <at> iki.fi>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Sun, 13 May 2012 22:03:19 +0300

* Lars Magne Ingebrigtsen [2012-05-13 20:51:55 +0200] wrote:

> Teemu Likonen <tlikonen <at> iki.fi> writes:
>> The papers have been signed now, so I guess you are free to apply my
>> patch.
>
> I've now applied your patch.

Thanks.

> Could you send a patch to the erc manual, too, describing the
> variable?

The Erc manual does not describe much, and it would look strange to have
just my variable there alone.

    7.3 Options
    ===========

    This section has not yet been written. For now, the easiest way to
    check out the available options for ERC is to do `M-x
    customize-group erc RET'.

(erc) Options
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10779; Package emacs. (Sun, 13 May 2012 19:07:01 GMT) Full text and rfc822 format available.

Message #32 received at 10779 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Teemu Likonen <tlikonen <at> iki.fi>
Cc: 10779 <at> debbugs.gnu.org
Subject: Re: bug#10779: 24.0.93;
	ERC: Patch to make server response timestamp format customizable
Date: Sun, 13 May 2012 21:05:58 +0200

Teemu Likonen <tlikonen <at> iki.fi> writes:

> The Erc manual does not describe much, and it would look strange to have
> just my variable there alone.
>
>     7.3 Options
>     ===========
>
>     This section has not yet been written. For now, the easiest way to
>     check out the available options for ERC is to do `M-x
>     customize-group erc RET'.

Ah; ok.  I'm closing this bug report, then.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/
Added tag(s) fixed. Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 13 May 2012 19:07:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 24.2, send any further explanations to 10779 <at> debbugs.gnu.org and Teemu Likonen <tlikonen <at> iki.fi> Request was from Lars Magne Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 13 May 2012 19:07:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 11 Jun 2012 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 315 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.