GNU bug report logs - #10858
24.0.93; [PATCH]`Info-menu' does not respect string value of FORK arg

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10858 in the body.
You can then email your comments to 10858 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.0.93; [PATCH]`Info-menu' does not respect string value of FORK arg
Date: Mon, 20 Feb 2012 09:10:28 -0800

The doc string says:
"If FORK is a string, it is the name to use for the new buffer."
 
But (Info-menu "Emacs" "NEWNAME") does not put the new Info buffer
(which correctly visits menu-item `Emacs') in a buffer named `NEWNAME'.
 
The incorrect code is this, at the end of `Info-menu':
 
(Info-goto-node (Info-extract-menu-item menu-item) (if fork menu-item))
 
That should be:
 
(Info-goto-node (Info-extract-menu-item menu-item)
                (and fork (if (stringp fork) fork menu-item)))
 
Note that the code for `Info-goto-node' is correct.  The problem with
`Info-menu' is that it ignores the string value of FORK.
 
Note that this bug has existed ever since Emacs 21, when the FORK arg
was introduced.  The fix is trivial.

In GNU Emacs 24.0.93.1 (i386-mingw-nt5.1.2600)
 of 2012-02-15 on MARVIN
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.6) --no-opt --enable-checking --cflags
 -ID:/devel/emacs/libs/libXpm-3.5.8/include
 -ID:/devel/emacs/libs/libXpm-3.5.8/src
 -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include
 -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include
 -ID:/devel/emacs/libs/giflib-4.1.4-1/include
 -ID:/devel/emacs/libs/jpeg-6b-4/include
 -ID:/devel/emacs/libs/tiff-3.8.2-1/include
 -ID:/devel/emacs/libs/gnutls-3.0.9/include'
 

Message #8 received at 10858 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 10858 <at> debbugs.gnu.org
Subject: Re: bug#10858: 24.0.93;
	[PATCH]`Info-menu' does not respect string value of FORK arg
Date: Mon, 20 Feb 2012 15:53:55 -0500

> (Info-goto-node (Info-extract-menu-item menu-item)
>                 (and fork (if (stringp fork) fork menu-item)))
[...] 
> Note that this bug has existed ever since Emacs 21, when the FORK arg
> was introduced.  The fix is trivial.

Indeed: wouldn't it be nice if you could just "bzr commit" and be done
with it?


        Stefan

Message #11 received at 10858 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 10858 <at> debbugs.gnu.org
Subject: Re: bug#10858: 24.0.93;
	[PATCH]`Info-menu' does not respect string value of FORK arg
Date: Thu, 22 Mar 2012 00:57:23 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> That should be:
>  
> (Info-goto-node (Info-extract-menu-item menu-item)
>                 (and fork (if (stringp fork) fork menu-item)))

Committed, thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.