GNU bug report logs - #10937
24.0.94; fix savehist-printable

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Sun, 4 Mar 2012 09:18:02 UTC

Severity: normal

Found in version 24.0.94

Done: Leo <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10937 in the body.
You can then email your comments to 10937 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#10937; Package emacs. (Sun, 04 Mar 2012 09:18:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 04 Mar 2012 09:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.94; fix savehist-printable
Date: Sun, 04 Mar 2012 17:15:44 +0800

In savehist-printable, strings are not necessary printable. They can
contain anything in their properties. Because of this I have kill-ring
emptied for almost every restart of emacs.

I propose:

diff --git a/lisp/savehist.el b/lisp/savehist.el
index c1515fa4..a3ba9f1a 100644
--- a/lisp/savehist.el
+++ b/lisp/savehist.el
@@ -369,7 +369,7 @@ (defun savehist-printable (value)
   "Return non-nil if VALUE is printable."
   (cond
    ;; Quick response for oft-encountered types known to be printable.
-   ((stringp value))
+   ((equal-including-properties value (substring-no-properties value)))
    ((numberp value))
    ((symbolp value))
    (t

or just remove (stringp value) and let the default handle it.

Leo
Reply sent to Leo <sdl.web <at> gmail.com>:
You have taken responsibility. (Fri, 09 Mar 2012 18:14:01 GMT) Full text and rfc822 format available.
Notification sent to Leo <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Fri, 09 Mar 2012 18:14:01 GMT) Full text and rfc822 format available.

Message #10 received at 10937-done <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 10937-done <at> debbugs.gnu.org
Subject: Re: bug#10937: 24.0.94; fix savehist-printable
Date: Sat, 10 Mar 2012 02:12:26 +0800

Fixed in 24.0.95.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#10937; Package emacs. (Wed, 21 Mar 2012 18:27:01 GMT) Full text and rfc822 format available.

Message #13 received at 10937 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 10937 <at> debbugs.gnu.org
Subject: Re: bug#10937: 24.0.94; fix savehist-printable
Date: Wed, 21 Mar 2012 13:55:56 -0400

> In savehist-printable, strings are not necessary printable.  They can
> contain anything in their properties.  Because of this I have kill-ring
> emptied for almost every restart of Emacs.

Maybe we should strip their properties?


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 19 Apr 2012 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 17 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.