GNU bug report logs - #10987
ibuffer: remove "No Buffers" error

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 10987 in the body.
You can then email your comments to 10987 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: ibuffer: remove "No Buffers" error
Date: Sat, 10 Mar 2012 13:18:09 +0100

[Message part 1 (text/plain, inline)]

Hi gurus,

I noticed a little issue with ibuffer on GNU Emacs 24.0.94.1
(x86_64-unknown-linux-gnu, GTK+ Version 2.24.10) of 2012-03-10.

I use ibuffer-never-show-predicates to reduce the list of buffers in
ibuffer.  This works fine whilst there are buffers for ibuffer to
display.  If there are no buffers, ibuffer will error (and will leave an
unusable ibuffer-buffer behind).  What the point behind this error?  I
think that no buffers is a perfectly legitimate situation.

Recipe:
emacs -q
eval: (require 'ibuf-ext)
(push "" ibuffer-never-show-predicates)
M-x ibuffer RET

I think the whole error should be removed.

[ibuffer.diff (text/x-diff, inline)]

diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 17be553..7db4cc4 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2140,11 +2140,10 @@ If optional arg SILENT is non-nil, do not display progress messages."
   (unless silent
     (message "Redisplaying current buffer list..."))
   (let ((blist (ibuffer-current-state-list)))
-    (when (null blist)
-      (if (and (featurep 'ibuf-ext)
+    (when (and (null blist)
+	       (featurep 'ibuf-ext)
 	       (or ibuffer-filtering-qualifiers ibuffer-hidden-filter-groups))
-	  (message "No buffers! (note: filtering in effect)")
-	(error "No buffers!")))
+      (message "No buffers! (note: filtering in effect)"))
     (ibuffer-redisplay-engine blist t)
     (unless silent
       (message "Redisplaying current buffer list...done"))

[Message part 3 (text/plain, inline)]

        Christopher

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#10987: ibuffer: remove "No Buffers" error
Date: Mon, 12 Mar 2012 01:32:20 +0800

Christopher Schmidt <christopher <at> ch.ristopher.com> writes:

> I use ibuffer-never-show-predicates to reduce the list of buffers in
> ibuffer.  This works fine whilst there are buffers for ibuffer to
> display.  If there are no buffers, ibuffer will error (and will leave an
> unusable ibuffer-buffer behind).  What the point behind this error?  I
> think that no buffers is a perfectly legitimate situation.

Thanks.  I committed your patch to trunk.

Message #13 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#10987: ibuffer: remove "No Buffers" error
Date: Sun, 11 Mar 2012 19:34:24 +0100

[Message part 1 (text/plain, inline)]

Chong Yidong <cyd <at> gnu.org> writes:

> Thanks.  I committed your patch to trunk.

Thank you very much.  I just skimmed through ibuffer.el and found the
same error in ibuffer-redisplay.

[ibuffer2.diff (text/x-diff, inline)]

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 4710434..5b11660 100644
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2012-03-11  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* ibuffer.el (ibuffer-redisplay): Remove gratuitous error
+	(Bug#10987).
+
 2012-03-11  Michael Albinus  <michael.albinus <at> gmx.de>
 
 	* autorevert.el (auto-revert-handler): Ensure, that
diff --git a/lisp/ibuffer.el b/lisp/ibuffer.el
index 7db4cc4..7e5a4aa 100644
--- a/lisp/ibuffer.el
+++ b/lisp/ibuffer.el
@@ -2173,11 +2173,10 @@ If optional arg SILENT is non-nil, do not display progress messages."
 		   (cadr bufs))
 		 (ibuffer-current-buffers-with-marks bufs)
 		 ibuffer-display-maybe-show-predicates)))
-    (when (null blist)
-      (if (and (featurep 'ibuf-ext)
+    (when (and (null blist)
+	       (featurep 'ibuf-ext)
 	       ibuffer-filtering-qualifiers)
-	  (message "No buffers! (note: filtering in effect)")
-	(error "No buffers!")))
+      (message "No buffers! (note: filtering in effect)"))
     (unless silent
       (message "Updating buffer list..."))
     (ibuffer-redisplay-engine blist arg)

[Message part 3 (text/plain, inline)]

        Christopher

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#10987: ibuffer: remove "No Buffers" error
Date: Mon, 12 Mar 2012 10:41:23 +0800

Christopher Schmidt <christopher <at> ch.ristopher.com> writes:

> Chong Yidong <cyd <at> gnu.org> writes:
>
>> Thanks.  I committed your patch to trunk.
>
> Thank you very much.  I just skimmed through ibuffer.el and found the
> same error in ibuffer-redisplay.

Thanks, committed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.