GNU bug report logs - #11186
24.0.92; ERC: Better names for the different log file name formats

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11186 in the body.
You can then email your comments to 11186 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Deniz Dogan <deniz <at> dogan.se>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.92; ERC: Better names for the different log file name formats
Date: Thu, 05 Apr 2012 19:56:30 +0200

[Message part 1 (text/plain, inline)]

I think the names of the different log file name formats could be
improved a lot.  There's basically nothing that tells the ordinary user
what the different log formats imply.  Attached is a patch which changes
the name to be more verbose about what the formats mean.

Note that I have used #channel instead of "target" or "buffer" in this
patch, because the ordinary user will most likely understand that
#channel could very well be an IRC user as well.

[Message part 2 (text/plain, inline)]

=== modified file 'lisp/erc/erc-log.el'
--- lisp/erc/erc-log.el	2012-01-19 07:21:25 +0000
+++ lisp/erc/erc-log.el	2012-04-05 17:53:30 +0000
@@ -113,9 +113,9 @@
 custom function which returns the directory part and set
 `erc-log-channels-directory' to its name."
   :group 'erc-log
-  :type '(choice (const :tag "Long style" erc-generate-log-file-name-long)
-		 (const :tag "Long, but with network name rather than server"
+  :type '(choice (const :tag "#channel!nick <at> server:port.txt" erc-generate-log-file-name-long)
+		 (const :tag "#channel!nick <at> network.txt"
 			erc-generate-log-file-name-network)
-		 (const :tag "Short" erc-generate-log-file-name-short)
-		 (const :tag "With date" erc-generate-log-file-name-with-date)
+		 (const :tag "#channel.txt" erc-generate-log-file-name-short)
+		 (const :tag "#channel <at> date.txt" erc-generate-log-file-name-with-date)
 		 (function :tag "Other function")))

 (defcustom erc-truncate-buffer-on-save nil

Message #10 received at 11186-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11186-done <at> debbugs.gnu.org
Subject: Re: bug#11186: 24.0.92;
	ERC: Better names for the different log file name formats
Date: Sat, 06 Oct 2012 22:05:53 -0400

Version: 24.3

Thanks; applied to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.