GNU bug report logs - #11222
Vala projects with vapi in *_SOURCES are broken with automake 1.11.4

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11222 in the body.
You can then email your comments to 11222 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
To: bug-automake <at> gnu.org
Subject: Vala projects with vapi in *_SOURCES are broken with automake 1.11.4
Date: Wed, 11 Apr 2012 11:20:48 +0200

[Message part 1 (text/plain, inline)]

Hello,

bug#10894 introduced a regression in commit
51f61dfb1e861062aaa1d73fab71278c85fe0594<http://git.savannah.gnu.org/cgit/automake.git/commit/?id=51f61dfb1e861062aaa1d73fab71278c85fe0594>

Formerly it was using the whole content of the *_SOURCES variable, which
was causing problems with mixed C/vala projects, so you only grepped *.vala
files from it.
Fact is that not all vala files ends with the .vala extension, some of them
end with the .vapi extension, and they are currently ignored.

Attached patch fixes this issue

I can also write & provide a test

[Message part 2 (text/html, inline)]

[0001-vala-allow-vapi-files-in-SOURCES.patch (application/octet-stream, attachment)]

Message #8 received at 11222 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
Cc: 11222 <at> debbugs.gnu.org
Subject: Re: bug#11222: Vala projects with vapi in *_SOURCES are broken with
	automake 1.11.4
Date: Wed, 11 Apr 2012 23:34:14 +0200

On 04/11/2012 11:20 AM, Marc-Antoine Perennou wrote:
> Hello,
>
Hello Marc-Antoine, thanks for the report.

> bug#10894 introduced a regression in commit
> 51f61dfb1e861062aaa1d73fab71278c85fe0594
> <http://git.savannah.gnu.org/cgit/automake.git/commit/?id=51f61dfb1e861062aaa1d73fab71278c85fe0594>
>
> Formerly it was using the whole content of the *_SOURCES variable, which
> was causing problems with mixed C/vala projects, so you only grepped *.vala
> files from it.
> Fact is that not all vala files ends with the .vala extension, some of them
> end with the .vapi extension, and they are currently ignored.
>
Ouch :-(  This shows once again that our current testsuite coverage for the
Vala support is inadequate (and that my knowledge of Vala is pitiful, but
that was already waaay too clear I guess).

> Attached patch fixes this issue
> 
> I can also write & provide a test
> 
That would be great, thank you!  But if you do so, could you please try
to keep your test as short as possible (< 15 lines), to avoid issues with
copyright assignments?

I know this sounds like an absurd request, but the fact is: I'd like to
apply your fix and add your new test ASAP (for an "emergency" 1.11.5
release), and that would basically become impossible if we were to wait
for a copyright assignment form to fly over the Atlantic :-(  But if
your change is small and simple enough, the FSF allows it to be applied
without a copyright disclaimer, so we could have the new release in
a couple of days.

Thanks again for your help,
  Stefano

Message #11 received at 11222 <at> debbugs.gnu.org (full text, mbox):

From: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 11222 <at> debbugs.gnu.org
Subject: Re: bug#11222: Vala projects with vapi in *_SOURCES are broken with
	automake 1.11.4
Date: Thu, 12 Apr 2012 00:17:01 +0200

[Message part 1 (text/plain, inline)]

On 11 April 2012 23:34, Stefano Lattarini <stefano.lattarini <at> gmail.com>wrote:

> On 04/11/2012 11:20 AM, Marc-Antoine Perennou wrote:
> > Hello,
> >
> Hello Marc-Antoine, thanks for the report.
>
> > bug#10894 introduced a regression in commit
> > 51f61dfb1e861062aaa1d73fab71278c85fe0594
> > <
> http://git.savannah.gnu.org/cgit/automake.git/commit/?id=51f61dfb1e861062aaa1d73fab71278c85fe0594
> >
> >
> > Formerly it was using the whole content of the *_SOURCES variable, which
> > was causing problems with mixed C/vala projects, so you only grepped
> *.vala
> > files from it.
> > Fact is that not all vala files ends with the .vala extension, some of
> them
> > end with the .vapi extension, and they are currently ignored.
> >
> Ouch :-(  This shows once again that our current testsuite coverage for the
> Vala support is inadequate (and that my knowledge of Vala is pitiful, but
> that was already waaay too clear I guess).
>
> > Attached patch fixes this issue
> >
> > I can also write & provide a test
> >
> That would be great, thank you!  But if you do so, could you please try
> to keep your test as short as possible (< 15 lines), to avoid issues with
> copyright assignments?
>
> I know this sounds like an absurd request, but the fact is: I'd like to
> apply your fix and add your new test ASAP (for an "emergency" 1.11.5
> release), and that would basically become impossible if we were to wait
> for a copyright assignment form to fly over the Atlantic :-(  But if
> your change is small and simple enough, the FSF allows it to be applied
> without a copyright disclaimer, so we could have the new release in
> a couple of days.
>
> Thanks again for your help,
>  Stefano
>

Attached is a patch which adds a minimal vapi file to the vala2 test which
should be ok regarding copyrights.
Vapi files are actually wrappers for vala to understand C headers.

[Message part 2 (text/html, inline)]

[0001-vala-update-vala2-test-to-test-vapi-files-handling.patch (application/octet-stream, attachment)]

Message #14 received at 11222 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
Cc: "automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	11222 <at> debbugs.gnu.org
Subject: Re: bug#11222: Vala projects with vapi in *_SOURCES are broken with
	automake 1.11.4
Date: Thu, 12 Apr 2012 13:08:59 +0200

[Message part 1 (text/plain, inline)]

[Adding automake-patches]

Reference: <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11222>

On 04/12/2012 12:17 AM, Marc-Antoine Perennou wrote:
>
> Attached is a patch which adds a minimal vapi file to the vala2 test which
> should be ok regarding copyrights.
> Vapi files are actually wrappers for vala to understand C headers.
> 
Thanks.  I've used your feedback to condense a new test case (instead of
editing the pre-existing vala2.test), and then applied your original
bug-fixing patch, and verified that it actually causes the new test to
pass.

The two resulting patches are attached; since you are listed as the main
author of one them and as a co-author of the other one, I'll wait for
your ACK before pushing.

Best regards,
  Stefano

[0001-vala-test-vapi-files-handling-still-failing.patch (text/x-diff, attachment)]

[0002-vala-fix-vapi-files-handling.patch (text/x-diff, attachment)]

Message #17 received at 11222 <at> debbugs.gnu.org (full text, mbox):

From: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: "automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	11222 <at> debbugs.gnu.org
Subject: Re: bug#11222: Vala projects with vapi in *_SOURCES are broken with
	automake 1.11.4
Date: Thu, 12 Apr 2012 13:24:16 +0200

[Message part 1 (text/plain, inline)]

On 12 April 2012 13:08, Stefano Lattarini <stefano.lattarini <at> gmail.com>wrote:

> [Adding automake-patches]
>
> Reference: <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11222>
>
> On 04/12/2012 12:17 AM, Marc-Antoine Perennou wrote:
> >
> > Attached is a patch which adds a minimal vapi file to the vala2 test
> which
> > should be ok regarding copyrights.
> > Vapi files are actually wrappers for vala to understand C headers.
> >
> Thanks.  I've used your feedback to condense a new test case (instead of
> editing the pre-existing vala2.test), and then applied your original
> bug-fixing patch, and verified that it actually causes the new test to
> pass.
>
> The two resulting patches are attached; since you are listed as the main
> author of one them and as a co-author of the other one, I'll wait for
> your ACK before pushing.
>
> Best regards,
>  Stefano
>


Looks fine to me

[Message part 2 (text/html, inline)]

Message #20 received at 11222 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Marc-Antoine Perennou <Marc-Antoine <at> Perennou.com>
Cc: "automake-patches <at> gnu.org" <automake-patches <at> gnu.org>,
	11222 <at> debbugs.gnu.org
Subject: Re: bug#11222: Vala projects with vapi in *_SOURCES are broken with
	automake 1.11.4
Date: Thu, 12 Apr 2012 14:26:04 +0200

tags 11222 + patch
close 11222
thanks

On 04/12/2012 01:24 PM, Marc-Antoine Perennou wrote:
> On 12 April 2012 13:08, Stefano Lattarini <stefano.lattarini <at> gmail.com>wrote:
> 
>> The two resulting patches are attached; since you are listed as the main
>> author of one them and as a co-author of the other one, I'll wait for
>> your ACK before pushing.
> 
> Looks fine to me
> 
Thanks, pushed.  I'm thus closing this bug report.

Regards,
  Stefano

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.