GNU bug report logs - #11253
24.0.95; [PATCH] Support fringe indicators in flymake

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11253 in the body.
You can then email your comments to 11253 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Mon, 16 Apr 2012 20:49:42 +0800

[Message part 1 (text/plain, inline)]

Please comment. Thanks.

[0001-Support-fringe-indicators-in-flymake.patch (text/x-diff, attachment)]

Message #10 received at 11253-done <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 11253-done <at> debbugs.gnu.org
Subject: Re: bug#11253: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Sat, 14 Jul 2012 20:06:51 +0800

[Message part 1 (text/plain, inline)]

Applied in trunk.

A screen shot is attached.

[flymake-fringe-bitmap.png (image/png, inline)]

Message #13 received at 11253 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11253 <at> debbugs.gnu.org
Subject: Re: bug#11253: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Sat, 14 Jul 2012 17:14:17 +0300

> From: Leo <sdl.web <at> gmail.com>
> Date: Sat, 14 Jul 2012 20:06:51 +0800
> 
> Applied in trunk.

Thanks.  Could you please document the new bitmap should in NEWS and
in the ELisp manual?

Message #16 received at 11253 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 11253 <at> debbugs.gnu.org
Subject: Re: bug#11253: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Sat, 14 Jul 2012 22:34:46 +0800

On 2012-07-14 22:14 +0800, Eli Zaretskii wrote:
> Thanks.  Could you please document the new bitmap should in NEWS and
> in the ELisp manual?

Would something like the following (excluding ChangeLogs) suffice?

=== modified file 'doc/lispref/display.texi'
--- doc/lispref/display.texi	2012-06-17 05:13:40 +0000
+++ doc/lispref/display.texi	2012-07-14 14:31:46 +0000
@@ -3550,7 +3550,7 @@
 @itemx @code{vertical-bar}, @code{horizontal-bar}
 Used for different types of fringe cursors.
 
-@item @code{empty-line}, @code{question-mark}
+@item @code{empty-line}, @code{question-mark}, @code{exclamation-mark}
 Unused.
 @end table
 

=== modified file 'etc/NEWS'
--- etc/NEWS	2012-07-14 02:19:07 +0000
+++ etc/NEWS	2012-07-14 14:33:03 +0000
@@ -113,6 +113,8 @@
 ** Face underlining can now use a wave.
 See the "Face Attributes" section of the Elisp manual.
 
+** New fringe bitmap exclamation-mark
+
 ** String values for `initial-buffer-choice' also apply to emacsclient
 frames, if emacsclient is only told to open a new frame without
 specifying any file to visit or expression to evaluate.

=== modified file 'src/fringe.c'
--- src/fringe.c	2012-07-14 11:44:39 +0000
+++ src/fringe.c	2012-07-14 14:28:30 +0000
@@ -107,7 +107,7 @@
 static unsigned short question_mark_bits[] = {
   0x3c, 0x7e, 0x7e, 0x0c, 0x18, 0x18, 0x00, 0x18, 0x18};
 
-/* A exclamation mark.  */
+/* An exclamation mark.  */
 /*
   ...XX...
   ...XX...

Message #19 received at 11253 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Leo <sdl.web <at> gmail.com>
Cc: 11253 <at> debbugs.gnu.org
Subject: Re: bug#11253: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Sat, 14 Jul 2012 18:02:27 +0300

> From:  Leo <sdl.web <at> gmail.com>
> Cc: 11253 <at> debbugs.gnu.org
> Date: Sat, 14 Jul 2012 22:34:46 +0800
> 
> On 2012-07-14 22:14 +0800, Eli Zaretskii wrote:
> > Thanks.  Could you please document the new bitmap should in NEWS and
> > in the ELisp manual?
> 
> Would something like the following (excluding ChangeLogs) suffice?

Yes, but...

> +** New fringe bitmap exclamation-mark

This needs a period at the end of the sentence.

Also, don't we want to advertise the new feature in flymake.el?

Thanks.

Message #22 received at 11253 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 11253 <at> debbugs.gnu.org
Subject: Re: bug#11253: 24.0.95; [PATCH] Support fringe indicators in flymake
Date: Sun, 15 Jul 2012 08:57:11 +0800

On 2012-07-14 23:02 +0800, Eli Zaretskii wrote:
> This needs a period at the end of the sentence.
>
> Also, don't we want to advertise the new feature in flymake.el?

Thank you for the feedback. I have made the changes in trunk.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.