GNU bug report logs - #11488
PATCH: Don't kill *vc-diff* on revert.

Previous Next

Package: emacs;

Reported by: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>

Date: Wed, 16 May 2012 19:05:01 UTC

Severity: wishlist

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11488 in the body.
You can then email your comments to 11488 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11488; Package emacs. (Wed, 16 May 2012 19:05:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 16 May 2012 19:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: PATCH: Don't kill *vc-diff* on revert.
Date: Wed, 16 May 2012 15:04:23 -0400

When I hit C-x v u in a version controlled file, Emacs shows *vc-diff*
asks if you're sure then kills it.  I wish it would keep the buffer
around in case I want to undo my revert with Diff Mode.

Thanks for Emacs,
aaron

2012-05-04  Aaron S. Hawley  <aaron.s.hawley <at> gmail.com>

        * vc/vc.el (vc-revert, vc-rollback): Just quit *vc-diff* buffer
        don't kill it when reverting or rolling back.

--- vc/vc.el	2012-04-02 19:37:30.000000000 -0400
+++ vc/vc.el	2012-05-04 13:03:18.104977200 -0400
@@ -2303,7 +2303,7 @@
 				       (if (= nfiles 1) "" "s"))))))
 	    (error "Revert canceled")))
       (when diff-buffer
-	(quit-windows-on diff-buffer t)))
+	(quit-windows-on diff-buffer)))
     (dolist (file files)
       (message "Reverting %s..." (vc-delistify files))
       (vc-revert-file file)
@@ -2349,7 +2349,7 @@
     ;; Display changes
     (unless (yes-or-no-p "Discard these revisions? ")
       (error "Rollback canceled"))
-    (quit-windows-on "*vc-diff*" t)
+    (quit-windows-on "*vc-diff*")
     ;; Do the actual reversions
     (message "Rolling back %s..." (vc-delistify files))
     (with-vc-properties
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11488; Package emacs. (Tue, 29 May 2012 11:45:02 GMT) Full text and rfc822 format available.

Message #8 received at 11488 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com>
Cc: 11488 <at> debbugs.gnu.org
Subject: Re: bug#11488: PATCH: Don't kill *vc-diff* on revert.
Date: Tue, 29 May 2012 19:43:14 +0800

"Aaron S. Hawley" <aaron.s.hawley <at> gmail.com> writes:

> When I hit C-x v u in a version controlled file, Emacs shows *vc-diff*
> asks if you're sure then kills it.  I wish it would keep the buffer
> around in case I want to undo my revert with Diff Mode.

Looks good.  Committed; thanks.
bug closed, send any further explanations to 11488 <at> debbugs.gnu.org and "Aaron S. Hawley" <aaron.s.hawley <at> gmail.com> Request was from Chong Yidong <cyd <at> gnu.org> to control <at> debbugs.gnu.org. (Tue, 29 May 2012 11:45:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 27 Jun 2012 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 304 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.