GNU bug report logs - #11698
[PATCH] Enable mouse-face on the mode-line area of which-func

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11698 in the body.
You can then email your comments to 11698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Masatake YAMATO <yamato <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Enable mouse-face on the mode-line area of which-func 
Date: Thu, 14 Jun 2012 02:35:11 +0900 (JST)

This is not a bug report.
This is a request for merging the attached patch 
to the emacs official source tree.


See the patch.
The original code is written in 2004.
I implemented mouse-face on mode-line in 2005-06-07:)



2012-06-13  Masatake YAMATO  <yamato <at> redhat.com>

	* progmodes/which-func.el (which-func-format): Enable
	mouse-face.

=== modified file 'lisp/progmodes/which-func.el'
*** lisp/progmodes/which-func.el	2012-06-03 11:10:44 +0000
--- lisp/progmodes/which-func.el	2012-06-13 17:20:38 +0000
***************
*** 144,150 ****
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 ;;mouse-face highlight	; currently not evaluated :-(
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")
--- 144,150 ----
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 mouse-face highlight
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")

Message #8 received at 11698 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Masatake YAMATO <yamato <at> redhat.com>
Cc: 11698 <at> debbugs.gnu.org
Subject: Re: bug#11698: [PATCH] Enable mouse-face on the mode-line area of
	which-func
Date: Wed, 13 Jun 2012 16:14:31 -0400

Masatake YAMATO wrote:

> ! 		 mouse-face highlight

Is this really desirable? Many other parts of the mode line can be
clicked on, but do not have a mouse-face. Isn't the change in cursor
sufficient?

Message #11 received at 11698 <at> debbugs.gnu.org (full text, mbox):

From: Masatake YAMATO <yamato <at> redhat.com>
To: rgm <at> gnu.org
Cc: 11698 <at> debbugs.gnu.org
Subject: Re: bug#11698: [PATCH] Enable mouse-face on the mode-line area of
	which-func
Date: Thu, 14 Jun 2012 12:01:21 +0900 (JST)

Glenn Morris wrote:
> Masatake YAMATO wrote:
> 
>> ! 		 mouse-face highlight
> 
> Is this really desirable? Many other parts of the mode line can be
> clicked on, but do not have a mouse-face. Isn't the change in cursor
> sufficient?


It seems that mode-line-highlight is used for mouse-face.

How do you think to use it in which-func for keeping consistency
between other area on the mode line?

I think sometimes cursor is not sufficient. It doesn't tells just the
pixel under the cursor is something clickable. The feed-back with
mouse-face can tell the area under the cursor is something
clickable. Sometimes it is obvious that the area even without mouse
face. However, it may be a bit difficult to recognize one-character
area like area for buffer-coding system. 


=== modified file 'lisp/progmodes/which-func.el'
*** lisp/progmodes/which-func.el	2012-06-03 11:10:44 +0000
--- lisp/progmodes/which-func.el	2012-06-14 02:55:51 +0000
***************
*** 144,150 ****
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 ;;mouse-face highlight	; currently not evaluated :-(
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")
--- 144,150 ----
      (:propertize which-func-current
  		 local-map ,which-func-keymap
  		 face which-func
! 		 mouse-face mode-line-highlight
  		 help-echo "mouse-1: go to beginning\n\
  mouse-2: toggle rest visibility\n\
  mouse-3: go to end")

Message #16 received at 11698-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11698-done <at> debbugs.gnu.org
Subject: Re: bug#11698: [PATCH] Enable mouse-face on the mode-line area of
	which-func
Date: Mon, 25 Jun 2012 03:13:13 -0400

Version: 24.2

Masatake YAMATO wrote:

> ! 		 mouse-face mode-line-highlight

Applied to emacs-24 branch, thanks. (I hadn't appreciated that
mode-line-highlight is already used all over the place in the mode-line.)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.