GNU bug report logs -
#11706
24.1.50; Wrong behavior of move-end-of-line in ERC
Previous Next
Reported by: Antoine Levitt <antoine.levitt <at> gmail.com>
Date: Thu, 14 Jun 2012 07:52:01 UTC
Severity: normal
Tags: patch
Found in version 24.1.50
Fixed in version 24.3
Done: Glenn Morris <rgm <at> gnu.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11706 in the body.
You can then email your comments to 11706 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#11706
; Package
emacs
.
(Thu, 14 Jun 2012 07:52:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Antoine Levitt <antoine.levitt <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Thu, 14 Jun 2012 07:52:01 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
Hi,
(setq erc-timestamp-only-if-changed-flag nil
erc-hide-timestamps t
erc-insert-timestamp-function 'erc-insert-timestamp-left)
Join IRC, type a few line, then go back in the text and type C-e. Point
will stop one character before EOL. It's annoying.
My quick fix is
diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index 5831233..b43b2b3 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil."
'isearch-open-invisible 'timestamp ts)
;; N.B. Later use categories instead of this harmless, but
;; inelegant, hack. -- BPT
- (when erc-timestamp-intangible
+ (when (and erc-timestamp-intangible (not erc-hide-timestamps))
(erc-put-text-property 0 (length ts) 'intangible t ts))
ts)
""))
I think it's fine to install in trunk and certainly unlikely to cause
any further bugs (there's not much point in setting something invisible
as intangible), but I don't know very well how the code works, so I'd
appreciate it if someone could review it and fix the whole thing
consistently.
Antoine
Reply sent
to
Glenn Morris <rgm <at> gnu.org>
:
You have taken responsibility.
(Sun, 07 Oct 2012 01:42:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Antoine Levitt <antoine.levitt <at> gmail.com>
:
bug acknowledged by developer.
(Sun, 07 Oct 2012 01:42:02 GMT)
Full text and
rfc822 format available.
Message #10 received at 11706-done <at> debbugs.gnu.org (full text, mbox):
Version: 24.3
Thanks; applied to trunk.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Sun, 04 Nov 2012 12:24:03 GMT)
Full text and
rfc822 format available.
This bug report was last modified 11 years and 200 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.