GNU bug report logs - #11812
emacs24 -- Addition of language/persian.el and updates to leim/quail/persian.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11812 in the body.
You can then email your comments to 11812 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mohsen BANAN <list-general <at> mohsen.1.banan.byname.net>
To: bug-gnu-emacs <at> gnu.org
Subject: emacs24 -- Addition of language/persian.el and updates to
	leim/quail/persian.el
Date: Thu, 28 Jun 2012 15:36:52 -0700

[Message part 1 (text/plain, inline)]

In the attached tar file are 3 files:

emacs24-banan-patches/lisp/language/persian.el
   Is a new file that adds persian as an emacs
   language.

emacs24-banan-patches/lisp/loadup.el.diff
   Is the (load "language/persian") added to lisp/loadup.el

emacs24-banan-patches/leim/quail/persian.el.diff
   Is an update and bug fix to leim/quail/persian.el.
   Based on experience and feedback some keys are
   mapped differently.
   Additional documentation has been added.


Please add the new file and apply the context diffs.

Thank you in advance.

...Mohsen

[emacs24-banan-patches.tar (application/x-tar, attachment)]

Message #10 received at 11812-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11812-done <at> debbugs.gnu.org
Subject: Re: bug#11812: emacs24 -- Addition of language/persian.el and updates
	to leim/quail/persian.el
Date: Mon, 06 Aug 2012 03:39:08 -0400

Version: 24.2

Mohsen BANAN wrote:

> emacs24-banan-patches/lisp/language/persian.el
>    Is a new file that adds persian as an emacs language.

Applied, thanks.

> emacs24-banan-patches/leim/quail/persian.el.diff
>    Is an update and bug fix to leim/quail/persian.el.
>    Based on experience and feedback some keys are mapped differently.

I have no way to judge this, but since you are the author I applied it.

Message #13 received at 11812 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11812 <at> debbugs.gnu.org
Cc: list-general <at> mohsen.1.banan.byname.net
Subject: Re: bug#11812: emacs24 -- Addition of language/persian.el and updates
	to leim/quail/persian.el
Date: Mon, 06 Aug 2012 16:52:12 -0400

Glenn Morris wrote:

>> emacs24-banan-patches/lisp/language/persian.el
>>    Is a new file that adds persian as an emacs language.
>
> Applied, thanks.

So I actually looked at the file, and its entire contents are extremely
similar to the already existing "Arabic" section of
language/misc-lang.el. The only differences seem to be to replace
"Arabic" with "Persian", to change the sample text, and change the
input-method from "arabic" to "farsi-transliterate-banan".

Surely there is some inconsistency here?

Message #16 received at 11812 <at> debbugs.gnu.org (full text, mbox):

From: list-general <at> mohsen.1.banan.byname.net
To: Glenn Morris <rgm <at> gnu.org>
Cc: 11812 <at> debbugs.gnu.org
Subject: Re: bug#11812: emacs24 -- Addition of language/persian.el and updates
	to leim/quail/persian.el
Date: Tue, 07 Aug 2012 23:44:04 -0700

>>>>> On Mon, 06 Aug 2012 16:52:12 -0400, Glenn Morris <rgm <at> gnu.org> said:

  GM> Glenn Morris wrote:
  >>> emacs24-banan-patches/lisp/language/persian.el
  >>> Is a new file that adds persian as an emacs language.
  >> 
  >> Applied, thanks.

  GM> So I actually looked at the file, and its entire contents are extremely
  GM> similar to the already existing "Arabic" section of
  GM> language/misc-lang.el. The only differences seem to be to replace
  GM> "Arabic" with "Persian", to change the sample text, and change the
  GM> input-method from "arabic" to "farsi-transliterate-banan".

  GM> Surely there is some inconsistency here?

Thank you for applying those patches.

I tried the latest version and addition of Persian
to "Set Language Environment" works fine.

Persian and Arabic are different languages.
Persian is an Indo-European langauge.
Arabic is a non Indo-European langauge.

Persian script uses the Arabic alphabet.

The charset used for Persian and Arabic is the
same. Some of the chars used for Persian and
Arabic are common and some are separate.

So, the part of language/persian.el that is
coding-system and charset related is same as the 
arabic part of language/misc-lang.el.

Input methods for Persian and Arabic are of course
separately specified in quail/arabic.el and
quail/persian.el. And the default input method for
each language specification is in
set-language-info-alist.

So with what is in place, things work, but things
are not clean.

I am not familiar with the history of how
language/misc-lang.el evolved.

I think the right way of doing it is:

  - Create a language/persoarabic.el that is 
    the common part of language/persian.el
    and language/arabic.el (see next).

  - Create a language/arabic.el which is just the 
    arabic part of language/misc-lang.el
    and which loads language/persoarabic.el

  - Make language/persian.el also load the common
    part as language/persoarabic.el

More broadly speaking, I think
language/misc-lang.el needs to be cleaned up so
that alphabeticly sorted list of languages in "Set
Language Environment" is cleaner.

A bit later, perhaps we should bring this up in
the developers list and do that cleanup.

For now, Persian has been added as an emacs
language. That is a good thing.

Thanks again for applying those patches.

...Mohsen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.