GNU bug report logs - #11873
24.1; Build failure with glibc-2.16

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11873 in the body.
You can then email your comments to 11873 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ulrich Mueller <ulm <at> gentoo.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1; Build failure with glibc-2.16
Date: Sat, 7 Jul 2012 17:48:27 +0200

Forwarding downstream bug: <https://bugs.gentoo.org/424755>

C11 removed the "gets" function and glibc-2.16 no longer defines it.
However, the gnulib that comes with emacs-24.1 still assumes that
"gets" is defined.

   armv7a-hardfloat-linux-gnueabi-gcc -DHAVE_CONFIG_H -I. -I../src -I/var/tmp/portage/app-editors/emacs-24.1/work/emacs-24.1/src     -O2 -pipe -march=armv7-a -mtune=cortex-a9 -mfpu=vfpv3-d16 -c md5.c
   In file included from md5.h:24:0,
                    from md5.c:25:
   ./stdio.h:1030:1: erreur: ‘gets’ undeclared here (not in a function)
   make[2]: *** [md5.o] Erreur 1

Emacs trunk has already been updated to a newer gnulib version where
the problem is fixed:
<http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/108385>
The bug still exists in the emacs-24 branch though.

Here is the patch that is applied to the Gentoo package:
<http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo/src/patchsets/emacs/24.1/04_all_gnulib-gets.patch?view=log>

Message #12 received at 11873 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Chong Yidong <cyd <at> gnu.org>
Cc: 11873 <at> debbugs.gnu.org
Subject: Re: Another important bug
Date: Tue, 14 Aug 2012 00:57:27 -0700

On 08/13/2012 10:14 PM, Chong Yidong wrote:
> Hi Paul,
> 
> Could you take a look at the emacs/gnulib bug at
> 
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11873
> 
> And review the patch indicated there?

That patch also looks OK.

One other thought is to merge all the gnulib patches
into 24.2.  This would be approximately a 5000-line
change.  It would fix the bug in question, along with
several other portability problems.  It would be a trivial
patch to generate, but would take some time to review
if people wanted to review it manually and/or cherry
pick some of the patches (I don't want to spend that time).
It'd be about a 5000-line patch.  These patches are
tested in other software distributions (they're in
the latest coreutils) so they're tested, albeit not
tested when integrated with Emacs 24.  The last time I
proposed this sort of thing, you or Stefan (I forget who)
decided not to do it, which is understandable, though I've
also gotten email from others wondering why those porting
fixes didn't get merged in....

Message #15 received at 11873 <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 11873 <at> debbugs.gnu.org
Subject: Re: bug#11873: Another important bug
Date: Tue, 14 Aug 2012 18:00:21 +0800

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> That patch also looks OK.

OK, thanks, committed.

> One other thought is to merge all the gnulib patches
> into 24.2.  This would be approximately a 5000-line
> change.  It would fix the bug in question, along with
> several other portability problems.  It would be a trivial
> patch to generate, but would take some time to review
> if people wanted to review it manually and/or cherry
> pick some of the patches (I don't want to spend that time).

That doesn't sound feasible if we want to release 24.2 promptly.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.