GNU bug report logs - #11914
Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Wed, 11 Jul 2012 19:20:01 UTC

Severity: minor

Found in version 24.1.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11914 in the body.
You can then email your comments to 11914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to eggert <at> cs.ucla.edu, bug-gnu-emacs <at> gnu.org:
bug#11914; Package emacs. (Wed, 11 Jul 2012 19:20:02 GMT) Full text and rfc822 format available.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
Date: Wed, 11 Jul 2012 15:14:18 -0400

Package: emacs
Version: 24.1.50
Severity: minor

(Very similar to bug#11905)

src/s/sol2-6.h does this:
    
    /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
       ghazi <at> caip.rutgers.edu, 7/21/97.  Don't redefine if already defined
       (e.g., by config.h). */
    #ifndef HAVE_LIBKSTAT
    #define HAVE_LIBKSTAT
    #endif

The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
this properly via configure checks (?), so there is no need for Emacs's
src/s/sol2-6.h to define HAVE_LIBKSTAT.
Reply sent to Paul Eggert <eggert <at> cs.ucla.edu>:
You have taken responsibility. (Wed, 11 Jul 2012 20:48:01 GMT) Full text and rfc822 format available.
Notification sent to Glenn Morris <rgm <at> gnu.org>:
bug acknowledged by developer. (Wed, 11 Jul 2012 20:48:02 GMT) Full text and rfc822 format available.

Message #8 received at 11914-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 11914-done <at> debbugs.gnu.org
Subject: Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
Date: Wed, 11 Jul 2012 13:41:40 -0700

On 07/11/2012 12:14 PM, Glenn Morris wrote:
> there is no need for Emacs's
> src/s/sol2-6.h to define HAVE_LIBKSTAT.

Yes, thanks, I made that change in trunk bzr 109034.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 09 Aug 2012 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 283 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.