GNU bug report logs - #12072
patch: fix quail inscript non-qwerty

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12072 in the body.
You can then email your comments to 12072 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Bergey <bergey <at> alum.mit.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: patch: fix quail inscript non-qwerty
Date: Fri, 27 Jul 2012 12:59:14 -0400

The attached patch fixes the quail Inscript (Indian language family)
input methods when the underlying keyboard layout is not qwerty.  The
inscript layout is positional---the vowels should be under the left
hand.  quail-keyboard-layout should be consulted to ensure this happens.
Each of the inscript layouts is defined by calling
quail-define-inscript-package, so one change should fix them all.

I've tested this patch with emacs 24.1, using qwerty and dvorak
keyboards in X11, and devanagari-inscript input method.

Changelog:
2012-07-27 Daniel Bergey <bergey <at> alum.mit.edu>

    leim/quail/indian.el: set kbd-translate for all Inscript layouts
    
    Inscript is a positional layout---vowels should be on the left hand
    regardless of the underlying characters produced by those keys.

Patch:

*** /tmp/9CVXFc_indian.el	2012-07-27 12:56:22.116246859 -0400
--- leim/quail/indian.el	2012-07-27 12:31:01.250554107 -0400
***************
*** 309,315 ****
  (defun quail-define-inscript-package (char-tables key-tables pkgname lang
                                                    title docstring)
    (funcall 'quail-define-package pkgname lang title nil docstring
! 	   nil nil nil nil nil nil nil nil)
    (let (char-table key-table char key)
      (while (and char-tables key-tables)
        (setq char-table  (car char-tables)
--- 309,315 ----
  (defun quail-define-inscript-package (char-tables key-tables pkgname lang
                                                    title docstring)
    (funcall 'quail-define-package pkgname lang title nil docstring
! 	   nil nil nil t nil nil nil nil)
    (let (char-table key-table char key)
      (while (and char-tables key-tables)
        (setq char-table  (car char-tables)

Message #10 received at 12072-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 12072-done <at> debbugs.gnu.org
Subject: Re: bug#12072: patch: fix quail inscript non-qwerty
Date: Fri, 17 Aug 2012 03:29:41 -0400

Version: 24.3

Thanks. I don't understand this stuff, but you seem to know what you are
talking about, so I applied this to Emacs trunk, which is currently
expected to be released as 24.3.

Message #13 received at 12072 <at> debbugs.gnu.org (full text, mbox):

From: Kenichi Handa <handa <at> gnu.org>
To: Daniel Bergey <bergey <at> alum.mit.edu>
Cc: rgm <at> gnu.org, 12072 <at> debbugs.gnu.org
Subject: Re: bug#12072: patch: fix quail inscript non-qwerty
Date: Fri, 17 Aug 2012 22:49:27 +0900

In article <87txwtqgwt.fsf <at> wonderlust.lan>, Daniel Bergey <bergey <at> alum.mit.edu> writes:

> The attached patch fixes the quail Inscript (Indian language family)
> input methods when the underlying keyboard layout is not qwerty.  The
> inscript layout is positional---the vowels should be under the left
> hand.  quail-keyboard-layout should be consulted to ensure this happens.
> Each of the inscript layouts is defined by calling
> quail-define-inscript-package, so one change should fix them all.

Thank you for the fix.  I agree that your change is necessary.

In article <yy5lex9ga.fsf <at> fencepost.gnu.org>, Glenn Morris <rgm <at> gnu.org> writes:

> Thanks. I don't understand this stuff, but you seem to know what you are
> talking about, so I applied this to Emacs trunk, which is currently
> expected to be released as 24.3.

Thank you for committing the patch.

---
Kenichi Handa
handa <at> gnu.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.