GNU bug report logs - #12188
24.1; awk-mode eletric { incorrectly inserts newline

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12188 in the body.
You can then email your comments to 12188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Mon, 13 Aug 2012 08:32:18 +0800

1. emacs -q x.awk
2. C-c C-a to enable auto-newline mode
3. Type: NR==3 {

You should see { starts at a new line instead of following NR==3, i.e. {
helps creating incorrect awk programs.

Leo

Message #8 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Leo <sdl.web <at> gmail.com>
Cc: bug-cc-mode <at> gnu.org, 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Wed, 15 Aug 2012 14:42:33 +0000

Hello, Leo,

On Mon, Aug 13, 2012 at 08:32:18AM +0800, Leo wrote:
> 1. emacs -q x.awk
> 2. C-c C-a to enable auto-newline mode
> 3. Type: NR==3 {

> You should see { starts at a new line instead of following NR==3, i.e. {
> helps creating incorrect awk programs.

The current assumption is that the "{" starts the action for the pattern
"NR==3".

Although the implicit action (i.e., print the line) isn't rare, having
such a line followed by the implicit pattern (i.e., match everything) is
surely uncommon enough not to make it the default assumption.

I think this default is fine as it is.  It is, of course, possible to
configure auto newlines to behave as you suggest.

> Leo

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #11 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Leo <sdl.web <at> gmail.com>, 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Wed, 15 Aug 2012 13:41:44 -0400

Alan Mackenzie wrote:

> The current assumption is that the "{" starts the action for the pattern
> "NR==3".

I think that's his point (it sure would be helpful to get less terse bug
reports). awk-mode is not consistent with that assumption.

cat foo.awk:

#!/usr/bin/gawk -f

NF == 3 
{
    print "three fields" 
}

chmod 755 foo.awk

echo "1 2" | ./foo.awk
  -> three fields


To work correctly, it needs to be either:

NF == 3 \
{
    print "three fields"
}

or

NF == 3 {
  print "three fields"
}

Message #14 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Thu, 16 Aug 2012 06:44:27 +0800

On 2012-08-15 22:42 +0800, Alan Mackenzie wrote:
> The current assumption is that the "{" starts the action for the pattern
> "NR==3".

syntax after NR==3 is not recognised as `defun-open' which causes { to
be inserted in a new line. I think there is a bug somewhere (probably
c-guess-basic-syntax) regarding this.

Leo

Message #17 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Leo <sdl.web <at> gmail.com>
Cc: bug-cc-mode <at> gnu.org, Glenn Morris <rgm <at> gnu.org>, 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Fri, 17 Aug 2012 21:05:09 +0000

Hello, Leo and Glenn.

On Thu, Aug 16, 2012 at 06:44:27AM +0800, Leo wrote:
> On 2012-08-15 22:42 +0800, Alan Mackenzie wrote:
> > The current assumption is that the "{" starts the action for the pattern
> > "NR==3".

I got confused by the "should" in your original report.  Sorry.  Yes, it
is a bug, and thanks for the report.

> syntax after NR==3 is not recognised as `defun-open' which causes { to
> be inserted in a new line. I think there is a bug somewhere (probably
> c-guess-basic-syntax) regarding this.

In AWK Mode, the recognition of a beginning-of-defun (for C-M-a) is done
heuristically.  c-guess-b-s can't detect an AWK defun-open.

Which all means the solution will be messy and heuristic too.  <sigh>.

> Leo

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #20 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Leo <sdl.web <at> gmail.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Sat, 18 Aug 2012 19:57:55 +0000

Hello, Leo.

On Thu, Aug 16, 2012 at 06:44:27AM +0800, Leo wrote:
> On 2012-08-15 22:42 +0800, Alan Mackenzie wrote:
> > The current assumption is that the "{" starts the action for the pattern
> > "NR==3".

> syntax after NR==3 is not recognised as `defun-open' which causes { to
> be inserted in a new line. I think there is a bug somewhere (probably
> c-guess-basic-syntax) regarding this.

It wasn't as bad as I thought.  Other patterns (not involving "==")
correctly insert a newline _after_ (not before) a "{" is typed.
c-guess-basic-syntax was mis-parsing the "==" as an equals sign, hence
parsed the "{" as a brace-block opener rather than defun-open.

This patch should fix it.  Would you try it out, please, and report back.
Thanks!



diff -r 1adcc48506f9 cc-cmds.el
--- a/cc-cmds.el	Sun Apr 22 09:42:29 2012 +0000
+++ b/cc-cmds.el	Sat Aug 18 19:41:01 2012 +0000
@@ -495,13 +495,16 @@
       (insert-char ?\n 1)
       ;; In AWK (etc.) or in a macro, make sure this CR hasn't changed
       ;; the syntax.  (There might already be an escaped NL there.)
-      (when (or (c-at-vsemi-p (1- (point)))
-		(let ((pt (point)))
-		  (save-excursion
-		    (backward-char)
-		    (and (c-beginning-of-macro)
-			 (progn (c-end-of-macro)
-				(< (point) pt))))))
+      (when (or
+	     (save-excursion
+	       (c-skip-ws-backward (c-point 'bopl))
+	       (c-at-vsemi-p))
+	     (let ((pt (point)))
+	       (save-excursion
+		 (backward-char)
+		 (and (c-beginning-of-macro)
+		      (progn (c-end-of-macro)
+			     (< (point) pt))))))
 	(backward-char)
 	(insert-char ?\\ 1)
 	(forward-char))
diff -r 1adcc48506f9 cc-engine.el
--- a/cc-engine.el	Sun Apr 22 09:42:29 2012 +0000
+++ b/cc-engine.el	Sat Aug 18 19:41:01 2012 +0000
@@ -9606,12 +9606,12 @@
 			     (setq tmpsymbol nil)
 			     (while (and (> (point) placeholder)
 					 (zerop (c-backward-token-2 1 t))
-					 (/= (char-after) ?=))
+					 (not (looking-at "=\\([^=]\\|$\\)")))
 			       (and c-opt-inexpr-brace-list-key
 				    (not tmpsymbol)
 				    (looking-at c-opt-inexpr-brace-list-key)
 				    (setq tmpsymbol 'topmost-intro-cont)))
-			     (eq (char-after) ?=))
+			     (looking-at "=\\([^=]\\|$\\)"))
 			   (looking-at c-brace-list-key))
 		       (save-excursion
 			 (while (and (< (point) indent-point)



> Leo

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #23 received at 12188 <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 12188 <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Sun, 19 Aug 2012 08:54:21 +0800

On 2012-08-19 03:57 +0800, Alan Mackenzie wrote:
> This patch should fix it.  Would you try it out, please, and report back.
> Thanks!

It worked. Thanks.

Leo

Message #28 received at 12188-done <at> debbugs.gnu.org (full text, mbox):

From: Leo <sdl.web <at> gmail.com>
To: 12188-done <at> debbugs.gnu.org
Subject: Re: bug#12188: 24.1; awk-mode eletric { incorrectly inserts newline
Date: Mon, 17 Sep 2012 06:44:07 +0800

Already fixed; closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.