GNU bug report logs - #12212
[patch] dd's help text contains superfluous word

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12212 in the body.
You can then email your comments to 12212 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benno Schulenberg <bensberg <at> justemail.net>
To: bug-coreutils <at> gnu.org
Subject: [patch] dd's help text contains superfluous word
Date: Thu, 16 Aug 2012 18:45:18 +0200

[Message part 1 (text/plain, inline)]

Hi,

The help text of dd now mentions that the word BLOCKS can
be replaced with something.  But the word BLOCKS does not
occur any longer in the entire help text.  Attached patch
removes the superfluous mention.

The second patch converts the word BYTES to a single letter
(X), as was done for BLOCKS (now N) -- this to avoid the
awkward word combination of "BYTES bytes".

Regards,

Benno

-- 
http://www.fastmail.fm - One of many happy users:
  http://www.fastmail.fm/docs/quotes.html

[0001-dd-the-word-BLOCKS-no-longer-occurs-in-the-help-text.patch (text/x-patch, attachment)]

[0002-dd-change-BYTES-to-a-single-letter-as-was-done-for-B.patch (text/x-patch, attachment)]

Message #8 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12212 <at> debbugs.gnu.org
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Fri, 17 Aug 2012 08:30:00 +0200

Re: [PATCH 1/2] dd: the word BLOCKS no longer occurs in the help text

On 08/16/2012 06:45 PM, Benno Schulenberg wrote:
> 
> Hi,
> 
> The help text of dd now mentions that the word BLOCKS can
> be replaced with something.  But the word BLOCKS does not
> occur any longer in the entire help text.  Attached patch
> removes the superfluous mention.

argh, that renaming from BLOCKS to N was done in v8.15-38-g140eca1,
and I added the documentation for N again in v8.17-26-g4f2e9d5
without noticing that. Sorry for that.

BLOCKS is still mentioned in coreutils.texi.
Here's the fix:

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index 62b31fe..265d2e5 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -8402,7 +8402,7 @@ affected file descriptors, even after @command{dd} exits.
 @end table

 @cindex multipliers after numbers
-The numeric-valued strings above (@var{n}, @var{bytes} and @var{blocks})
+The numeric-valued strings above (@var{n} and @var{bytes})
 can be followed by a multiplier: @samp{b}=512, @samp{c}=1,
 @samp{w}=2, @samp{x <at> var{m}}=@var{m}, or any of the
 standard block size suffixes like @samp{k}=1024 (@pxref{Block size}).


Have a nice day,
Berny

Message #11 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Benno Schulenberg <bensberg <at> justemail.net>
Cc: 12212 <at> debbugs.gnu.org
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 14:24:23 +0200

On 08/17/2012 08:30 AM, Bernhard Voelker wrote:
> Re: [PATCH 1/2] dd: the word BLOCKS no longer occurs in the help text
> 
> On 08/16/2012 06:45 PM, Benno Schulenberg wrote:
>>
>> Hi,
>>
>> The help text of dd now mentions that the word BLOCKS can
>> be replaced with something.  But the word BLOCKS does not
>> occur any longer in the entire help text.  Attached patch
>> removes the superfluous mention.
> 
> argh, that renaming from BLOCKS to N was done in v8.15-38-g140eca1,
> and I added the documentation for N again in v8.17-26-g4f2e9d5
> without noticing that. Sorry for that.
> 
> BLOCKS is still mentioned in coreutils.texi.
> Here's the fix:
> 
> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
> index 62b31fe..265d2e5 100644
> --- a/doc/coreutils.texi
> +++ b/doc/coreutils.texi
> @@ -8402,7 +8402,7 @@ affected file descriptors, even after @command{dd} exits.
>  @end table
> 
>  @cindex multipliers after numbers
> -The numeric-valued strings above (@var{n}, @var{bytes} and @var{blocks})
> +The numeric-valued strings above (@var{n} and @var{bytes})
>  can be followed by a multiplier: @samp{b}=512, @samp{c}=1,
>  @samp{w}=2, @samp{x <at> var{m}}=@var{m}, or any of the
>  standard block size suffixes like @samp{k}=1024 (@pxref{Block size}).
> 
> 
> Have a nice day,
> Berny

Anyone catching up on Benno's patch with my addendum?
(I'm not sure about the second patch though.)

Have a nice day,
Berny

Message #14 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 12212 <at> debbugs.gnu.org, Benno Schulenberg <bensberg <at> justemail.net>
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 14:27:31 +0200

Bernhard Voelker wrote:
> On 08/17/2012 08:30 AM, Bernhard Voelker wrote:
>> Re: [PATCH 1/2] dd: the word BLOCKS no longer occurs in the help text
>>
>> On 08/16/2012 06:45 PM, Benno Schulenberg wrote:
>>>
>>> Hi,
>>>
>>> The help text of dd now mentions that the word BLOCKS can
>>> be replaced with something.  But the word BLOCKS does not
>>> occur any longer in the entire help text.  Attached patch
>>> removes the superfluous mention.
>>
>> argh, that renaming from BLOCKS to N was done in v8.15-38-g140eca1,
>> and I added the documentation for N again in v8.17-26-g4f2e9d5
>> without noticing that. Sorry for that.
>>
>> BLOCKS is still mentioned in coreutils.texi.
>> Here's the fix:
>>
>> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
>> index 62b31fe..265d2e5 100644
>> --- a/doc/coreutils.texi
>> +++ b/doc/coreutils.texi
>> @@ -8402,7 +8402,7 @@ affected file descriptors, even after @command{dd} exits.
>>  @end table
>>
>>  @cindex multipliers after numbers
>> -The numeric-valued strings above (@var{n}, @var{bytes} and @var{blocks})
>> +The numeric-valued strings above (@var{n} and @var{bytes})
>>  can be followed by a multiplier: @samp{b}=512, @samp{c}=1,
>>  @samp{w}=2, @samp{x <at> var{m}}=@var{m}, or any of the
>>  standard block size suffixes like @samp{k}=1024 (@pxref{Block size}).
>>
>>
>> Have a nice day,
>> Berny
>
> Anyone catching up on Benno's patch with my addendum?
> (I'm not sure about the second patch though.)

Hi Berny,
I was waiting for a complete patch ;-)

Message #17 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: 12212 <at> debbugs.gnu.org, Benno Schulenberg <bensberg <at> justemail.net>
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 14:54:26 +0200

On 09/18/2012 02:27 PM, Jim Meyering wrote:
> Bernhard Voelker wrote:
>> Anyone catching up on Benno's patch with my addendum?
>> (I'm not sure about the second patch though.)
> 
> Hi Berny,
> I was waiting for a complete patch ;-)

Hi Jim,

actually, me too ;-)
I've never written a patch in other contributors name yet.
Here's a try.

Have a nice day,
Berny


From d2e4c4a276c096b46598c71fe8b6f63eb89adbe5 Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg <at> justemail.net>
Date: Tue, 18 Sep 2012 14:50:47 +0200
Subject: [PATCH] dd: remove references to the word BLOCKS from help and texi
 docs

The renaming from BLOCKS to N was done in v8.15-38-g140eca1,
and a documentation for N was added again in v8.17-26-g4f2e9d5
without noticing that. Now, finally remove the word BLOCKS
from the documentation.

* src/dd.c (usage): Remove the word BLOCKS.
* doc/coreutils.texi (dd invocation): Likewise.

Improved by: Bernhard Voelker <mail <at> bernhard-voelker.de>
---
 doc/coreutils.texi |    2 +-
 src/dd.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index cb4ad83..437ae5d 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -8413,7 +8413,7 @@ affected file descriptors, even after @command{dd} exits.
 @end table

 @cindex multipliers after numbers
-The numeric-valued strings above (@var{n}, @var{bytes} and @var{blocks})
+The numeric-valued strings above (@var{n} and @var{blocks})
 can be followed by a multiplier: @samp{b}=512, @samp{c}=1,
 @samp{w}=2, @samp{x <at> var{m}}=@var{m}, or any of the
 standard block size suffixes like @samp{k}=1024 (@pxref{Block size}).
diff --git a/src/dd.c b/src/dd.c
index 2ebbfae..de51435 100644
--- a/src/dd.c
+++ b/src/dd.c
@@ -540,7 +540,7 @@ Copy a file, converting and formatting according to the operands.\n\
 "), stdout);
       fputs (_("\
 \n\
-N, BLOCKS and BYTES may be followed by the following multiplicative suffixes:\n\
+N and BYTES may be followed by the following multiplicative suffixes:\n\
 c =1, w =2, b =512, kB =1000, K =1024, MB =1000*1000, M =1024*1024, xM =M\n\
 GB =1000*1000*1000, G =1024*1024*1024, and so on for T, P, E, Z, Y.\n\
 \n\
-- 
1.7.7

Message #20 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: 12212 <at> debbugs.gnu.org, Benno Schulenberg <bensberg <at> justemail.net>
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 15:01:52 +0200

On 09/18/2012 02:54 PM, Bernhard Voelker wrote:
> Here's a try.

oops, sorry. I removed the wrong word in the texi file.

Here's a better one.

From 39ea828e94e8232660f83c62e1eff85026070b4c Mon Sep 17 00:00:00 2001
From: Benno Schulenberg <bensberg <at> justemail.net>
Date: Tue, 18 Sep 2012 14:58:42 +0200
Subject: [PATCH] dd: remove references to the word BLOCKS from help and texi
 docs

The renaming from BLOCKS to N was done in v8.15-38-g140eca1,
and a documentation for N was added again in v8.17-26-g4f2e9d5
without noticing that. Now, finally remove the word BLOCKS
from the documentation.

* src/dd.c (usage): Remove the word BLOCKS.
* doc/coreutils.texi (dd invocation): Likewise.

Improved by: Bernhard Voelker <mail <at> bernhard-voelker.de>
---
 doc/coreutils.texi |    2 +-
 src/dd.c           |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/doc/coreutils.texi b/doc/coreutils.texi
index cb4ad83..c0abd7f 100644
--- a/doc/coreutils.texi
+++ b/doc/coreutils.texi
@@ -8413,7 +8413,7 @@ affected file descriptors, even after @command{dd} exits.
 @end table

 @cindex multipliers after numbers
-The numeric-valued strings above (@var{n}, @var{bytes} and @var{blocks})
+The numeric-valued strings above (@var{n} and @var{bytes})
 can be followed by a multiplier: @samp{b}=512, @samp{c}=1,
 @samp{w}=2, @samp{x <at> var{m}}=@var{m}, or any of the
 standard block size suffixes like @samp{k}=1024 (@pxref{Block size}).
diff --git a/src/dd.c b/src/dd.c
index 2ebbfae..de51435 100644
--- a/src/dd.c
+++ b/src/dd.c
@@ -540,7 +540,7 @@ Copy a file, converting and formatting according to the operands.\n\
 "), stdout);
       fputs (_("\
 \n\
-N, BLOCKS and BYTES may be followed by the following multiplicative suffixes:\n\
+N and BYTES may be followed by the following multiplicative suffixes:\n\
 c =1, w =2, b =512, kB =1000, K =1024, MB =1000*1000, M =1024*1024, xM =M\n\
 GB =1000*1000*1000, G =1024*1024*1024, and so on for T, P, E, Z, Y.\n\
 \n\
-- 
1.7.7

Message #23 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 12212 <at> debbugs.gnu.org, Benno Schulenberg <bensberg <at> justemail.net>
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 15:20:31 +0200

Bernhard Voelker wrote:
> On 09/18/2012 02:54 PM, Bernhard Voelker wrote:
>> Here's a try.
>
> oops, sorry. I removed the wrong word in the texi file.
>
> Here's a better one.
>
>>From 39ea828e94e8232660f83c62e1eff85026070b4c Mon Sep 17 00:00:00 2001
> From: Benno Schulenberg <bensberg <at> justemail.net>
> Date: Tue, 18 Sep 2012 14:58:42 +0200
> Subject: [PATCH] dd: remove references to the word BLOCKS from help and texi
>  docs
>
> The renaming from BLOCKS to N was done in v8.15-38-g140eca1,
> and a documentation for N was added again in v8.17-26-g4f2e9d5

s/a //

> without noticing that. Now, finally remove the word BLOCKS

s/\./. /

> from the documentation.

Thank you!  Applied with the above log tweaks.
Will push shortly.

Message #26 received at 12212 <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: 12212 <at> debbugs.gnu.org, Benno Schulenberg <bensberg <at> justemail.net>
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Tue, 18 Sep 2012 16:08:39 +0200

On 09/18/2012 03:20 PM, Jim Meyering wrote:
> Applied with the above log tweaks.
> Will push shortly.

Thanks!

Message #31 received at 12212-done <at> debbugs.gnu.org (full text, mbox):

From: Bernhard Voelker <mail <at> bernhard-voelker.de>
To: Jim Meyering <jim <at> meyering.net>
Cc: Benno Schulenberg <bensberg <at> justemail.net>, 12212-done <at> debbugs.gnu.org
Subject: Re: bug#12212: [patch] dd's help text contains superfluous word
Date: Mon, 19 Nov 2012 23:09:29 +0100

On 09/18/2012 04:08 PM, Bernhard Voelker wrote:
> On 09/18/2012 03:20 PM, Jim Meyering wrote:
>> Applied with the above log tweaks.
>> Will push shortly.
> 
> Thanks!

That was commit v8.19-136-g6274128 back on Sep 18th. 2012.
Marked as done.

Have a nice day,
Berny

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.