GNU bug report logs - #12639
24.1; woman.el points vs pica scaling

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 12639 in the body.
You can then email your comments to 12639 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Ryde <user42 <at> zip.com.au>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1; woman.el points vs pica scaling
Date: Sun, 14 Oct 2012 11:11:03 +1100

[Message part 1 (text/plain, inline)]

The file picapoints.1 viewed with

    M-x woman-find-file picapoints.1

gives

    12 point spacing                      xxx
    12 picas spacing                      xxx

where I expected that "12p" points would be much less than "12P" picas,
something like maybe

     12 point spacing    xxx
     12 picas spacing                      xxx

It looks like case-fold-search is true in woman-parse-numeric-value
causing "p" points and "P" picas not to be distinguished.

I can't tell if that's meant to be so.  There seems to be duelling
`let's of case significance.  Ensuring it where it matters per diff
below might be a good idea.

2012-10-14  Kevin Ryde  <user42 <at> zip.com.au>

	* woman.el (woman-parse-numeric-value): case-fold-search nil to ensure
	"p" points and "P" picas scaling are distinguished as intended.


I struck this on output from recent perl pod2man where there's some
spacing to make "C++" look good, per cplusplus.1 below.  It's meant for
troff, but when woman wrongly takes it as 1 pica instead of 1 point the
movement forward and back doesn't add up and a space after the construct
is lost, so giving

    Blah C^++blah.

With case-significance fixed it becomes the intended

    Blah C^++ blah.

[picapoints.1 (text/plain, attachment)]

[woman.el.picas.diff (text/x-diff, attachment)]

[cplusplus.1 (text/plain, attachment)]

[Message part 5 (text/plain, inline)]

In GNU Emacs 24.1.1 (i486-pc-linux-gnu, GTK+ Version 2.24.8)
 of 2012-08-07 on blah.blah, modified by Debian
Configured using:
 `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu'
 '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib'
 '--localstatedir=/var/lib' '--infodir=/usr/share/info'
 '--mandir=/usr/share/man' '--with-pop=yes'
 '--enable-locallisppath=/etc/emacs24:/etc/emacs:/usr/local/share/emacs/24.1/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/24.1/site-lisp:/usr/share/emacs/site-lisp'
 '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes'
 '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars'
 'build_alias=i486-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector
 --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall'
 'CPPFLAGS=-D_FORTIFY_SOURCE=2''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_AU
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

Message #10 received at 12639-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Kevin Ryde <user42 <at> zip.com.au>
Cc: 12639-done <at> debbugs.gnu.org
Subject: Re: bug#12639: 24.1; woman.el points vs pica scaling
Date: Mon, 29 Oct 2012 18:31:27 +0800

Kevin Ryde <user42 <at> zip.com.au> writes:

> I can't tell if that's meant to be so.  There seems to be duelling
> `let's of case significance.  Ensuring it where it matters per diff
> below might be a good idea.
>
> 2012-10-14  Kevin Ryde  <user42 <at> zip.com.au>
>
> * woman.el (woman-parse-numeric-value): case-fold-search nil to ensure
> "p" points and "P" picas scaling are distinguished as intended.

Thanks.  I committed a more conservative version of the patch, binding
case-fold-search to nil only around (looking-at "P").

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.