GNU bug report logs -
#13139
24.3.50; vc-git: Suppress load message
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13139 in the body.
You can then email your comments to 13139 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 14:33:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Christopher Schmidt <christopher <at> ch.ristopher.com>:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org.
(Tue, 11 Dec 2012 14:33:03 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[vc-git-suppress-load-msg.diff (text/x-diff, inline)]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-12-11 07:49:06 +0000
+++ lisp/ChangeLog 2012-12-11 14:28:26 +0000
@@ -1,3 +1,8 @@
+2012-12-11 Christopher Schmidt <christopher <at> ch.ristopher.com>
+
+ * vc/vc-git.el (vc-git-registered): Suppress load message of
+ vc-git.
+
2012-12-11 Eli Zaretskii <eliz <at> gnu.org>
* makefile.w32-in (compile4-SH): Fix a typo that caused term
=== modified file 'lisp/vc/vc-git.el'
--- lisp/vc/vc-git.el 2012-11-30 07:43:05 +0000
+++ lisp/vc/vc-git.el 2012-12-11 14:16:15 +0000
@@ -168,7 +168,7 @@
;;;###autoload "Return non-nil if FILE is registered with git."
;;;###autoload (if (vc-find-root file ".git") ; Short cut.
;;;###autoload (progn
-;;;###autoload (load "vc-git")
+;;;###autoload (load "vc-git" nil t)
;;;###autoload (vc-git-registered file))))
(defun vc-git-registered (file)
[Message part 2 (text/plain, inline)]
Christopher
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 14:47:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
Christopher Schmidt <christopher <at> ch.ristopher.com> writes:
> + * vc/vc-git.el (vc-git-registered): Suppress load message of
> + vc-git.
Why only vc-git?
Andreas.
--
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 14:57:02 GMT)
Full text and
rfc822 format available.
Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Andreas Schwab <schwab <at> linux-m68k.org> writes:
> Christopher Schmidt <christopher <at> ch.ristopher.com> writes:
>
>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>> + vc-git.
>
> Why only vc-git?
:D
[vc-suppress-load-msg.diff (text/x-diff, inline)]
=== modified file 'lisp/ChangeLog'
--- lisp/ChangeLog 2012-12-11 07:49:06 +0000
+++ lisp/ChangeLog 2012-12-11 14:51:07 +0000
@@ -1,3 +1,13 @@
+2012-12-11 Christopher Schmidt <christopher <at> ch.ristopher.com>
+
+ * vc/vc-arch.el (vc-arch-registered):
+ * vc/vc-bzr.el (vc-bzr-registered):
+ * vc/vc-cvs.el (vc-cvs-registered):
+ * vc/vc-git.el (vc-git-registered):
+ * vc/vc-hg.el (vc-hg-registered):
+ * vc/vc-mtn.el (vc-mtn-registered):
+ * vc/vc-svn.el (vc-svn-registered): Suppress load messages.
+
2012-12-11 Eli Zaretskii <eliz <at> gnu.org>
* makefile.w32-in (compile4-SH): Fix a typo that caused term
=== modified file 'lisp/vc/vc-arch.el'
--- lisp/vc/vc-arch.el 2012-07-11 23:13:41 +0000
+++ lisp/vc/vc-arch.el 2012-12-11 14:48:36 +0000
@@ -101,7 +101,7 @@
;;;###autoload (defun vc-arch-registered (file)
;;;###autoload (if (vc-find-root file "{arch}/=tagging-method")
;;;###autoload (progn
-;;;###autoload (load "vc-arch")
+;;;###autoload (load "vc-arch" nil t)
;;;###autoload (vc-arch-registered file))))
(defun vc-arch-add-tagline ()
=== modified file 'lisp/vc/vc-bzr.el'
--- lisp/vc/vc-bzr.el 2012-09-29 23:13:29 +0000
+++ lisp/vc/vc-bzr.el 2012-12-11 14:48:43 +0000
@@ -291,7 +291,7 @@
;;;###autoload (defun vc-bzr-registered (file)
;;;###autoload (if (vc-find-root file vc-bzr-admin-checkout-format-file)
;;;###autoload (progn
-;;;###autoload (load "vc-bzr")
+;;;###autoload (load "vc-bzr" nil t)
;;;###autoload (vc-bzr-registered file))))
(defun vc-bzr-registered (file)
=== modified file 'lisp/vc/vc-cvs.el'
--- lisp/vc/vc-cvs.el 2012-08-29 15:11:51 +0000
+++ lisp/vc/vc-cvs.el 2012-12-11 14:48:40 +0000
@@ -198,7 +198,7 @@
;;;###autoload "Return non-nil if file F is registered with CVS."
;;;###autoload (when (file-readable-p (expand-file-name
;;;###autoload "CVS/Entries" (file-name-directory f)))
-;;;###autoload (load "vc-cvs")
+;;;###autoload (load "vc-cvs" nil t)
;;;###autoload (vc-cvs-registered f)))
(defun vc-cvs-registered (file)
=== modified file 'lisp/vc/vc-git.el'
--- lisp/vc/vc-git.el 2012-11-30 07:43:05 +0000
+++ lisp/vc/vc-git.el 2012-12-11 14:16:15 +0000
@@ -168,7 +168,7 @@
;;;###autoload "Return non-nil if FILE is registered with git."
;;;###autoload (if (vc-find-root file ".git") ; Short cut.
;;;###autoload (progn
-;;;###autoload (load "vc-git")
+;;;###autoload (load "vc-git" nil t)
;;;###autoload (vc-git-registered file))))
(defun vc-git-registered (file)
=== modified file 'lisp/vc/vc-hg.el'
--- lisp/vc/vc-hg.el 2012-12-05 01:49:31 +0000
+++ lisp/vc/vc-hg.el 2012-12-11 14:48:34 +0000
@@ -176,7 +176,7 @@
;;;###autoload "Return non-nil if FILE is registered with hg."
;;;###autoload (if (vc-find-root file ".hg") ; short cut
;;;###autoload (progn
-;;;###autoload (load "vc-hg")
+;;;###autoload (load "vc-hg" nil t)
;;;###autoload (vc-hg-registered file))))
;; Modeled after the similar function in vc-bzr.el
=== modified file 'lisp/vc/vc-mtn.el'
--- lisp/vc/vc-mtn.el 2012-08-15 19:20:26 +0000
+++ lisp/vc/vc-mtn.el 2012-12-11 14:48:30 +0000
@@ -72,7 +72,7 @@
;;;###autoload (defun vc-mtn-registered (file)
;;;###autoload (if (vc-find-root file vc-mtn-admin-format)
;;;###autoload (progn
-;;;###autoload (load "vc-mtn")
+;;;###autoload (load "vc-mtn" nil t)
;;;###autoload (vc-mtn-registered file))))
(defun vc-mtn-revision-granularity () 'repository)
=== modified file 'lisp/vc/vc-svn.el'
--- lisp/vc/vc-svn.el 2012-11-18 01:52:36 +0000
+++ lisp/vc/vc-svn.el 2012-12-11 14:48:24 +0000
@@ -123,7 +123,7 @@
;;;###autoload "_svn")
;;;###autoload (t ".svn"))))
;;;###autoload (when (vc-find-root f admin-dir)
-;;;###autoload (load "vc-svn")
+;;;###autoload (load "vc-svn" nil t)
;;;###autoload (vc-svn-registered f))))
(defun vc-svn-registered (file)
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 17:07:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 13139 <at> debbugs.gnu.org (full text, mbox):
Andreas Schwab wrote:
> Christopher Schmidt <christopher <at> ch.ristopher.com> writes:
>
>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>> + vc-git.
>
> Why only vc-git?
The more obvious question is: why do this at all?
I can only assume "because I found it slightly irritating", which
doesn't seem like a good reason to me. I'd say that the loading message
is a slightly useful diagnostic, eg in case something goes unexpectedly
wrong. It's a once-per-session message, so surely it's easy to ignore if
it bothers you.
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 17:48:02 GMT)
Full text and
rfc822 format available.
Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):
Glenn Morris <rgm <at> gnu.org> writes:
> Andreas Schwab wrote:
>
>> Christopher Schmidt <christopher <at> ch.ristopher.com> writes:
>>
>>> + * vc/vc-git.el (vc-git-registered): Suppress load message of
>>> + vc-git.
>>
>> Why only vc-git?
>
> The more obvious question is: why do this at all? I can only assume
> "because I found it slightly irritating", which doesn't seem like a
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
That's it. The message does not provide any value to me and it might
override previous messages which are actually important.
> good reason to me. I'd say that the loading message is a slightly
> useful diagnostic, eg in case something goes unexpectedly wrong. It's
> a once-per-session message, so surely it's easy to ignore if it
> bothers you.
How is this message useful in case something goes wrong?
Christopher
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Tue, 11 Dec 2012 19:05:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 13139 <at> debbugs.gnu.org (full text, mbox):
> The more obvious question is: why do this at all?
I guess for consistency with all other loading messages, since we
"recently" made autoloads slient; and also since vc-hooks.el can also
trigger loading of vc-BACKEND.el but if it does, it does it via
`require' rather than `load', so it's also silent in that case.
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Sun, 13 Jan 2013 09:01:01 GMT)
Full text and
rfc822 format available.
Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> The more obvious question is: why do this at all?
>
> I guess for consistency with all other loading messages, since we
> "recently" made autoloads slient; and also since vc-hooks.el can also
> trigger loading of vc-BACKEND.el but if it does, it does it via
> `require' rather than `load', so it's also silent in that case.
Ping?
It would be great if someone applied my patch (attached to
<87boe08wpx <at> ch.ristopher.com>) or got me green light so I can apply it
myself.
Christopher
Information forwarded
to
bug-gnu-emacs <at> gnu.org:
bug#13139; Package
emacs.
(Sun, 13 Jan 2013 14:24:03 GMT)
Full text and
rfc822 format available.
Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):
>>> The more obvious question is: why do this at all?
>> I guess for consistency with all other loading messages, since we
>> "recently" made autoloads slient; and also since vc-hooks.el can also
>> trigger loading of vc-BACKEND.el but if it does, it does it via
>> `require' rather than `load', so it's also silent in that case.
> Ping?
> It would be great if someone applied my patch (attached to
> <87boe08wpx <at> ch.ristopher.com>) or got me green light so I can apply it
> myself.
Go ahead for this one (the other ones should come soon),
Stefan
Reply sent
to
Christopher Schmidt <christopher <at> ch.ristopher.com>:
You have taken responsibility.
(Fri, 01 Feb 2013 17:36:01 GMT)
Full text and
rfc822 format available.
Notification sent
to
Christopher Schmidt <christopher <at> ch.ristopher.com>:
bug acknowledged by developer.
(Fri, 01 Feb 2013 17:36:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 13139-done <at> debbugs.gnu.org (full text, mbox):
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
>> It would be great if someone applied my patch (attached to
>> <87boe08wpx <at> ch.ristopher.com>) or got me green light so I can apply
>> it myself.
>
> Go ahead for this one (the other ones should come soon),
Thank you. Installed in trunk.
Christopher
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org.
(Sat, 02 Mar 2013 12:24:03 GMT)
Full text and
rfc822 format available.
This bug report was last modified 11 years and 63 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.