GNU bug report logs - #13224
24.3.50; [PATCH] Variable `icomplete-prospects-height' is no longer honored

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13224 in the body.
You can then email your comments to 13224 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Wesley Dawson <whd <at> lavabit.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
	[PATCH] Variable `icomplete-prospects-height' is no longer honored
Date: Tue, 18 Dec 2012 21:41:13 -0800

[Message part 1 (text/plain, inline)]

M-x icomplete-mode
M-x set-variable icomplete-prospects-height 1
M-x a
(the candidates list takes up two lines in the minibuffer)

Here's a patch to make icomplete honor `icomplete-prospects-height'
again, which it hasn't since the introduction of `icomplete-separator'
(revno: 111031).

About formatting: the source appears to mix tabs and spaces for
indentation quite freely; I didn't attempt to fix this and went with
what emacs -Q did for formatting.

  * lisp/icomplete.el (icomplete-completions): Fix to honor
    `icomplete-prospects-height' again.

[patch.diff (text/x-patch, inline)]

=== modified file 'lisp/icomplete.el'
--- lisp/icomplete.el	2012-12-17 19:43:55 +0000
+++ lisp/icomplete.el	2012-12-19 04:25:35 +0000
@@ -343,8 +343,10 @@
 				(t (concat "…" (substring most compare))))
 			       close-bracket)))
 	     ;;"-prospects" - more than one candidate
-	     (prospects-len (+ (length determ) 6 ;; take {,...} into account
-                               (string-width (buffer-string))))
+	     (prospects-len (+ (length determ)
+			       (string-width icomplete-separator)
+			       3 ;; take {…} into account
+			       (string-width (buffer-string))))
              (prospects-max
               ;; Max total length to use, including the minibuffer content.
               (* (+ icomplete-prospects-height
@@ -375,7 +377,9 @@
 	    (cond ((string-equal comp "") (setq most-is-exact t))
 		  ((member comp prospects))
 		  (t (setq prospects-len
-                           (+ (string-width comp) 1 prospects-len))
+                           (+ (string-width comp)
+			      (string-width icomplete-separator)
+			      prospects-len))
 		     (if (< prospects-len prospects-max)
 			 (push comp prospects)
 		       (setq limit t))))))

Message #10 received at 13224-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 13224-done <at> debbugs.gnu.org
Subject: Re: bug#13224: 24.3.50;
	[PATCH] Variable `icomplete-prospects-height' is no longer honored
Date: Fri, 04 Jan 2013 03:21:26 -0500

Thanks; applied.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.