GNU bug report logs - #13293
24.2.91; eshell completion cycles fail in pre-test

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13293 in the body.
You can then email your comments to 13293 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles Rendleman <carendle <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2.91; eshell completion cycles fail in pre-test
Date: Fri, 28 Dec 2012 11:19:51 -0500

[Message part 1 (text/plain, inline)]

A prescription for exhibiting the bug

$ mkdir -p t/test-1 t/test-2 t/test-3
$ emacs -Q -nw
M-x eshell
type cd t/<TAB>
expands to 'cd t/test-3'
pressing repeated <TAB>s does not cycle t/test-1, t/test-2, t/test-3

Expected behavior (consistent with emacs 24.2): that the first <TAB> expand
to one of t/test-3, and repeated <TAB>s cycle amongst 't/test-1',
't/test-2', and 't/test-3'.

[Message part 2 (text/html, inline)]

Message #8 received at 13293 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Charles Rendleman <carendle <at> gmail.com>
Cc: 13293 <at> debbugs.gnu.org
Subject: Re: bug#13293: 24.2.91; eshell completion cycles fail in pre-test
Date: Sun, 30 Dec 2012 13:57:08 -0500

Charles Rendleman wrote:

> A prescription for exhibiting the bug
>
> $ mkdir -p t/test-1 t/test-2 t/test-3
> $ emacs -Q -nw
> M-x eshell
> type cd t/<TAB>
> expands to 'cd t/test-3'
> pressing repeated <TAB>s does not cycle t/test-1, t/test-2, t/test-3

Looks like we need to add eshell-pcomplete to the list in the function
pcomplete:

(memq last-command '(pcomplete
                     pcomplete-expand-and-complete
                     pcomplete-reverse))

Message #11 received at 13293 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Charles Rendleman <carendle <at> gmail.com>
Cc: 13293 <at> debbugs.gnu.org
Subject: Re: bug#13293: 24.2.91; eshell completion cycles fail in pre-test
Date: Sun, 30 Dec 2012 14:04:14 -0500

Glenn Morris wrote:

> Looks like we need to add eshell-pcomplete to the list in the function
> pcomplete:
>
> (memq last-command '(pcomplete
>                      pcomplete-expand-and-complete
>                      pcomplete-reverse))

Or maybe this:

*** lisp/eshell/em-cmpl.el	2012-11-19 19:22:07 +0000
--- lisp/eshell/em-cmpl.el	2012-12-30 19:02:48 +0000
***************
*** 454,461 ****
  (defun eshell-pcomplete ()
    "Eshell wrapper for `pcomplete'."
    (interactive)
    (condition-case nil
!       (pcomplete)
      (text-read-only (completion-at-point)))) ; Workaround for bug#12838.
  
  (provide 'em-cmpl)
--- 454,462 ----
  (defun eshell-pcomplete ()
    "Eshell wrapper for `pcomplete'."
    (interactive)
+   (setq this-command 'pcomplete)
    (condition-case nil
!       (call-interactively 'pcomplete)
      (text-read-only (completion-at-point)))) ; Workaround for bug#12838.
  
  (provide 'em-cmpl)

Message #16 received at 13293-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 13293-done <at> debbugs.gnu.org
Subject: Re: bug#13293: 24.2.91; eshell completion cycles fail in pre-test
Date: Mon, 31 Dec 2012 16:28:55 -0500

Version: 24.2.92

Fixed in emacs-24 branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.