GNU bug report logs - #13465
24.3.50; mml attached gpg signature filename convention

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13465 in the body.
You can then email your comments to 13465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Milan Santosi <milan.santosi <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; mml attached gpg signature filename convention
Date: Wed, 16 Jan 2013 20:27:16 +0100

Minor bug / cosmetics.

I've been exchanging signed emails using Emacs recently and noticed that
unlike others (non-emacsers), the filename of my attached signature is
always "noname" instead of "signature.asc".

Help from #emacs on freenode leads me to line 719 in rmailmm.el where I
find the "noname" hardcoded. Shouldn't this read "signature.asc"
instead (which seems conventional)?

kind regards,

Milan Santosi

Message #8 received at 13465 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Milan Santosi <milan.santosi <at> gmail.com>
Cc: 13465 <at> debbugs.gnu.org
Subject: Re: bug#13465: 24.3.50; mml attached gpg signature filename convention
Date: Wed, 16 Jan 2013 17:35:15 -0500

Milan Santosi wrote:

> I've been exchanging signed emails using Emacs recently and noticed that
> unlike others (non-emacsers), the filename of my attached signature is
> always "noname" instead of "signature.asc".
>
> Help from #emacs on freenode leads me to line 719 in rmailmm.el where I
> find the "noname" hardcoded. Shouldn't this read "signature.asc"
> instead (which seems conventional)?

Are you asking for mml-secure-sign to use:

  Content-Type: application/pgp-signature; name="signature.asc"

rather than the current:

   Content-Type: application/pgp-signature

in what it sends out; or for Rmail to default to a filename of
"signature.asc" rather than "noname" for an application/pgp-signature
entity that does not specify a filename?


*** lisp/gnus/mml2015.el	2013-01-02 16:13:04 +0000
--- lisp/gnus/mml2015.el	2013-01-16 22:32:25 +0000
***************
*** 1069,1075 ****
      (insert (format "\n--%s\n" boundary))
      (goto-char (point-max))
      (insert (format "\n--%s\n" boundary))
!     (insert "Content-Type: application/pgp-signature\n\n")
      (insert signature)
      (goto-char (point-max))
      (insert (format "--%s--\n" boundary))
--- 1069,1075 ----
      (insert (format "\n--%s\n" boundary))
      (goto-char (point-max))
      (insert (format "\n--%s\n" boundary))
!     (insert "Content-Type: application/pgp-signature; name=\"signature.asc\"\n\n")
      (insert signature)
      (goto-char (point-max))
      (insert (format "--%s--\n" boundary))

Message #11 received at 13465 <at> debbugs.gnu.org (full text, mbox):

From: Milan Santosi <milan.santosi <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Milan Santosi <milan.santosi <at> gmail.com>, 13465 <at> debbugs.gnu.org
Subject: Re: bug#13465: 24.3.50; mml attached gpg signature filename convention
Date: Thu, 17 Jan 2013 07:14:53 +0100

Thanks a lot for the patch!

> default to a filename of "signature.asc" rather than "noname" for an
> application/pgp-signature entity that does not specify a filename?
Yes, this is what I meant.

I found it a little bit odd for the hardcoded default to be "noname",
maybe it makes sense to change it to "signature.asc".

regards,

Milan

Message #14 received at 13465 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Milan Santosi <milan.santosi <at> gmail.com>
Cc: 13465 <at> debbugs.gnu.org
Subject: Re: bug#13465: 24.3.50; mml attached gpg signature filename convention
Date: Thu, 17 Jan 2013 01:39:19 -0500

Milan Santosi wrote:

> Thanks a lot for the patch!
>
>> default to a filename of "signature.asc" rather than "noname" for an
>> application/pgp-signature entity that does not specify a filename?
> Yes, this is what I meant.
>
> I found it a little bit odd for the hardcoded default to be "noname",
> maybe it makes sense to change it to "signature.asc".

It is not at all odd because this is generic code for handling
attachments, not something specific for each possible attachment type.

Message #19 received at 13465-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 13465-done <at> debbugs.gnu.org
Subject: Re: bug#13465: 24.3.50; mml attached gpg signature filename convention
Date: Mon, 06 May 2013 03:17:37 -0400

Version: 24.4

Glenn Morris wrote:

> mml-secure-sign to use:
>
>   Content-Type: application/pgp-signature; name="signature.asc"

Done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.