GNU bug report logs - #13510
24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13510 in the body.
You can then email your comments to 13510 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; `report-emacs-bug' binds `C-c m', which is reserved for users
Date: Sun, 20 Jan 2013 14:56:22 -0800

This code in `report-emacs-bug' violates the convention set forth in
(elisp) `Key Binding Conventions', which reserves `C-c' plus a
letter for users:
 
(define-key (current-local-map) "\C-cm"
     'report-emacs-bug-insert-to-mailer)
 
Hard to believe this happened.  New key bindings, especially in longstanding,
core Emacs modes, should be reviewed before a
release.  The bug was introduced in Emacs 24.1.

The doc is unequivocal about this:
 
  Don't define `C-c LETTER' as a key in Lisp programs.  Sequences
  consisting of `C-c' and a letter (either upper or lower case) are
  reserved for users; they are the *only* sequences reserved for
  users, so do not block them.
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-01-18 on ODIEONE
Bzr revision: 111548 sdl.web <at> gmail.com-20130118182218-6ywd47qsbnow6nsg
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'

Message #10 received at 13510-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 13510-done <at> debbugs.gnu.org
Subject: Re: bug#13510: 24.3.50;
	`report-emacs-bug' binds `C-c m', which is reserved for users
Date: Sat, 09 Feb 2013 12:41:40 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> This code in `report-emacs-bug' violates the convention set forth in
> (elisp) `Key Binding Conventions', which reserves `C-c' plus a
> letter for users:
>  
> (define-key (current-local-map) "\C-cm"
>      'report-emacs-bug-insert-to-mailer)

This is indeed a mistake.  Since this bug was introduced in Emacs 24.1,
it is a regression against Emacs 23; I went ahead and fixed it in the
emacs-24 branch, with the new binding C-c M-i.

Message #13 received at 13510-done <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: "'Chong Yidong'" <cyd <at> gnu.org>
Cc: 13510-done <at> debbugs.gnu.org
Subject: RE: bug#13510: 24.3.50;
	`report-emacs-bug' binds `C-c m', which is reserved for users
Date: Sat, 9 Feb 2013 08:16:50 -0800

> > This code in `report-emacs-bug' violates the convention set forth in
> > (elisp) `Key Binding Conventions', which reserves `C-c' plus a
> > letter for users:
> >  
> > (define-key (current-local-map) "\C-cm"
> >      'report-emacs-bug-insert-to-mailer)
> 
> This is indeed a mistake.  Since this bug was introduced in 
> Emacs 24.1, it is a regression against Emacs 23; I went ahead
> and fixed it in the emacs-24 branch, with the new binding C-c M-i.

Thank you.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.