GNU bug report logs - #13723
24.2.93; Fringe icons corrupt buffer separator line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13723 in the body.
You can then email your comments to 13723 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 18:45:20 +0100

Maybe a small thing, but nonetheless irritating: I noticed that when
scrolling buffers on a split frame with disabled scrollbars, the small
line separating two buffers can get corrupted by icons in the fringe. It
seems that this line doesn't get redrawn correctly, or maybe not at all.

You should be able to reproduce this issue with the following recipe:

* emacs -Q

* In the *scratch* buffer, insert

(progn
  (scroll-bar-mode -1)
  (setq truncate-partial-width-windows nil)
  (toggle-truncate-lines -1)
  (with-current-buffer (get-buffer-create "test")
    (erase-buffer)
    (dotimes (i 100)
      (insert (make-string 500 65) "\n")))
  (pop-to-buffer-same-window "test")
  (goto-char (point-max))
  (split-window-right)
  (other-window 1)
  (split-window-right)
  (pop-to-buffer-same-window "test")
  (goto-char (point-min))
  (while (not (eobp))
    (scroll-up-command)
    (redisplay t)))

and evaluate.

* The separator line between the first and the second buffer should now
  have gaps. Here's a screenshot:

  http://www.randomsample.de/emacs-bug.jpg

As soon as the Emacs window gets redrawn, everything's back to
normal.

-David

Message #8 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: David Engster <deng <at> randomsample.de>
Cc: 13723 <at> debbugs.gnu.org
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 21:23:25 +0200

> From: David Engster <deng <at> randomsample.de>
> Date: Fri, 15 Feb 2013 18:45:20 +0100
> 
> Maybe a small thing, but nonetheless irritating: I noticed that when
> scrolling buffers on a split frame with disabled scrollbars, the small
> line separating two buffers can get corrupted by icons in the fringe. It
> seems that this line doesn't get redrawn correctly, or maybe not at all.

It does get redrawn, see x_draw_vertical_border.

> You should be able to reproduce this issue with the following recipe:
> 
> * emacs -Q
> 
> * In the *scratch* buffer, insert
> 
> (progn
>   (scroll-bar-mode -1)
>   (setq truncate-partial-width-windows nil)
>   (toggle-truncate-lines -1)
>   (with-current-buffer (get-buffer-create "test")
>     (erase-buffer)
>     (dotimes (i 100)
>       (insert (make-string 500 65) "\n")))
>   (pop-to-buffer-same-window "test")
>   (goto-char (point-max))
>   (split-window-right)
>   (other-window 1)
>   (split-window-right)
>   (pop-to-buffer-same-window "test")
>   (goto-char (point-min))
>   (while (not (eobp))
>     (scroll-up-command)
>     (redisplay t)))
> 
> and evaluate.
> 
> * The separator line between the first and the second buffer should now
>   have gaps. Here's a screenshot:
> 
>   http://www.randomsample.de/emacs-bug.jpg

Unfortunately, I cannot reproduce this here, neither with stock Emacs
24.2 nor with the current trunk.  I get a perfectly drawn border.

Message #11 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, David Engster <deng <at> randomsample.de>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 14:30:57 -0500

Eli Zaretskii wrote:

> Unfortunately, I cannot reproduce this here, neither with stock Emacs
> 24.2 nor with the current trunk.  I get a perfectly drawn border.

I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.

Message #14 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 20:39:20 +0100

Glenn Morris writes:
> Eli Zaretskii wrote:
>
>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> 24.2 nor with the current trunk.  I get a perfectly drawn border.
>
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.

Thank you both for testing. I forgot to add that I've also seen this
under GNU/Linux with the Lucid toolkit, but on two different boxes
(running Ubuntu 12.04 and Arch Linux, resp.). Eli, you've probably
tested this under Windows?

-David

Message #17 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 21:56:11 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: David Engster <deng <at> randomsample.de>,  13723 <at> debbugs.gnu.org
> Date: Fri, 15 Feb 2013 14:30:57 -0500
> 
> Eli Zaretskii wrote:
> 
> > Unfortunately, I cannot reproduce this here, neither with stock Emacs
> > 24.2 nor with the current trunk.  I get a perfectly drawn border.
> 
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.

Do you see it in previous versions, like 24.2 and 23.3?  That will
tell us how urgent it is to fix this.

If this is a regression that needs to be fixed ASAP, can you trace
through the code which draws the border and see what goes wrong there?
The immediate suspects are those parts that reference the
redraw_fringe_bitmaps_p flag, and the x_draw_vertical_window_border
function.

Another possible way to see whodunit is to step through update_window
and update_window_line, and see which code removes the portions of the
vertical line.

Or maybe the problem is in the order in which fringe bitmaps and the
vertical border are drawn.

Message #20 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: David Engster <deng <at> randomsample.de>
Cc: rgm <at> gnu.org, 13723 <at> debbugs.gnu.org
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 21:57:25 +0200

> From: David Engster <deng <at> randomsample.de>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  13723 <at> debbugs.gnu.org
> Date: Fri, 15 Feb 2013 20:39:20 +0100
> 
> Eli, you've probably tested this under Windows?

Yes, but it shouldn't matter.  This level of redisplay is
device-independent, at least most of it.

Message #23 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 15:12:03 -0500

Eli Zaretskii wrote:

> Do you see it in previous versions, like 24.2 and 23.3?  That will
> tell us how urgent it is to fix this.

Since at least 24.1 (recipe does not work as written in 23.x).
I don't think is at all urgent to fix.
I also see it in GTK-2 builds, but it is not as obvious because for some
reason the middle window ends up scrolled to a different position, with
less space after the end of the "A"s.

Message #26 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 21:20:19 +0100

Glenn Morris writes:
> Eli Zaretskii wrote:
>
>> Do you see it in previous versions, like 24.2 and 23.3?  That will
>> tell us how urgent it is to fix this.
>
> Since at least 24.1 (recipe does not work as written in 23.x).
> I don't think is at all urgent to fix.

I agree; this is a purely cosmetic issue and just a bit irritating
(also, it only affects those with disabled scrollbars, which I guess
isn't very common).

-David

Message #29 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 15:21:48 -0500

Glenn Morris wrote:

> Since at least 24.1 (recipe does not work as written in 23.x).

Since at least 23.2 GTK with

(progn
  (scroll-bar-mode -1)
  (setq truncate-partial-width-windows nil)
  (toggle-truncate-lines -1)
  (with-current-buffer (get-buffer-create "test")
    (erase-buffer)
    (dotimes (i 100)
      (insert (make-string 500 65) "\n")))
  (switch-to-buffer "test")
  (goto-char (point-max))
  (split-window nil nil t)
  (other-window 1)
  (split-window nil nil t)
  (switch-to-buffer "test")
  (goto-char (point-min))
  (while (not (eobp))
    (scroll-up)
    (redisplay t)))

Message #32 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Fri, 15 Feb 2013 15:38:52 -0500

Seen in 23.2 onwards, but not in 23.1 and earlier, if that tells you
anything.

Message #35 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
	David Engster <deng <at> randomsample.de>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sat, 16 Feb 2013 18:15:36 +0100

Hello.

15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm <at> gnu.org>:

> Eli Zaretskii wrote:
> 
>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> 24.2 nor with the current trunk.  I get a perfectly drawn border.
> 
> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
> 

I see the issue on trunk, built for NS.

	Jan D.

Message #38 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: rgm <at> gnu.org, deng <at> randomsample.de, 13723 <at> debbugs.gnu.org
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sat, 16 Feb 2013 21:14:04 +0200

> From: Jan Djärv <jan.h.d <at> swipnet.se>
> Date: Sat, 16 Feb 2013 18:15:36 +0100
> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>  13723 <at> debbugs.gnu.org,
>  David Engster <deng <at> randomsample.de>
> 
> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm <at> gnu.org>:
> 
> > Eli Zaretskii wrote:
> > 
> >> Unfortunately, I cannot reproduce this here, neither with stock Emacs
> >> 24.2 nor with the current trunk.  I get a perfectly drawn border.
> > 
> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
> > 
> 
> I see the issue on trunk, built for NS.

Does the change below solve the problem on GNU/Linux and NS?

=== modified file 'src/xdisp.c'
--- src/xdisp.c	2013-02-15 12:26:42 +0000
+++ src/xdisp.c	2013-02-16 19:11:29 +0000
@@ -28257,8 +28257,8 @@ x_draw_vertical_border (struct window *w
 
       FRAME_RIF (f)->draw_vertical_window_border (w, x1, y0, y1);
     }
-  else if (!WINDOW_LEFTMOST_P (w)
-	   && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
+  if (!WINDOW_LEFTMOST_P (w)
+      && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
     {
       int x0, x1, y0, y1;
 

Message #41 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: David Engster <deng <at> randomsample.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, Jan Djärv <jan.h.d <at> swipnet.se>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sat, 16 Feb 2013 21:47:17 +0100

Eli Zaretskii writes:
>> From: Jan Djärv <jan.h.d <at> swipnet.se>
>> Date: Sat, 16 Feb 2013 18:15:36 +0100
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>
>>  13723 <at> debbugs.gnu.org,
>>  David Engster <deng <at> randomsample.de>
>> 
>> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm <at> gnu.org>:
>> 
>> > Eli Zaretskii wrote:
>> > 
>> >> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>> >> 24.2 nor with the current trunk.  I get a perfectly drawn border.
>> > 
>> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
>> > 
>> 
>> I see the issue on trunk, built for NS.
>
> Does the change below solve the problem on GNU/Linux and NS?

Yes, it does for me on GNU/Linux. Thanks!

-David

Message #44 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: David Engster <deng <at> randomsample.de>
Cc: 13723 <at> debbugs.gnu.org, jan.h.d <at> swipnet.se
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sat, 16 Feb 2013 22:51:36 +0200

> From: David Engster <deng <at> randomsample.de>
> Cc: Jan Djärv <jan.h.d <at> swipnet.se>,
>   13723 <at> debbugs.gnu.org
> Date: Sat, 16 Feb 2013 21:47:17 +0100
> 
> >> > I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
> >> > 
> >> 
> >> I see the issue on trunk, built for NS.
> >
> > Does the change below solve the problem on GNU/Linux and NS?
> 
> Yes, it does for me on GNU/Linux. Thanks!

Thanks for testing.

Glenn, I'd like to install this on the emacs-24 branch, any
objections?  The change looks a no-brainer, and obviously correct.

Message #47 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 13723 <at> debbugs.gnu.org, David Engster <deng <at> randomsample.de>
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sat, 16 Feb 2013 19:34:36 -0500

Eli Zaretskii wrote:

> Glenn, I'd like to install this on the emacs-24 branch, any
> objections?  The change looks a no-brainer, and obviously correct.

If you want to, go ahead.

Message #50 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rgm <at> gnu.org, deng <at> randomsample.de, 13723 <at> debbugs.gnu.org
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sun, 17 Feb 2013 10:59:40 +0100

Hello.

16 feb 2013 kl. 20:14 skrev Eli Zaretskii <eliz <at> gnu.org>:

>> From: Jan Djärv <jan.h.d <at> swipnet.se>
>> Date: Sat, 16 Feb 2013 18:15:36 +0100
>> Cc: Eli Zaretskii <eliz <at> gnu.org>,
>> 13723 <at> debbugs.gnu.org,
>> David Engster <deng <at> randomsample.de>
>> 
>> 15 feb 2013 kl. 20:30 skrev Glenn Morris <rgm <at> gnu.org>:
>> 
>>> Eli Zaretskii wrote:
>>> 
>>>> Unfortunately, I cannot reproduce this here, neither with stock Emacs
>>>> 24.2 nor with the current trunk.  I get a perfectly drawn border.
>>> 
>>> I see the issue in emacs-24 and trunk. x86_64 GNU/Linux, Lucid toolkit.
>>> 
>> 
>> I see the issue on trunk, built for NS.
> 
> Does the change below solve the problem on GNU/Linux and NS?
> 
> === modified file 'src/xdisp.c'
> --- src/xdisp.c	2013-02-15 12:26:42 +0000
> +++ src/xdisp.c	2013-02-16 19:11:29 +0000
> @@ -28257,8 +28257,8 @@ x_draw_vertical_border (struct window *w
> 
>       FRAME_RIF (f)->draw_vertical_window_border (w, x1, y0, y1);
>     }
> -  else if (!WINDOW_LEFTMOST_P (w)
> -	   && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
> +  if (!WINDOW_LEFTMOST_P (w)
> +      && !WINDOW_HAS_VERTICAL_SCROLL_BAR_ON_LEFT (w))
>     {
>       int x0, x1, y0, y1;
> 

Looks fine on NS.

	Jan D.

Message #55 received at 13723-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13723-done <at> debbugs.gnu.org, deng <at> randomsample.de
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sun, 17 Feb 2013 18:23:49 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Cc: David Engster <deng <at> randomsample.de>,  13723 <at> debbugs.gnu.org
> Date: Sat, 16 Feb 2013 19:34:36 -0500
> 
> Eli Zaretskii wrote:
> 
> > Glenn, I'd like to install this on the emacs-24 branch, any
> > objections?  The change looks a no-brainer, and obviously correct.
> 
> If you want to, go ahead.

Done in revision 111273 on emacs-24 branch.

Closing.

Message #58 received at 13723 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: rgm <at> gnu.org, deng <at> randomsample.de, 13723 <at> debbugs.gnu.org
Subject: Re: bug#13723: 24.2.93; Fringe icons corrupt buffer separator line
Date: Sun, 17 Feb 2013 18:24:17 +0200

> From: Jan Djärv <jan.h.d <at> swipnet.se>
> Date: Sun, 17 Feb 2013 10:59:40 +0100
> Cc: rgm <at> gnu.org,
>  13723 <at> debbugs.gnu.org,
>  deng <at> randomsample.de
> 
> Looks fine on NS.

Thanks for testing.  I installed the change.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.