GNU bug report logs - #13872
24.3-rc1; TERM_HEADER multiply defined during 'configure'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13872 in the body.
You can then email your comments to 13872 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3-rc1; TERM_HEADER multiply defined during 'configure'
Date: Mon, 04 Mar 2013 21:26:30 -0800

Building Emacs 24.3-rc1 on Fedora 17 x86-64 generates a config.log with
lots of these diagnostics:

conftest.c:242:0: warning: "TERM_HEADER" redefined [enabled by default]
conftest.c:71:0: note: this is the location of the previous definition

The problem is that TERM_HEADER is put into conftest.c twice, with
disagreeing definitions:

  #define TERM_HEADER "xterm.h"
  ...
  #define TERM_HEADER "gtkutil.h"

On this platform it happens to work, but I worry that on other
platforms the C compiler will reject any such test program (as it is
entitled to do), which will cause later configuration decisions to
go wrong.

Here's a fix.  This looks pretty safe.

=== modified file 'ChangeLog'
--- ChangeLog	2013-03-05 03:43:52 +0000
+++ ChangeLog	2013-03-05 05:21:41 +0000
@@ -1,3 +1,8 @@
+2013-03-05  Paul Eggert  <eggert <at> cs.ucla.edu>
+
+	* configure.ac (TERM_HEADER): Remove duplicate definition
+	that can mess up 'configure' runs.
+
 2013-03-05  Glenn Morris  <rgm <at> gnu.org>
 
 	* Makefile.in (install-man): Ignore gzip exit status.

=== modified file 'configure.ac'
--- configure.ac	2013-03-05 03:53:34 +0000
+++ configure.ac	2013-03-05 04:50:24 +0000
@@ -1646,11 +1646,6 @@
   ;;
 esac
 
-if test -n "${term_header}"; then
-    AC_DEFINE_UNQUOTED(TERM_HEADER, "${term_header}",
-        [Define to the header for the built-in window system.])
-fi
-
 if test "$window_system" = none && test "X$with_x" != "Xno"; then
    AC_CHECK_PROG(HAVE_XSERVER, X, true, false)
    if test "$HAVE_XSERVER" = true ||

Message #8 received at 13872 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 13872 <at> debbugs.gnu.org
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 03:28:59 -0500

How marvellous to hear about this now.
Sigh.

Message #11 received at 13872 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 13872 <at> debbugs.gnu.org, Daniel Colascione <dancol <at> dancol.org>
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 08:40:36 -0500

On 3/5/2013 12:26 AM, Paul Eggert wrote:
> Here's a fix.  This looks pretty safe.

Are you sure there are no tests between the two definitions of 
TERM_HEADER for which the latter should be defined?

I'm copying Daniel Colascione, since he's the one who introduced 
TERM_HEADER.

Ken

Message #14 received at 13872 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: 13872 <at> debbugs.gnu.org, Daniel Colascione <dancol <at> dancol.org>
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 06:56:03 -0800

On 03/05/2013 05:40 AM, Ken Brown wrote:
> Are you sure there are no tests between the two definitions of TERM_HEADER
> for which the latter should be defined?

Yes, because no test uses TERM_HEADER:

$ grep TERM_HEADER configure
#define TERM_HEADER "${term_header}"
#define TERM_HEADER "${term_header}"

Message #17 received at 13872 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 13872 <at> debbugs.gnu.org
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 12:20:27 -0500

OK, please apply to emacs-24.

Message #22 received at 13872-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13872-done <at> debbugs.gnu.org
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 09:26:51 -0800

On 03/05/13 09:20, Glenn Morris wrote:
> 
> OK, please apply to emacs-24.

Done, as emacs-24 bzr 111321.

Message #25 received at 13872 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13872 <at> debbugs.gnu.org
Subject: Re: bug#13872: 24.3-rc1;
	TERM_HEADER multiply defined during 'configure'
Date: Tue, 05 Mar 2013 19:42:04 +0200

> From: Glenn Morris <rgm <at> gnu.org>
> Date: Tue, 05 Mar 2013 03:28:59 -0500
> 
> 
> How marvellous to hear about this now.
> Sigh.

There's nothing you or anyone else could do about that.  First Law of
Release Management states that no matter how long you delay the
release trying to make it bug-free, a critical bug will be reported
within hours of the release announcement.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.