GNU bug report logs - #13875
24.3.50; whitespace-mode should use 'prepend for whitespace-line face

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13875 in the body.
You can then email your comments to 13875 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; whitespace-mode should use 'prepend for whitespace-line face
Date: Tue, 05 Mar 2013 20:36:21 +0400

Tags: patch

Right now, there's no way to tell whitespace-mode to keep the foreground
color of the underlying text when highlighting lines that are too long.

Related SO question:
http://stackoverflow.com/questions/14636786/how-to-unset-the-foreground-color-of-whitespace-mode-for-emacs

With the patch at the bottom applied, the following code will make it
keep the text's foreground and just change background:

  (set-face-attribute 'whitespace-line nil :foreground nil
                                           :background "gainsboro")

(Changing :backround is not necessary, but gray20 looks bad with the
default foreground color.)

=== modified file 'lisp/whitespace.el'
--- lisp/whitespace.el	2013-01-11 23:08:55 +0000
+++ lisp/whitespace.el	2013-03-05 16:25:51 +0000
@@ -2291,7 +2291,7 @@
 	 (if (memq 'lines whitespace-active-style)
 	     0				; whole line
 	   2)				; line tail
-	 whitespace-line t))
+	 whitespace-line 'prepend))
        t))
     (cond
      ((memq 'space-before-tab whitespace-active-style)

Message #8 received at 13875 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 13875 <at> debbugs.gnu.org
Subject: Re: bug#13875: 24.3.50;
	whitespace-mode should use 'prepend for whitespace-line face
Date: Sun, 17 Mar 2013 18:27:45 -0400

> -	 whitespace-line t))
> +	 whitespace-line 'prepend))

No objection on my part,


        Stefan

Message #13 received at 13875-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 13875-done <at> debbugs.gnu.org
Subject: Re: bug#13875: 24.3.50;
	whitespace-mode should use 'prepend for whitespace-line face
Date: Tue, 19 Mar 2013 08:24:05 +0400

Version: 24.4

On 18.03.2013 2:27, Stefan Monnier wrote:
>> -	 whitespace-line t))
>> +	 whitespace-line 'prepend))
>
> No objection on my part,

Thanks, installed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.