GNU bug report logs - #13879
Change src/msdos.c from raw-text to ASCII

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13879 in the body.
You can then email your comments to 13879 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: bug-gnu-emacs <at> gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Change src/msdos.c from raw-text to ASCII
Date: Tue, 05 Mar 2013 09:43:07 -0800

[Message part 1 (text/plain, inline)]

Tags: patch

In my attempt to make the Emacs sources UTF-8-safe, I ran across
src/msdos.c, which is currently raw-text because
it has string literals containing bytes with the top
bit set.  There's an easy way to make this ASCII, e.g.,
use the string literal "\375" rather than "X" (where X is
the actual byte with octal code 375).  Attached is a proposed patch.
I'm CC'ing this to Eli since this affects the MS-DOS port.

[msdos.txt (text/plain, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: Change src/msdos.c from raw-text to ASCII
Date: Tue, 05 Mar 2013 20:49:03 +0200

> Date: Tue, 05 Mar 2013 09:43:07 -0800
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> CC: Eli Zaretskii <eliz <at> gnu.org>
> 
> In my attempt to make the Emacs sources UTF-8-safe, I ran across
> src/msdos.c, which is currently raw-text because
> it has string literals containing bytes with the top
> bit set.  There's an easy way to make this ASCII, e.g.,
> use the string literal "\375" rather than "X" (where X is
> the actual byte with octal code 375).  Attached is a proposed patch.
> I'm CC'ing this to Eli since this affects the MS-DOS port.

Thanks, but I would like to make a different change there.  These
bytes are used in the definitions of non-US keyboard layouts, and it
is convenient to see the actual characters show up there, not escape
sequences.  Is it OK to use some suitable DOS codepage encoding for
this file instead of UTF-8?  If yes, I will make a suitable change.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: Change src/msdos.c from raw-text to ASCII
Date: Tue, 05 Mar 2013 12:03:00 -0800

On 03/05/13 10:49, Eli Zaretskii wrote:
>  Is it OK to use some suitable DOS codepage encoding for
> this file instead of UTF-8?  If yes, I will make a suitable change.

Yes, thanks, that'd make it clearer what's going on.

Message #16 received at 13879-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 13879-done <at> debbugs.gnu.org
Subject: Re: bug#13879: Change src/msdos.c from raw-text to ASCII
Date: Wed, 06 Mar 2013 18:23:21 +0200

> Date: Tue, 05 Mar 2013 12:03:00 -0800
> From: Paul Eggert <eggert <at> cs.ucla.edu>
> CC: bug-gnu-emacs <at> gnu.org
> 
> On 03/05/13 10:49, Eli Zaretskii wrote:
> >  Is it OK to use some suitable DOS codepage encoding for
> > this file instead of UTF-8?  If yes, I will make a suitable change.
> 
> Yes, thanks, that'd make it clearer what's going on.

Done in trunk revision 111956.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.