GNU bug report logs - #13886
24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13886 in the body.
You can then email your comments to 13886 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: E Sabof <esabof <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; vc-annotate won't show the log entry with git backend and
	hidden annotatation
Date: Wed, 6 Mar 2013 02:37:51 +0000

[Message part 1 (text/plain, inline)]

While in vc-annotate mode, with a git backend, if one hides the
annotations with vc-annotate-toggle-annotation-visiblity, and
tries to run vc-annotate-show-log-revision-at-line, it will display the
message "Cannot extract revision number from the current line".
Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()
  (save-excursion
    (forward-line 0)
    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")
      (let ((revision (match-string-no-properties 1)))
(if (match-beginning 2)
    (let ((fname (match-string-no-properties 3)))
      ;; Remove trailing whitespace from the file name.
      (when (string-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))))
      (cons revision
    (expand-file-name fname (vc-git-root default-directory))))
  revision)))))

Evgeni

[Message part 2 (text/html, inline)]

Message #10 received at 13886-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: E Sabof <esabof <at> gmail.com>
Cc: 13886-done <at> debbugs.gnu.org
Subject: Re: bug#13886: 24.3;
 vc-annotate won't show the log entry with git backend and hidden
 annotatation
Date: Mon, 25 Nov 2013 04:30:25 +0200

Version: 24.4

Thanks for the report, fixed in 115219.

Though I've changed it to use `beginning-of-line' for better
consistency, because implementations of this command in other backends
do that.

Message #13 received at 13886-done <at> debbugs.gnu.org (full text, mbox):

From: E Sabof <esabof <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 13886-done <at> debbugs.gnu.org
Subject: Re: bug#13886: 24.3; vc-annotate won't show the log entry with git
 backend and hidden annotatation
Date: Tue, 26 Nov 2013 17:14:51 +0000

[Message part 1 (text/plain, inline)]

Sounds good, if it still fixes the problem. Thanks!

Evgeni


On Mon, Nov 25, 2013 at 2:30 AM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> Version: 24.4
>
> Thanks for the report, fixed in 115219.
>
> Though I've changed it to use `beginning-of-line' for better
> consistency, because implementations of this command in other backends
> do that.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.