GNU bug report logs - #13914
24.3.50; fill-paragraph in makefile-automake-mode could make infinite loop.

Previous Next

Package: emacs;

Reported by: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>

Date: Sun, 10 Mar 2013 06:35:01 UTC

Severity: normal

Tags: patch

Found in version 24.3.50

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13914 in the body.
You can then email your comments to 13914 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#13914; Package emacs. (Sun, 10 Mar 2013 06:35:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 10 Mar 2013 06:35:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
	fill-paragraph in makefile-automake-mode could make infinite loop.
Date: Sun, 10 Mar 2013 15:33:24 +0900

The below code makes emacs go into infinite loop.

(with-temp-buffer
  (makefile-automake-mode)
  (insert "a \\")
  (fill-paragraph))


Please see the below patch.

=== modified file 'lisp/progmodes/make-mode.el'
--- lisp/progmodes/make-mode.el	2013-02-02 06:04:06 +0000
+++ lisp/progmodes/make-mode.el	2013-03-10 05:46:08 +0000
@@ -1298,7 +1298,7 @@
                  (point))))
 	    (end
 	     (save-excursion
-	       (while (= (preceding-char) ?\\)
+	       (while (and (= (preceding-char) ?\\) (null (eobp)))
 		 (end-of-line 2))
 	       (point))))
 	(save-restriction


-- 
Kazuhiro Ito
Reply sent to Chong Yidong <cyd <at> gnu.org>:
You have taken responsibility. (Wed, 18 Dec 2013 05:02:02 GMT) Full text and rfc822 format available.
Notification sent to Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>:
bug acknowledged by developer. (Wed, 18 Dec 2013 05:02:03 GMT) Full text and rfc822 format available.

Message #10 received at 13914-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: Kazuhiro Ito <kzhr <at> d1.dion.ne.jp>
Cc: 13914-done <at> debbugs.gnu.org
Subject: Re: bug#13914: 24.3.50;
 fill-paragraph in makefile-automake-mode could make infinite loop.
Date: Wed, 18 Dec 2013 13:01:40 +0800

Kazuhiro Ito <kzhr <at> d1.dion.ne.jp> writes:

> The below code makes emacs go into infinite loop.
>
> (with-temp-buffer
>   (makefile-automake-mode)
>   (insert "a \\")
>   (fill-paragraph))
>
>
> Please see the below patch.

Thanks, committed to trunk.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 15 Jan 2014 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 10 years and 109 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.