GNU bug report logs - #13925
ERRMAX in lib-src/pop.c

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 13925 in the body.
You can then email your comments to 13925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin von Gagern <Martin.vGagern <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: ERRMAX in lib-src/pop.c
Date: Mon, 11 Mar 2013 11:58:20 +0100

[Message part 1 (text/plain, inline)]

Hi!

The file "lib-src/pop.c" refers to a macro "ERRMAX" which isn't declared
on my system. Judging from the commit which introduced it [1], I'd say
this should be ERROR_MAX instead.

[1]
http://bzr.savannah.gnu.org/lh/emacs/emacs-24/revision/109003/lib-src/pop.c#lib-src/pop.c

Greetings,
 Martin von Gagern

[signature.asc (application/pgp-signature, attachment)]

Message #8 received at 13925 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Martin von Gagern <Martin.vGagern <at> gmx.net>
Cc: 13925 <at> debbugs.gnu.org
Subject: Re: bug#13925: ERRMAX in lib-src/pop.c
Date: Mon, 11 Mar 2013 13:23:57 -0400

Martin von Gagern wrote:

> The file "lib-src/pop.c" refers to a macro "ERRMAX" which isn't declared
> on my system. Judging from the commit which introduced it [1], I'd say
> this should be ERROR_MAX instead.

Congratulations, you found the deliberate mistake. :)

Please try at least a test build of a pretest next time. This issue
would have been obvious and easy to fix at any time during the past
several months of pretesting. Emacs can be built on so many systems
and in so many configurations that we rely on the help of pretesters
to test them.

Message #11 received at 13925 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 13925 <at> debbugs.gnu.org
Cc: Glenn Morris <rgm <at> gnu.org>
Subject: Re:  ERRMAX in lib-src/pop.c
Date: Tue, 12 Mar 2013 13:00:47 -0700

Sorry about the typo; it didn't trigger on my compilation platforms.

Here's the obvious patch.  Glenn, should I install this into
the emacs-24 branch or into the trunk?  I'm a bit fuzzy on
the branch status now that 24.3 has been released.

=== modified file 'lib-src/ChangeLog'
--- lib-src/ChangeLog	2013-03-11 02:35:23 +0000
+++ lib-src/ChangeLog	2013-03-12 19:57:55 +0000
@@ -1,3 +1,9 @@
+2013-03-12  Paul Eggert  <eggert <at> cs.ucla.edu>
+
+	* pop.c: Fix ERRMAX typo (Bug#13925).
+	(socket_connection) [!HAVE_KRB5_ERROR_TEXT && HAVE_KRB5_ERROR_E_TEXT]:
+	Use ERROR_MAX, not ERRMAX.
+
 2013-03-11  Glenn Morris  <rgm <at> gnu.org>
 
 	* Version 24.3 released.

=== modified file 'lib-src/pop.c'
--- lib-src/pop.c	2013-01-01 09:11:05 +0000
+++ lib-src/pop.c	2013-03-12 19:56:43 +0000
@@ -1198,7 +1198,7 @@
 	    }
 #elif defined HAVE_KRB5_ERROR_E_TEXT
 	  if (err_ret && err_ret->e_text && **err_ret->e_text)
-	    snprintf (pop_error + pop_error_len, ERRMAX - pop_error_len,
+	    snprintf (pop_error + pop_error_len, ERROR_MAX - pop_error_len,
 		      " [server says '%s']", *err_ret->e_text);
 #endif
 	  if (err_ret)

Message #14 received at 13925 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 13925 <at> debbugs.gnu.org
Subject: Re: ERRMAX in lib-src/pop.c
Date: Tue, 12 Mar 2013 17:57:04 -0400

Paul Eggert wrote:

> Here's the obvious patch.  Glenn, should I install this into
> the emacs-24 branch or into the trunk?  I'm a bit fuzzy on
> the branch status now that 24.3 has been released.

It is a totally safe fix, so emacs-24.

http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00058.html

My rule of thumb: if we had to release from emacs-24 tomorrow due to
some gaping security problem, am I happy to put this patch there today?

Message #19 received at 13925-done <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 13925-done <at> debbugs.gnu.org
Subject: Re: ERRMAX in lib-src/pop.c
Date: Tue, 12 Mar 2013 15:00:53 -0700

On 03/12/13 14:57, Glenn Morris wrote:
> It is a totally safe fix, so emacs-24.

Thanks, installed as emacs-24 bzr 111329 and marking this as done.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.