GNU bug report logs - #14034
24.3.50; M-/ runs diff-undo in Diff mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14034 in the body.
You can then email your comments to 14034 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: <rcopley <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Fri, 22 Mar 2013 22:07:34 +0000

[Message part 1 (text/plain, inline)]

In Diff mode, M-/ runs diff-undo. It should do dynamic completion, the same as everywhere else.

 

In GNU Emacs 24.3.50.1 (i386-mingw-nt6.2.9200)
 of 2013-03-22 on MACHINE
Bzr revision: 112110 dengste <at> eml.cc-20130322193115-9pi2k2te7nhmajgx
Windowing system distributor `Microsoft Corp.', version 6.2.9200
Configured using:
 `configure --with-gcc (4.7) --cflags -I c:/gnuwin32/include --ldflags
 -L c:/gnuwin32/lib'


Important settings:
  value of $LANG: ENG
  locale-coding-system: cp1252
  default enable-multibyte-characters: t


Major mode: Diff


Minor modes in effect:
  diff-auto-refine-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t


Recent input:
b u f M-/ M-x d i f f - m o d e <return> M-/ M-x r 
e p o r t - e m a c s - b u g <return>


Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Undo!


Load-path shadows:
None found.


Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev
gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util
mail-prsvr mail-utils diff-mode easymenu easy-mmode dabbrev time-date
tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp
w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image
regexp-opt fringe tabulated-list newcomment lisp-mode register page
menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process w32notify w32 multi-tty emacs)

[Message part 2 (text/html, inline)]

Message #8 received at 14034 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: <rcopley <at> gmail.com>
Cc: 14034 <at> debbugs.gnu.org
Subject: Re: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 08:29:34 +0400

<rcopley <at> gmail.com> writes:

> In Diff mode, M-/ runs diff-undo. It should do dynamic completion, the
> same as everywhere else.

Looking at diff-mode code, it appears to me we should simply remove the
explicit "/" binding. `diff-mode-shared-map' already remaps undo to
diff-undo.

Objections, anyone?

Message #11 received at 14034 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 14034 <at> debbugs.gnu.org
Subject: Re: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 10:27:06 +0000

On 23 March 2013 04:29, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> <rcopley <at> gmail.com> writes:
>
>> In Diff mode, M-/ runs diff-undo. It should do dynamic completion, the
>> same as everywhere else.
>
> Looking at diff-mode code, it appears to me we should simply remove the
> explicit "/" binding. `diff-mode-shared-map' already remaps undo to
> diff-undo.
>
> Objections, anyone?

Other useful commands keys get clobbered there, like M-TAB for
completion-at-point, M-{ and M-} for backward- and forward-paragraph,
and the M-o prefix.

Where do these strange M- mappings come from? Specifying "x" in that
list binds "M-x" as well. That's crazy.

Message #14 received at 14034 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Richard Copley <rcopley <at> gmail.com>
Cc: 14034 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 12:14:33 -0400

>> Looking at diff-mode code, it appears to me we should simply remove the
>> explicit "/" binding. `diff-mode-shared-map' already remaps undo to
>> diff-undo.
>> 
>> Objections, anyone?

No, please go ahead,

> Where do these strange M- mappings come from? Specifying "x" in that
> list binds "M-x" as well. That's crazy.


That would be crazy, indeed.  That's why there's no such `x' binding
in there.


        Stefan

Message #17 received at 14034 <at> debbugs.gnu.org (full text, mbox):

From: Richard Copley <rcopley <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14034 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 16:48:51 +0000

>> Looking at diff-mode code, it appears to me we should simply remove the
>> explicit "/" binding. `diff-mode-shared-map' already remaps undo to
>> diff-undo.

Thanks, that would be great.

>> Where do these strange M- mappings come from? Specifying "x" in that
>> list binds "M-x" as well. That's crazy.
>
> That would be crazy, indeed.  That's why there's no such `x' binding
> in there.

I apologise, I obviously failed to express my point. What I meant is
that in my opinion, it is incorrect that if "x" were specified in that
list then "M-x" would be bound. I wasn't only referring to "M-x". I
intended to include other keys, such as those I mentioned, which do
appear in the list: "M-o", "M-TAB", "M-{" and "M-}". If you disagree
or aren't interested, that's fine, and thanks anyway.

Message #20 received at 14034 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Richard Copley <rcopley <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 14034 <at> debbugs.gnu.org
Subject: Re: bug#14034: 24.3.50; M-/ runs diff-undo in Diff mode
Date: Sat, 23 Mar 2013 21:55:35 +0400

Version: 24.4

Richard Copley <rcopley <at> gmail.com> writes:
>>> Looking at diff-mode code, it appears to me we should simply remove the
>>> explicit "/" binding. `diff-mode-shared-map' already remaps undo to
>>> diff-undo.
>
> Thanks, that would be great.

Done, in trunk.

>>> Where do these strange M- mappings come from? Specifying "x" in that
>>> list binds "M-x" as well. That's crazy.
>>
>> That would be crazy, indeed.  That's why there's no such `x' binding
>> in there.
>
> I apologise, I obviously failed to express my point. What I meant is
> that in my opinion, it is incorrect that if "x" were specified in that
> list then "M-x" would be bound. I wasn't only referring to "M-x". I

In general, you can add one entry to almost any keymap to screw things
up (binding 'ignore to [remap save-buffers-kill-terminal], for example).

> intended to include other keys, such as those I mentioned, which do
> appear in the list: "M-o", "M-TAB", "M-{" and "M-}". If you disagree
> or aren't interested, that's fine, and thanks anyway.

Regarding curly braces, like the comment says, compilation-minor-mode
does the same, so it's consistent, al least.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.