GNU bug report logs - #14041
XTring_bell() does not work in some Linux distributions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14041 in the body.
You can then email your comments to 14041 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: PV <frerot13 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: XTring_bell() does not work in some Linux distributions
Date: Sat, 23 Mar 2013 11:38:37 +0100

Hi,

In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000

The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
but the function gdk_beep() is not,
thus I suggest to modify XTring_bell () in xterm.c in the following way:


/* Make audible bell.  */

void
XTring_bell ()
{
  struct frame *f = SELECTED_FRAME ();

  if (FRAME_X_DISPLAY (f))
    {
#if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
      if (visible_bell)
	XTflash (f);
      else
#endif
	{
	  BLOCK_INPUT;
#ifdef USE_GTK           	     // P.VINCENT
	  gdk_beep ();   	     // P.VINCENT
#else			 	     // P.VINCENT
	  XBell (FRAME_X_DISPLAY (f), 0);
	  XFlush (FRAME_X_DISPLAY (f));
#endif                   	     // P.VINCENT
	  UNBLOCK_INPUT;
	}
    }
}

Best regards,
Patrick VINCENT

Message #10 received at 14041-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: PV <frerot13 <at> gmail.com>
Cc: 14041-done <at> debbugs.gnu.org
Subject: Re: bug#14041: XTring_bell() does not work in some Linux distributions
Date: Mon, 25 Mar 2013 19:01:21 +0100

Hello.

This has been fixed in the trunk in another way.

	Jan D.

23 mar 2013 kl. 11:38 skrev PV <frerot13 <at> gmail.com>:

> Hi,
> 
> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
> 
> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
> but the function gdk_beep() is not,
> thus I suggest to modify XTring_bell () in xterm.c in the following way:
> 
> 
> /* Make audible bell.  */
> 
> void
> XTring_bell ()
> {
>  struct frame *f = SELECTED_FRAME ();
> 
>  if (FRAME_X_DISPLAY (f))
>    {
> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
>      if (visible_bell)
> 	XTflash (f);
>      else
> #endif
> 	{
> 	  BLOCK_INPUT;
> #ifdef USE_GTK           	     // P.VINCENT
> 	  gdk_beep ();   	     // P.VINCENT
> #else			 	     // P.VINCENT
> 	  XBell (FRAME_X_DISPLAY (f), 0);
> 	  XFlush (FRAME_X_DISPLAY (f));
> #endif                   	     // P.VINCENT
> 	  UNBLOCK_INPUT;
> 	}
>    }
> }
> 
> Best regards,
> Patrick VINCENT
> 
> 

Message #15 received at 14041 <at> debbugs.gnu.org (full text, mbox):

From: Petr Hracek <phracek <at> redhat.com>
To: 14041 <at> debbugs.gnu.org, jan.h.d <at> swipnet.se, frerot13 <at> gmail.com
Subject: Re: bug#14041: XTring_bell() does not work in some Linux distributions
Date: Tue, 26 Mar 2013 14:07:22 +0100

Hello Jan,

we have already emacs version 24.2 in which that patch included
especially function XTring_bell() (xterm.c) in another way.
What is a bug number for that case?

Where there any another files modified?

best regards
Petr

On 03/25/2013 07:01 PM, Jan Djärv wrote:
> Hello.
>
> This has been fixed in the trunk in another way.
>
> 	Jan D.
>
> 23 mar 2013 kl. 11:38 skrev PV <frerot13 <at> gmail.com>:
>
>> Hi,
>>
>> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
>> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
>>
>> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
>> but the function gdk_beep() is not,
>> thus I suggest to modify XTring_bell () in xterm.c in the following way:
>>
>>
>> /* Make audible bell.  */
>>
>> void
>> XTring_bell ()
>> {
>>   struct frame *f = SELECTED_FRAME ();
>>
>>   if (FRAME_X_DISPLAY (f))
>>     {
>> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
>>       if (visible_bell)
>> 	XTflash (f);
>>       else
>> #endif
>> 	{
>> 	  BLOCK_INPUT;
>> #ifdef USE_GTK           	     // P.VINCENT
>> 	  gdk_beep ();   	     // P.VINCENT
>> #else			 	     // P.VINCENT
>> 	  XBell (FRAME_X_DISPLAY (f), 0);
>> 	  XFlush (FRAME_X_DISPLAY (f));
>> #endif                   	     // P.VINCENT
>> 	  UNBLOCK_INPUT;
>> 	}
>>     }
>> }
>>
>> Best regards,
>> Patrick VINCENT
>>
>>
>
>
>

-- 
S pozdravem / Best regards

Petr Hracek

Red Hat Czech s.r.o.
BaseOS Core Services Brno

Email: phracek <at> redhat.com
Web: www.cz.redhat.com

Message #18 received at 14041 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Petr Hracek <phracek <at> redhat.com>
Cc: frerot13 <at> gmail.com, 14041 <at> debbugs.gnu.org
Subject: Re: bug#14041: XTring_bell() does not work in some Linux distributions
Date: Tue, 26 Mar 2013 15:52:42 +0100

Hello.

26 mar 2013 kl. 14:07 skrev Petr Hracek <phracek <at> redhat.com>:

> Hello Jan,
> 
> we have already emacs version 24.2 in which that patch included
> especially function XTring_bell() (xterm.c) in another way.
> What is a bug number for that case?
> 
> Where there any another files modified?
> 

I don't understand what you are trying to say.
24.2 does not have any patch to XTring_bell.
Files modified can be seen by browsing the bzr repository, in this case http://bzr.savannah.gnu.org/lh/emacs/trunk/revision/112131.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.