GNU bug report logs - #14066
24.3; vc-bzr-revert shouldn't create backup files

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Wed, 27 Mar 2013 15:43:03 UTC

Severity: normal

Found in version 24.3

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14066 in the body.
You can then email your comments to 14066 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14066; Package emacs. (Wed, 27 Mar 2013 15:43:03 GMT) Full text and rfc822 format available.
Acknowledgement sent to Leo Liu <sdl.web <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Wed, 27 Mar 2013 15:43:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; vc-bzr-revert shouldn't create backup files
Date: Wed, 27 Mar 2013 23:36:53 +0800

According to vc-default-make-version-backups-p, no backup file is
created for the bzr backend. However 'bzr revert' itself creates backups
which is very confusing.

So I propose the following patch:

diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el
index f436d300..c1195eee 100644
--- a/lisp/vc/vc-bzr.el
+++ b/lisp/vc/vc-bzr.el
@@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev)
 
 (defun vc-bzr-revert (file &optional contents-done)
   (unless contents-done
-    (with-temp-buffer (vc-bzr-command "revert" t 0 file))))
+    (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup"))))
 
 (defvar log-view-message-re)
 (defvar log-view-file-re)
Reply sent to Leo Liu <sdl.web <at> gmail.com>:
You have taken responsibility. (Thu, 28 Mar 2013 03:32:01 GMT) Full text and rfc822 format available.
Notification sent to Leo Liu <sdl.web <at> gmail.com>:
bug acknowledged by developer. (Thu, 28 Mar 2013 03:32:01 GMT) Full text and rfc822 format available.

Message #10 received at 14066-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: 14066-done <at> debbugs.gnu.org
Subject: Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files
Date: Thu, 28 Mar 2013 11:29:23 +0800

Fixed in trunk
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 25 Apr 2013 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 24 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.