GNU bug report logs - #14135
<f4> not recording macro

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14135 in the body.
You can then email your comments to 14135 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: <f4> not recording macro
Date: Wed, 3 Apr 2013 23:53:22 +0200

Package: emacs
Version: 24.3.50

emacs -Q
<f3>    ;; Defining kbd macro...
a
<f4>    ;; Keyboard macro defined
<f4>    ;; No kbd macro has been defined

Message #8 received at 14135 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14135 <at> debbugs.gnu.org
Subject: Re: bug#14135: <f4> not recording macro
Date: Fri, 05 Apr 2013 15:28:21 +0800

On 2013-04-04 05:53 +0800, Juanma Barranquero wrote:
> Package: emacs
> Version: 24.3.50
>
> emacs -Q
> <f3>    ;; Defining kbd macro...
> a
> <f4>    ;; Keyboard macro defined
> <f4>    ;; No kbd macro has been defined

Thanks for the bug report. Sorry this is broken by my commit.

Could you give the following patch a good test? Thanks a lot. -- Leo

diff --git a/lisp/kmacro.el b/lisp/kmacro.el
index c08f49df..d6de2feb 100644
--- a/lisp/kmacro.el
+++ b/lisp/kmacro.el
@@ -631,11 +631,11 @@ (defun kmacro-call-macro (arg &optional no-repeat end-macro macro)
                                   (> (length (this-single-command-keys)) 1))
                              ;; Used when we're in the process of repeating.
                              (eq no-repeat 'repeating))
-			 last-input-event))
-	(last-kbd-macro (or macro last-kbd-macro)))
+			 last-input-event)))
     (if end-macro
-	(kmacro-end-macro arg)
-      (call-last-kbd-macro arg #'kmacro-loop-setup-function))
+	(kmacro-end-macro arg)		; modifies last-kbd-macro
+      (let ((last-kbd-macro (or macro last-kbd-macro)))
+	(call-last-kbd-macro arg #'kmacro-loop-setup-function)))
     (when (consp arg)
       (setq arg (car arg)))
     (when (and (or (null arg) (> arg 0))
@@ -658,7 +658,9 @@ (defun kmacro-call-macro (arg &optional no-repeat end-macro macro)
          (define-key map (vector repeat-key)
            `(lambda () (interactive)
               (kmacro-call-macro ,(and kmacro-call-repeat-with-arg arg)
-                                 'repeating nil ,last-kbd-macro)))
+                                 'repeating nil ,(if end-macro
+						     last-kbd-macro
+						   (or macro last-kbd-macro)))))
          map)))))

Message #11 received at 14135 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 14135 <at> debbugs.gnu.org
Subject: Re: bug#14135: <f4> not recording macro
Date: Fri, 5 Apr 2013 10:28:16 +0200

On Fri, Apr 5, 2013 at 9:28 AM, Leo Liu <sdl.web <at> gmail.com> wrote:

> Could you give the following patch a good test?

I'm not so heavy a user of macros to give it a "good test", but the
broken functionality is restored.

Thanks,

   J

Message #16 received at 14135-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14135-done <at> debbugs.gnu.org
Subject: Re: bug#14135: <f4> not recording macro
Date: Fri, 05 Apr 2013 16:40:20 +0800

Fixed in trunk.

On 2013-04-05 16:28 +0800, Juanma Barranquero wrote:
> I'm not so heavy a user of macros to give it a "good test", but the
> broken functionality is restored.

Thanks.
Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.