GNU bug report logs - #14348
24.3.50; `custom-magic-alist': Bad & missing handling of `themed'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14348 in the body.
You can then email your comments to 14348 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Drew Adams" <drew.adams <at> oracle.com>
To: <bug-gnu-emacs <at> gnu.org>
Subject: 24.3.50; `custom-magic-alist': Bad & missing handling of `themed'
Date: Sat, 4 May 2013 08:44:10 -0700

The value `themed' was added as a possibility for `custom-magic-alist'.
But this seems to have been done only partially and wrongly.
 
1. When `themed' is the value, the only accompanying text says only
this: "THEMED."  That tells you nothing about what the state means.
 
2. When a Customize group is involved, the accompanying text instead
says only this: "visible group members are all at standard values."
 
Is that correct?  That text seems to have simply been copy+pasted from
the text for value `standard'.  Doesn't seem correct to me.
 
3. But I don't know what value `themed' means, so I cannot suggest a
correction.  Searching for `themed' in the file, I see `custom-themed',
whose doc string says it is a face used when the customize item has been
set by a theme.  So perhaps `themed' as a state value means that the
item has been set by a theme?  Just a guess.  But what does it mean to
have been set by a theme?  Is that something that the user did in
Customize, or is it something that was done outside of Customize?
 
4. The `custom-magic-alist' doc string was never updated, to reflect the
addition of the possible value `themed'.  It details what each value
means - except for `themed'.
 
In sum, this new value was added without doing the work necessary to let
users know WTF it is for.  Please make clear what the state means,
including what it indicates wrt how the value was set/changed/defined.
 
 
 
In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600)
 of 2013-04-26 on ODIEONE
Bzr revision: 112399 eggert <at> cs.ucla.edu-20130426193109-3chlhmjv621m7zdz
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'
 

Message #10 received at 14348-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 14348-done <at> debbugs.gnu.org
Subject: Re: bug#14348: 24.3.50;
 `custom-magic-alist': Bad & missing handling of `themed'
Date: Wed, 18 Dec 2013 16:59:40 +0800

"Drew Adams" <drew.adams <at> oracle.com> writes:

> When a Customize group is involved, the accompanying text instead says
> only this: "visible group members are all at standard values."
>
> Is that correct?  That text seems to have simply been copy+pasted from
> the text for value `standard'.  Doesn't seem correct to me.

I've now tweaked it to say that it was set by an enabled Custom theme.
The docstring was also updated.  See the node on Custom Themes in the
Emacs manual for more information on Custom themes.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.