GNU bug report logs - #14394
jit-lock-force-redisplay redefinition breaks jit fontification in auctex

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14394 in the body.
You can then email your comments to 14394 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org, bug-auctex <at> gnu.org,
	Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: jit-lock-force-redisplay redefinition breaks jit fontification in
	auctex
Date: Mon, 13 May 2013 11:23:07 +0200

Hi,

A commit of Stefan Monnier in April 23 changed the API of
jit-lock-force-redisplay. First and easiest, the docstring of
jit-lock-force-redisplay was not changed, and still mentions the old BUF
argument.

Second, this breaks function font-latex-jit-lock-force-redisplay in
auctex, which uses the old prototype. This is present in emacs and
auctex from trunk. Is the prototype change really necessary? If no, this
is a bug for emacs, if yes, this is a bug for auctex. In doubt, I'm
submitting the report in both.

Message #8 received at 14394 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Antoine Levitt <antoine.levitt <at> gmail.com>
Cc: bug-auctex <at> gnu.org, 14394 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#14394: jit-lock-force-redisplay redefinition breaks
	jit	fontification in auctex
Date: Mon, 13 May 2013 19:11:55 +0300

> From: Antoine Levitt <antoine.levitt <at> gmail.com>
> Date: Mon, 13 May 2013 11:23:07 +0200
> 
> A commit of Stefan Monnier in April 23 changed the API of
> jit-lock-force-redisplay. First and easiest, the docstring of
> jit-lock-force-redisplay was not changed, and still mentions the old BUF
> argument.
> 
> Second, this breaks function font-latex-jit-lock-force-redisplay in
> auctex, which uses the old prototype. This is present in emacs and
> auctex from trunk.

The doc string fix issue aside, is there any reason why AUCTeX should
call jit-lock-force-redisplay, instead of always using its expanded
code, like it does for versions of Emacs that don't have that
function?

I mean, doesn't this incident speak volumes about the danger of using
internal APIs?

Message #11 received at 14394 <at> debbugs.gnu.org (full text, mbox):

From: Ralf Angeli <angeli <at> caeruleus.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: bug-auctex <at> gnu.org, 14394 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca,
	Antoine Levitt <antoine.levitt <at> gmail.com>
Subject: Re: [Bug-AUCTeX] bug#14394: jit-lock-force-redisplay redefinition
	breaks jit	fontification in auctex
Date: Mon, 13 May 2013 18:57:51 +0200

* Eli Zaretskii (2013-05-13) writes:

>> Second, this breaks function font-latex-jit-lock-force-redisplay in
>> auctex, which uses the old prototype. This is present in emacs and
>> auctex from trunk.
>
> The doc string fix issue aside, is there any reason why AUCTeX should
> call jit-lock-force-redisplay, instead of always using its expanded
> code, like it does for versions of Emacs that don't have that
> function?

I guess the idea was that calling the function might be more
forward-compatible than using the expanded code because this decouples
the code from future changes in the underlying machinery.  In this
particular case this didn't work so well, but things can break with
either approach.

Mosè already changed the code in AUCTeX's repository to use the expanded
code only, so we might stick with this for the time being and see what
happens.

-- 
Ralf

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Antoine Levitt <antoine.levitt <at> gmail.com>
Cc: bug-auctex <at> gnu.org, bug-gnu-emacs <at> gnu.org
Subject: Re: jit-lock-force-redisplay redefinition breaks jit fontification in
	auctex
Date: Tue, 14 May 2013 11:52:06 -0400

> Second, this breaks function font-latex-jit-lock-force-redisplay in
> auctex, which uses the old prototype. This is present in emacs and
> auctex from trunk. Is the prototype change really necessary? If no, this
> is a bug for emacs, if yes, this is a bug for auctex. In doubt, I'm
> submitting the report in both.

The answer is that font-latex should not modify
font-lock-fontify-region-function and should instead use
font-lock-extend-region-functions (it's OK to do what it does when
running on older Emacsen which do not have
font-lock-extend-region-functions, of course).


        Stefan

Message #19 received at 14394-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 14394-done <at> debbugs.gnu.org
Subject: Re: bug#14394: jit-lock-force-redisplay redefinition breaks jit
 fontification in auctex
Date: Mon, 10 Feb 2014 16:44:34 -0500

Version: 24.4

Antoine Levitt wrote:

> First and easiest, the docstring of jit-lock-force-redisplay was not
> changed, and still mentions the old BUF argument.

Fixed.

The remainder is an AUCTeX issue, and since you said you already mailed
them about it, no need to keep this Emacs bug report open.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.