GNU bug report logs - #14399
octave-mode bug

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14399 in the body.
You can then email your comments to 14399 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Olin <tom_olin <at> partech.com>
To: Kurt Hornik <Kurt.Hornik <at> wu-wien.ac.at>, bug-gnu-emacs <at> gnu.org
Subject: octave-mode bug
Date: Tue, 14 May 2013 13:05:09 -0400

[Message part 1 (text/plain, inline)]

The following code does not indent correctly (IMHO) with octave-mode:

vec = [...
one;...
two;...
three];

What I get is this:

vec = [...
        one;...
           two;...
              three];



Emacs  : GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars)
 of 2013-03-21 on alum.local
Package: Emacs version 24.3.1

current state:
==============
(setq
 octave-blink-matching-block t
 octave-block-offset 2
 octave-comment-char 35
 octave-continuation-offset 4
 octave-continuation-string "..."
 octave-send-echo-input t
 octave-send-line-auto-forward t
 octave-send-show-buffer t
 )


--
Tom Olin
Senior Systems Engineer | PAR Government Systems Corporation
315.356.2142 | tom_olin <at> partech.com | http://pargovernment.com

[smime.p7s (application/pkcs7-signature, attachment)]

Message #8 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Tom Olin <tom_olin <at> partech.com>
Cc: Kurt.Hornik <at> wu-wien.ac.at, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Wed, 15 May 2013 20:00:51 +0800

I have written to octave's maintainers' list:
http://article.gmane.org/gmane.comp.gnu.octave.maintainers/32441

Leo

Message #11 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Sat, 18 May 2013 07:13:10 +0800

Hi Stefan,

On 2013-05-15 20:00 +0800, Leo Liu wrote:
> http://article.gmane.org/gmane.comp.gnu.octave.maintainers/32441

It seems the octave community's consensus is: ... should not introduce
extra indentation in (), [] or {}. Could you help fix this bug?

Leo

Message #14 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Fri, 22 Nov 2013 10:11:06 +0800

On 2013-05-18 07:13 +0800, Leo Liu wrote:
> It seems the octave community's consensus is: ... should not introduce
> extra indentation in (), [] or {}. Could you help fix this bug?

Hi Stefan,

I am unfamiliar with smie. I have been meaning to understand it but
haven't found time to. Could you help fix this indentation bug?

Leo

Message #17 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Fri, 22 Nov 2013 09:27:57 -0500

> I am unfamiliar with smie. I have been meaning to understand it but
> haven't found time to. Could you help fix this indentation bug?

I can't remember much of the syntax of Octave.  What does ";..." mean?


        Stefan

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: 14399 <at> debbugs.gnu.org, Tom Olin <tom_olin <at> partech.com>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, Leo Liu <sdl.web <at> gmail.com>
Subject: Re: bug#14399: octave-mode bug
Date: Fri, 22 Nov 2013 15:57:59 +0100

On Friday 22 November 2013 09:27:57 Stefan Monnier wrote:
> > I am unfamiliar with smie. I have been meaning to understand it but
> > haven't found time to. Could you help fix this indentation bug?
> 
> I can't remember much of the syntax of Octave.  What does ";..." mean?

... introduces a continuation line.  Similar to \ in other languages.

a = [ foo;...
bar ]

is the same as a = [ foo; bar ].

See (info "(octave) Continuation Lines")

Regards,
Rüdiger

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: bug-gnu-emacs <at> gnu.org, Tom Olin <tom_olin <at> partech.com>,
 Leo Liu <sdl.web <at> gmail.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Fri, 22 Nov 2013 21:03:18 -0500

>> > I am unfamiliar with smie. I have been meaning to understand it but
>> > haven't found time to. Could you help fix this indentation bug?
>> I can't remember much of the syntax of Octave.  What does ";..." mean?
> ... introduces a continuation line.  Similar to \ in other languages.

> a = [ foo;...
> bar ]

> is the same as a = [ foo; bar ].

That's the part I knew already ;-)

But in which way is 

   a = [ foo;...
         bar ]

different from

   a = [ foo
         bar ]
or
   a = [ foo;
         bar ]

-- Stefan

Message #32 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: Tom Olin <tom_olin <at> partech.com>, Leo Liu <sdl.web <at> gmail.com>,
 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Wed, 27 Nov 2013 23:40:48 -0500

Ping?

>>>>> "Stefan" == Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>>> > I am unfamiliar with smie. I have been meaning to understand it but
>>> > haven't found time to. Could you help fix this indentation bug?
>>> I can't remember much of the syntax of Octave.  What does ";..." mean?
>> ... introduces a continuation line.  Similar to \ in other languages.

>> a = [ foo;...
>> bar ]

>> is the same as a = [ foo; bar ].

> That's the part I knew already ;-)

> But in which way is 

>    a = [ foo;...
>          bar ]

> different from

>    a = [ foo
>          bar ]
> or
>    a = [ foo;
>          bar ]

> -- Stefan

Message #35 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Achim Gratz <Stromeko <at> nexgo.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Thu, 28 Nov 2013 08:37:21 +0100

Stefan Monnier writes:
> That's the part I knew already ;-)
>
> But in which way is 
>
>    a = [ foo;...
>          bar ]
>
> different from
>
>    a = [ foo
>          bar ]
> or
>    a = [ foo;
>          bar ]

For these three examples there is no difference because the newlines and
whitespace the continuation marker gobbles up wouldn't terminate or
alter the statement.  On the other hand

a = [ foo ...
      bar ]

_is_ different (introducing another column rather than a row).


Regards,
Achim.
-- 
+<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+

Factory and User Sound Singles for Waldorf rackAttack:
http://Synth.Stromeko.net/Downloads.html#WaldorfSounds

Message #38 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Tom Olin <tom_olin <at> partech.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>,
 Leo Liu <sdl.web <at> gmail.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Sat, 30 Nov 2013 08:09:43 -0500

[Message part 1 (text/plain, inline)]

A semicolon separates rows; a comma or space separates columns. Thus [ foo bar ] or [ foo, bar ] is a 1x2 matrix. [ foo; bar ] is a 2x1 matrix.

--
Tom Olin
Senior Systems Engineer | PAR Government Systems Corporation
315.356.2142 | tom_olin <at> partech.com | http://pargovernment.com



On Nov 27, 2013, at 11:40 PM, Stefan Monnier <monnier <at> iro.umontreal.ca> wrote:

> Ping?
> 
>>>>>> "Stefan" == Stefan Monnier <monnier <at> iro.umontreal.ca> writes:
> 
>>>>> I am unfamiliar with smie. I have been meaning to understand it but
>>>>> haven't found time to. Could you help fix this indentation bug?
>>>> I can't remember much of the syntax of Octave.  What does ";..." mean?
>>> ... introduces a continuation line.  Similar to \ in other languages.
> 
>>> a = [ foo;...
>>> bar ]
> 
>>> is the same as a = [ foo; bar ].
> 
>> That's the part I knew already ;-)
> 
>> But in which way is 
> 
>>   a = [ foo;...
>>         bar ]
> 
>> different from
> 
>>   a = [ foo
>>         bar ]
>> or
>>   a = [ foo;
>>         bar ]
> 
>> -- Stefan

[smime.p7s (application/pkcs7-signature, attachment)]

Message #41 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Achim Gratz <Stromeko <at> nexgo.de>
Cc: 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Sat, 30 Nov 2013 12:19:30 -0500

>> That's the part I knew already ;-)
>> 
>> But in which way is 
>> 
>> a = [ foo;...
>> bar ]
>> 
>> different from
>> 
>> a = [ foo
>> bar ]
>> or
>> a = [ foo;
>> bar ]

> For these three examples there is no difference because the newlines and
> whitespace the continuation marker gobbles up wouldn't terminate or
> alter the statement.

Thanks.  So it begs the question: why would someone write

 a = [ foo;...
       bar ]

instead of one of the other two?  I'm trying to understand what's the
intention behind it, to better understand how the code should behave.


        Stefan

Message #44 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Achim Gratz <Stromeko <at> nexgo.de>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Mon, 02 Dec 2013 15:51:28 +0100

On Saturday 30 November 2013 12:19:30 Stefan Monnier wrote:
> Thanks.  So it begs the question: why would someone write
> 
>  a = [ foo;...
>        bar ]
> 
> instead of one of the other two?  I'm trying to understand what's the
> intention behind it, to better understand how the code should behave.

I think it's just a matter of style.  I thought it had something to do with 
Matlab compatibility but a quick test showed that Matlab accepts both forms as 
well.

Regards,
Rüdiger

Message #50 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Mon, 02 Dec 2013 10:15:59 -0500

>> It seems the octave community's consensus is: ... should not introduce
>> extra indentation in (), [] or {}. Could you help fix this bug?
> I am unfamiliar with smie.  I have been meaning to understand it but
> haven't found time to.  Could you help fix this indentation bug?

Looks like we've all been pretty dumb: not sure about the OP's real code
but at least his test case gets indented like this with Emacs's trunk:

  vec = [...
          one;...
          two;...
          three];

So it looks like the bug is already fixed.


        Stefan

Message #53 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Mon, 02 Dec 2013 23:58:18 +0800

On 2013-12-02 23:15 +0800, Stefan Monnier wrote:
> Looks like we've all been pretty dumb: not sure about the OP's real code
> but at least his test case gets indented like this with Emacs's trunk:
>
>   vec = [...
>           one;...
>           two;...
>           three];
>
> So it looks like the bug is already fixed.

I was able to reproduce the bug some time ago but indeed this seems
fixed in trunk. but

x = ...
12

doesn't indent the second line correctly.

Leo

Message #56 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Tom Olin <tom_olin <at> partech.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Mon, 02 Dec 2013 11:08:06 -0500

> x = ...
> 12

> doesn't indent the second line correctly.

That's simply for lack of a corresponding rule in octave-smie-rules.
Try M-x smie-edebug RET


        Stefan

Message #59 received at 14399 <at> debbugs.gnu.org (full text, mbox):

From: Tom Olin <tom_olin <at> partech.com>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Tue, 3 Dec 2013 09:56:39 -0500

[Message part 1 (text/plain, inline)]

Just FWIW, I'm still seeing the problem. I get:

vec = [...
	one;...
	   two;...
	      three];

I'm using:

GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars) of 2013-03-21

from MacPorts. How far from HEAD is that?

--
Tom Olin
Senior Systems Engineer | PAR Government Systems Corporation
315.356.2142 | tom_olin <at> partech.com | http://pargovernment.com



On Dec 2, 2013, at 10:58 AM, Leo Liu <sdl.web <at> gmail.com> wrote:

> On 2013-12-02 23:15 +0800, Stefan Monnier wrote:
>> Looks like we've all been pretty dumb: not sure about the OP's real code
>> but at least his test case gets indented like this with Emacs's trunk:
>> 
>>  vec = [...
>>          one;...
>>          two;...
>>          three];
>> 
>> So it looks like the bug is already fixed.
> 
> I was able to reproduce the bug some time ago but indeed this seems
> fixed in trunk. but
> 
> x = ...
> 12
> 
> doesn't indent the second line correctly.
> 
> Leo

[smime.p7s (application/pkcs7-signature, attachment)]

Message #62 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: Tom Olin <tom_olin <at> partech.com>, Leo Liu <sdl.web <at> gmail.com>,
 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Tue, 03 Dec 2013 19:32:50 +0100

[Message part 1 (text/plain, inline)]

On Tuesday 03 December 2013 09:56:39 Tom Olin wrote:
> Just FWIW, I'm still seeing the problem. I get:
> 
> vec = [...
> 	one;...
> 	   two;...
> 	      three];
> 
> I'm using:
> 
> GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars) of
> 2013-03-21
> 
> from MacPorts. How far from HEAD is that?

Very far.  Thanks to Leo Octave mode was improved quite significantly since 
the release of 24.3.  It should be backward compatible to 24.3.  If you want 
to try it you could copy octave.el from bzr and load it in your Emacs.

Regards,
Rüdiger

[signature.asc (application/pgp-signature, inline)]

Message #68 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Olin <tom_olin <at> partech.com>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: bug-gnu-emacs <at> gnu.org, Leo Liu <sdl.web <at> gmail.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Tue, 3 Dec 2013 13:45:26 -0500

[Message part 1 (text/plain, inline)]

I will give that a try. Thanks.

--
Tom Olin
Senior Systems Engineer | PAR Government Systems Corporation
315.356.2142 | tom_olin <at> partech.com | http://pargovernment.com



On Dec 3, 2013, at 1:32 PM, Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> wrote:

> On Tuesday 03 December 2013 09:56:39 Tom Olin wrote:
>> Just FWIW, I'm still seeing the problem. I get:
>> 
>> vec = [...
>> 	one;...
>> 	   two;...
>> 	      three];
>> 
>> I'm using:
>> 
>> GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars) of
>> 2013-03-21
>> 
>> from MacPorts. How far from HEAD is that?
> 
> Very far.  Thanks to Leo Octave mode was improved quite significantly since 
> the release of 24.3.  It should be backward compatible to 24.3.  If you want 
> to try it you could copy octave.el from bzr and load it in your Emacs.
> 
> Regards,
> Rüdiger

[smime.p7s (application/pkcs7-signature, attachment)]

Message #74 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Olin <tom_olin <at> partech.com>
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: bug-gnu-emacs <at> gnu.org, Leo Liu <sdl.web <at> gmail.com>, 14399 <at> debbugs.gnu.org
Subject: Re: bug#14399: octave-mode bug
Date: Tue, 3 Dec 2013 16:00:04 -0500

[Message part 1 (text/plain, inline)]

I've confirmed that the latest version of octave.el works correctly. Thanks!

--
Tom Olin
Senior Systems Engineer | PAR Government Systems Corporation
315.356.2142 | tom_olin <at> partech.com | http://pargovernment.com



On Dec 3, 2013, at 1:32 PM, Rüdiger Sonderfeld <ruediger <at> c-plusplus.de> wrote:

> On Tuesday 03 December 2013 09:56:39 Tom Olin wrote:
>> Just FWIW, I'm still seeing the problem. I get:
>> 
>> vec = [...
>> 	one;...
>> 	   two;...
>> 	      three];
>> 
>> I'm using:
>> 
>> GNU Emacs 24.3.1 (x86_64-apple-darwin12.2.0, X toolkit, Xaw scroll bars) of
>> 2013-03-21
>> 
>> from MacPorts. How far from HEAD is that?
> 
> Very far.  Thanks to Leo Octave mode was improved quite significantly since 
> the release of 24.3.  It should be backward compatible to 24.3.  If you want 
> to try it you could copy octave.el from bzr and load it in your Emacs.
> 
> Regards,
> Rüdiger

[smime.p7s (application/pkcs7-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.