GNU bug report logs - #14527
24.3.50; error in window-state-get

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14527 in the body.
You can then email your comments to 14527 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Constantin Kulikov <zxnotdead <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; error in window-state-get
Date: Sat, 1 Jun 2013 13:59:38 +0400

[Message part 1 (text/plain, inline)]

emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
introduced in some earlier version.

emacs -Q --debug-init
M-: (window-state-get)
see the error:
```
Debugger entered--Lisp error: (error "Combination limit is meaningful for
internal windows only")
  window-combination-limit(#<window 0x11106b8 on *scratch*>)
  window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
  window-state-get()
  eval((window-state-get) nil)
  eval-expression((window-state-get) nil)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)
```

[Message part 2 (text/html, inline)]

Message #8 received at 14527 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Constantin Kulikov <zxnotdead <at> gmail.com>, 
	Dmitry Antipov <dmantipov <at> yandex.ru>
Cc: 14527 <at> debbugs.gnu.org
Subject: Re: bug#14527: 24.3.50; error in window-state-get
Date: Sat, 01 Jun 2013 14:33:16 +0200

> emacs-version is "24.3.50.1" (yesterday's trunk) though this error was
> introduced in some earlier version.
>
> emacs -Q --debug-init
> M-: (window-state-get)
> see the error:
> ```
> Debugger entered--Lisp error: (error "Combination limit is meaningful for
> internal windows only")
>   window-combination-limit(#<window 0x11106b8 on *scratch*>)
>   window--state-get-1(#<window 0x11106b8 on *scratch*> nil)
>   window-state-get()
>   eval((window-state-get) nil)
>   eval-expression((window-state-get) nil)
>   call-interactively(eval-expression nil nil)
>   command-execute(eval-expression)
> ```

Thanks.  It's due to that change:

2013-03-19  Dmitry Antipov  <dmantipov <at> yandex.ru>

	* window.c (Fwindow_combination_limit, Fset_window_combination_limit):
	Signal error if window is not internal.  Adjust docstring.

You could try to work around it by using

            (combination-limit
	     . ,(unless (window-live-p window)
		  (window-combination-limit window)))

in `window-state-get' but I have no idea whether this would break any
things.  In any case it might be simpler to revert the change because
the original behavior was not broken IIUC.

martin

Message #11 received at 14527 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Dmitry Antipov <dmantipov <at> yandex.ru>, 14527 <at> debbugs.gnu.org,
 Constantin Kulikov <zxnotdead <at> gmail.com>
Subject: Re: bug#14527: 24.3.50; error in window-state-get
Date: Tue, 25 Jun 2013 17:48:25 +0200

I've installed Martin's fix** in revno:113172.  I'm leaving this bug
open until someone decides whether that is, indeed, the right fix or
there's something else to be done.

**The slightly different, but essentially identical change suggested
in http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01050.html

Message #14 received at 14527 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: Dmitry Antipov <dmantipov <at> yandex.ru>, 14527 <at> debbugs.gnu.org,
 Constantin Kulikov <zxnotdead <at> gmail.com>
Subject: Re: bug#14527: 24.3.50; error in window-state-get
Date: Sat, 04 Jan 2014 16:42:14 +0100

> I've installed Martin's fix** in revno:113172.  I'm leaving this bug
> open until someone decides whether that is, indeed, the right fix or
> there's something else to be done.

How about closing this now?

martin

Message #19 received at 14527-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Dmitry Antipov <dmantipov <at> yandex.ru>, 14527-done <at> debbugs.gnu.org,
 Constantin Kulikov <zxnotdead <at> gmail.com>
Subject: Re: bug#14527: 24.3.50; error in window-state-get
Date: Sat, 4 Jan 2014 21:28:29 +0100

> How about closing this now?

About time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.