GNU bug report logs - #14614
24.3.50; thing-at-point for symbol returns wrong value in makefile

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14614 in the body.
You can then email your comments to 14614 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; thing-at-point for symbol returns wrong value in makefile
Date: Thu, 13 Jun 2013 18:52:36 -0400

[Message part 1 (text/plain, inline)]

Let Makefile have contents:

  MY_MAKE_VAR=foo bar

Let makefile-symbol.el have contents:

  (defun myfun ()
    (interactive)
    (message "thing-at-point symbol is %s" (thing-at-point 'symbol)))

Run emacs -Q --load makefile-symbol.el Makefile

M-x myfun

Minibuffer indicates symbol at point is: MY_MAKE_VAR=foo

Expected: MY_MAKE_VAR

In GNU Emacs 24.3.50.6 (x86_64-unknown-linux-gnu, GTK+ Version 2.10.4)
 of 2013-05-23 on redacted
Windowing system distributor `The X.Org Foundation', version 11.0.70101000
System Description:    Red Hat Enterprise Linux Client release 5.4 (Tikanga)

Configured using:
 `configure --prefix=/redacted/user/boreilly/sw/emacs-install-trunk
 --with-gif=no'

Important settings:
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=none
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: GNUmakefile

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
M-x m y f u n <return> M-x r e p o r t <tab> <retu
rn>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Makefile has auto save data; consider M-x recover-this-file
thing-at-point symbol is MY_MAKE_VAR=foo

Load-path shadows:
None found.

Features:
(shadow sort nadvice gnus-util mail-extr emacsbug message format-spec
rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse
rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045
ietf-drums mm-util mail-prsvr mail-utils thingatpt make-mode time-date
tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
register page menu-bar rfn-eshadow timer select scroll-bar mouse
jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer loaddefs button faces cus-face macroexp files text-properties
overlay sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote make-network-process dbusbind
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty emacs)

[Message part 2 (text/html, inline)]

Message #8 received at 14614 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 14614 <at> debbugs.gnu.org
Subject: Re: bug#14614: 24.3.50;
 thing-at-point for symbol returns wrong value in makefile
Date: Fri, 14 Jun 2013 21:16:57 -0400

Barry OReilly wrote:

> Let Makefile have contents:
>
>   MY_MAKE_VAR=foo bar
[...]
> Minibuffer indicates symbol at point is: MY_MAKE_VAR=foo

The solution is to give ?= punctuation syntax in Makefile mode.
I can't see any obvious reason not to do that...?

Message #11 received at 14614 <at> debbugs.gnu.org (full text, mbox):

From: Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 14614 <at> debbugs.gnu.org
Subject: Re: bug#14614: 24.3.50; thing-at-point for symbol returns wrong value
 in makefile
Date: Fri, 14 Jun 2013 21:46:31 -0400

[Message part 1 (text/plain, inline)]

On Fri, Jun 14, 2013 at 9:16 PM, Glenn Morris <rgm <at> gnu.org> wrote:

> The solution is to give ?= punctuation syntax in Makefile mode.
> I can't see any obvious reason not to do that...?
>

Seems like a fine solution to me.

[Message part 2 (text/html, inline)]

Message #14 received at 14614 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Glenn Morris <rgm <at> gnu.org>
Cc: Barry OReilly <gundaetiapo <at> gmail.com>, 14614 <at> debbugs.gnu.org
Subject: Re: bug#14614: 24.3.50;
 thing-at-point for symbol returns wrong value in makefile
Date: Fri, 14 Jun 2013 21:50:51 -0400

>> Let Makefile have contents:
>> 
>> MY_MAKE_VAR=foo bar
> [...]
>> Minibuffer indicates symbol at point is: MY_MAKE_VAR=foo

> The solution is to give ?= punctuation syntax in Makefile mode.
> I can't see any obvious reason not to do that...?

Let's try it: either it'll "just work", or we'll get to learn why it's
not quite so simple.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.