GNU bug report logs - #14639
package-initialize not run

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14639 in the body.
You can then email your comments to 14639 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: package-initialize not run
Date: Mon, 17 Jun 2013 04:34:16 +0200

Package: emacs
Version: 24.3.50
X-Debbugs-CC: monnier <at> iro.umontreal.ca


package-initialize is not being run because the code to detect
description files does

  (when (let ((subdir (expand-file-name subdir dir)))
          (and (file-directory-p subdir)
               (file-exists-p
                (package--description-file subdir))))
    (throw 'package-dir-found t)))))))

but package--description-file does not return an absolute filename, so
file-exists-p fails.

Either this patch is needed,

=== modified file 'lisp/startup.el'
--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 02:21:06 +0000
@@ -1204,5 +1204,7 @@
                          (and (file-directory-p subdir)
                               (file-exists-p
-                               (package--description-file subdir))))
+                               (expand-file-name
+                                (package--description-file subdir)
+                                subdir))))
    (throw 'package-dir-found t)))))))
        (package-initialize))


or modifying package--description-file to return an absolute path.

Message #8 received at 14639 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: 14639 <at> debbugs.gnu.org
Subject: Re: bug#14639: package-initialize not run
Date: Mon, 17 Jun 2013 15:35:37 +0200

On Mon, Jun 17, 2013 at 4:34 AM, Juanma Barranquero <lekktu <at> gmail.com> wrote:

> or modifying package--description-file to return an absolute path.

--- lisp/startup.el 2013-06-15 15:36:11 +0000
+++ lisp/startup.el 2013-06-17 13:34:39 +0000
@@ -423,5 +423,6 @@

 (defun package--description-file (dir)
-  (concat (let ((subdir (file-name-nondirectory
+  (concat (file-name-as-directory dir)
+          (let ((subdir (file-name-nondirectory
                          (directory-file-name dir))))
             (if (string-match
"\\([^.].*?\\)-\\([0-9]+\\(?:[.][0-9]+\\|\\(?:pre\\|beta\\|alpha\\)[0-9]+\\)*\\)"
subdir)

Message #11 received at 14639 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14639 <at> debbugs.gnu.org
Subject: Re: bug#14639: package-initialize not run
Date: Mon, 17 Jun 2013 10:45:41 -0400

> -                               (package--description-file subdir))))
> +                               (expand-file-name
> +                                (package--description-file subdir)
> +                                subdir))))

Looks good (if you grep a bit, you'll see there are calls to
package--description-file which need a relative file name, because it's
used to find a file in a tar archive rather than in the file-system).


        Stefan

Message #16 received at 14639-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 14639-done <at> debbugs.gnu.org
Subject: Re: bug#14639: package-initialize not run
Date: Mon, 17 Jun 2013 17:36:17 +0200

On Mon, Jun 17, 2013 at 4:45 PM, Stefan Monnier
<monnier <at> iro.umontreal.ca> wrote:

> Looks good (if you grep a bit, you'll see there are calls to
> package--description-file which need a relative file name, because it's
> used to find a file in a tar archive rather than in the file-system).

I see.

Committed in revno:113021

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.