GNU bug report logs - #14755
Trunk bootstrap failure

Previous Next

Package: emacs;

Reported by: Angelo Graziosi <angelo.graziosi <at> alice.it>

Date: Sun, 30 Jun 2013 11:50:01 UTC

Severity: normal

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14755 in the body.
You can then email your comments to 14755 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14755; Package emacs. (Sun, 30 Jun 2013 11:50:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Angelo Graziosi <angelo.graziosi <at> alice.it>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 30 Jun 2013 11:50:03 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Trunk bootstrap failure
Date: Sun, 30 Jun 2013 13:49:05 +0200
As suspected (see this thread: 
http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html) the 
bootstrap failure of trunk r.113227 probably isn't platform dependent. 
Not only it fails on Cygwin but also on Kubuntu. You need only to 
bootstrap on a *clean clean* tree.

  Angelo




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14755; Package emacs. (Sun, 30 Jun 2013 12:49:02 GMT) Full text and rfc822 format available.

Message #8 received at 14755 <at> debbugs.gnu.org (full text, mbox):

From: Ari Roponen <ari.roponen <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: 14755 <at> debbugs.gnu.org
Subject: Re: bug#14755: Trunk bootstrap failure
Date: Sun, 30 Jun 2013 15:48:25 +0300
Angelo Graziosi <angelo.graziosi <at> alice.it> writes:

> As suspected (see this thread:
> http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html)
> the bootstrap failure of trunk r.113227 probably isn't platform
> dependent. Not only it fails on Cygwin but also on Kubuntu. You need
> only to bootstrap on a *clean clean* tree.
>
>   Angelo
>

I got the same failure, too. This commit seems to cause it:

  revno: 113220 [merge]
  committer: K. Handa <handa <at> gnu.org>
  branch nick: trunk
  timestamp: Sat 2013-06-29 12:46:39 +0900
  message:
    Add the coding system prefer-utf-8.
  
The above commit added this to `select-safe-coding-system':

  @@ -1029,6 +1029,11 @@
   	      (error "Save aborted"))))
         (when (and tick (/= tick (buffer-chars-modified-tick)))
   	(error "Canceled because the buffer was modified"))
  +      (if (and (eq (coding-system-type coding-system) 'undecided)
  +	       (coding-system-get coding-system :prefer-utf-8)
  +	       (< (- to from) (- (position-bytes to) (position-bytes from))))
  +	  (setq coding-system
  +		(coding-system-change-text-conversion coding-system 'utf-8)))
         coding-system)))

This code fails when the "Kludgy feature" mentioned in the docstring is
used: if FROM is a string, the string is the target text, and TO is
ignored.

The following patch seems to fix the problem. Remember to delete
src/bootstrap-emacs, so that the patched version is used.

=== modified file 'lisp/international/mule-cmds.el'
--- lisp/international/mule-cmds.el	2013-06-28 14:42:55 +0000
+++ lisp/international/mule-cmds.el	2013-06-30 06:07:06 +0000
@@ -1031,7 +1031,9 @@
 	(error "Canceled because the buffer was modified"))
       (if (and (eq (coding-system-type coding-system) 'undecided)
 	       (coding-system-get coding-system :prefer-utf-8)
-	       (< (- to from) (- (position-bytes to) (position-bytes from))))
+	       (if (stringp from)
+		   (multibyte-string-p from)
+		 (< (- to from) (- (position-bytes to) (position-bytes from)))))
 	  (setq coding-system
 		(coding-system-change-text-conversion coding-system 'utf-8)))
       coding-system)))

-- 
Ari Roponen




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14755; Package emacs. (Sun, 30 Jun 2013 14:04:02 GMT) Full text and rfc822 format available.

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#14755: Trunk bootstrap failure
Date: Sun, 30 Jun 2013 16:03:25 +0200
Il 30/06/2013 14.48, Ari Roponen ha scritto:
> Angelo Graziosi <angelo.graziosi <at> alice.it> writes:
>
>> As suspected (see this thread:
>> http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg01328.html)
>> the bootstrap failure of trunk r.113227 probably isn't platform
>> dependent. Not only it fails on Cygwin but also on Kubuntu. You need
>> only to bootstrap on a *clean clean* tree.

>
> I got the same failure, too. This commit seems to cause it:
>
>    revno: 113220 [merge]
>    committer: K. Handa <handa <at> gnu.org>
>    branch nick: trunk
>    timestamp: Sat 2013-06-29 12:46:39 +0900
>    message:
>      Add the coding system prefer-utf-8.

Confirmed. Rev. 113219 bootstraps while rev. 113220 doesn't...

>
> The following patch seems to fix the problem. Remember to delete
> src/bootstrap-emacs, so that the patched version is used.
>
> === modified file 'lisp/international/mule-cmds.el'
> --- lisp/international/mule-cmds.el	2013-06-28 14:42:55 +0000
> +++ lisp/international/mule-cmds.el	2013-06-30 06:07:06 +0000
> @@ -1031,7 +1031,9 @@
>   	(error "Canceled because the buffer was modified"))
>         (if (and (eq (coding-system-type coding-system) 'undecided)
>   	       (coding-system-get coding-system :prefer-utf-8)
> -	       (< (- to from) (- (position-bytes to) (position-bytes from))))
> +	       (if (stringp from)
> +		   (multibyte-string-p from)
> +		 (< (- to from) (- (position-bytes to) (position-bytes from)))))
>   	  (setq coding-system
>   		(coding-system-change-text-conversion coding-system 'utf-8)))
>         coding-system)))
>

indeed... with it I can bootstrap trunk!


Ciao,
 Angelo.





Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Sun, 30 Jun 2013 14:30:03 GMT) Full text and rfc822 format available.

Notification sent to Angelo Graziosi <angelo.graziosi <at> alice.it>:
bug acknowledged by developer. (Sun, 30 Jun 2013 14:30:06 GMT) Full text and rfc822 format available.

Message #16 received at 14755-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: ari.roponen <at> gmail.com, 14755-done <at> debbugs.gnu.org
Subject: Re: bug#14755: Trunk bootstrap failure
Date: Sun, 30 Jun 2013 17:29:10 +0300
> Date: Sun, 30 Jun 2013 16:03:25 +0200
> From: Angelo Graziosi <angelo.graziosi <at> alice.it>
> Cc: 14755 <at> debbugs.gnu.org
> 
> > I got the same failure, too. This commit seems to cause it:
> >
> >    revno: 113220 [merge]
> >    committer: K. Handa <handa <at> gnu.org>
> >    branch nick: trunk
> >    timestamp: Sat 2013-06-29 12:46:39 +0900
> >    message:
> >      Add the coding system prefer-utf-8.
> 
> Confirmed. Rev. 113219 bootstraps while rev. 113220 doesn't...

Should be fixed in trunk revision 113229.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14755; Package emacs. (Wed, 03 Jul 2013 13:40:02 GMT) Full text and rfc822 format available.

Message #19 received at 14755 <at> debbugs.gnu.org (full text, mbox):

From: Handa Kenichi <handa <at> gnu.org>
To: Ari Roponen <ari.roponen <at> gmail.com>
Cc: 14755 <at> debbugs.gnu.org, angelo.graziosi <at> alice.it
Subject: Re: bug#14755: Trunk bootstrap failure
Date: Wed, 03 Jul 2013 09:39:01 -0400
In article <8761wvvk6e.fsf <at> arirop.lan>, Ari Roponen <ari.roponen <at> gmail.com> writes:

> I got the same failure, too. This commit seems to cause it:

>   revno: 113220 [merge]
>   committer: K. Handa <handa <at> gnu.org>
>   branch nick: trunk
>   timestamp: Sat 2013-06-29 12:46:39 +0900
>   message:
>     Add the coding system prefer-utf-8.
  
> The above commit added this to `select-safe-coding-system':
[...]

> This code fails when the "Kludgy feature" mentioned in the docstring
> is
> used: if FROM is a string, the string is the target text, and TO is
> ignored.

Oops, my fault.

> The following patch seems to fix the problem. Remember to delete
> src/bootstrap-emacs, so that the patched version is used.

Yes, your patch is correct.  Thank you.

---
Kenichi Handa
handa <at> gnu.org

> === modified file 'lisp/international/mule-cmds.el'
> --- lisp/international/mule-cmds.el   2013-06-28 14:42:55 +0000
> +++ lisp/international/mule-cmds.el   2013-06-30 06:07:06 +0000
> @@ -1031,7 +1031,9 @@
>    (error "Canceled because the buffer was modified"))
>        (if (and (eq (coding-system-type coding-system) 'undecided)
>               (coding-system-get coding-system :prefer-utf-8)
> -                    (< (- to from) (- (position-bytes to)
> (position-bytes from))))
> +                      (if (stringp from)
> +                             (multibyte-string-p from)
> +                                                  (< (- to from) (-
> (position-bytes to) (position-bytes from)))))
>                   (setq coding-system
>                         (coding-system-change-text-conversion
> coding-system 'utf-8)))
>        coding-system)))

> -- 
> Ari Roponen




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 01 Aug 2013 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 10 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.