GNU bug report logs - #14757
24.3.50; cannot find README.W32 in MS Windows builds

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14757 in the body.
You can then email your comments to 14757 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Sun, 30 Jun 2013 11:32:06 -0700 (PDT)

I cannot find the file README.W32 in the MS Windows development binaries
distributed here:
https://www.dropbox.com/sh/zmxzw7pk2ml7qip/jS1Fuz1pZr
or here:
https://www.dropbox.com/sh/3pgcb3iiy8s9irl/c171Xhsd99

Dunno whether this is a problem generally or just with such builds.

According to info Eli sent me, the file exists in the repository but it
does not get copied into the installation tree, and that is a bug.


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2013-06-27 on ODIEONE
Bzr revision: 113205 dgutov <at> yandex.ru-20130627095155-f1lv1c7xf99g1sss
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 CFLAGS=-O0 -g3 LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'

Message #8 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 14757 <at> debbugs.gnu.org
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Sun, 30 Jun 2013 22:11:12 +0200

On Sun, Jun 30, 2013 at 8:32 PM, Drew Adams <drew.adams <at> oracle.com> wrote:

> According to info Eli sent me, the file exists in the repository but it
> does not get copied into the installation tree, and that is a bug.

That file talks about the old binary distribution and should be
updated to refer to the MSYS build.

Also, what is the right place to copy this? At the root of the
installation tree?

   J

Message #11 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14757 <at> debbugs.gnu.org, drew.adams <at> oracle.com
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Mon, 01 Jul 2013 05:43:01 +0300

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Sun, 30 Jun 2013 22:11:12 +0200
> Cc: 14757 <at> debbugs.gnu.org
> 
> Also, what is the right place to copy this? At the root of the
> installation tree?

I'd suggest in share/emacs/VERSION/, since that file can change from
version to version.

Message #14 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14757 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Mon, 1 Jul 2013 05:08:54 +0200

On Mon, Jul 1, 2013 at 4:43 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> I'd suggest in share/emacs/VERSION/, since that file can change from
> version to version.

OK, I'll fix this one (sooner or later) unless you beat me to it.

Message #17 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14757 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Fri, 07 Feb 2014 22:37:18 -0800

Juanma Barranquero <lekktu <at> gmail.com> writes:

> On Mon, Jul 1, 2013 at 4:43 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>> I'd suggest in share/emacs/VERSION/, since that file can change from
>> version to version.
>
> OK, I'll fix this one (sooner or later) unless you beat me to it.

Was this fixed in the MS Windows builds?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #20 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: lekktu <at> gmail.com, drew.adams <at> oracle.com, 14757 <at> debbugs.gnu.org
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Sat, 08 Feb 2014 11:35:21 +0200

> From: Lars Ingebrigtsen <larsi <at> gnus.org>
> Cc: Eli Zaretskii <eliz <at> gnu.org>,  14757 <at> debbugs.gnu.org,  Drew Adams <drew.adams <at> oracle.com>
> Date: Fri, 07 Feb 2014 22:37:18 -0800
> 
> Juanma Barranquero <lekktu <at> gmail.com> writes:
> 
> > On Mon, Jul 1, 2013 at 4:43 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >
> >> I'd suggest in share/emacs/VERSION/, since that file can change from
> >> version to version.
> >
> > OK, I'll fix this one (sooner or later) unless you beat me to it.
> 
> Was this fixed in the MS Windows builds?

No.

Message #23 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14757 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Sat, 8 Feb 2014 11:26:03 +0100

On Sat, Feb 8, 2014 at 10:35 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:

>> Was this fixed in the MS Windows builds?
>
> No.

My fault, I had forgotten. I'll take a stab at it later today.

    J

Message #26 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14757 <at> debbugs.gnu.org, larsi <at> gnus.org, drew.adams <at> oracle.com
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Sat, 08 Feb 2014 12:57:56 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Sat, 8 Feb 2014 11:26:03 +0100
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 14757 <at> debbugs.gnu.org, 
> 	Drew Adams <drew.adams <at> oracle.com>
> 
> On Sat, Feb 8, 2014 at 10:35 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> >> Was this fixed in the MS Windows builds?
> >
> > No.
> 
> My fault, I had forgotten. I'll take a stab at it later today.

Thanks.

Message #29 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14757 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Mon, 10 Feb 2014 18:49:45 +0100

Won't pretend that I know what I'm doing, but this patch seems to work
as expected.

Adding datarootdir to nt/Makefile.in is because adding datadir and not
datarootdir causes a warning when recreating the makefiles.

Comments?

=== modified file 'Makefile.in'
--- Makefile.in 2014-01-16 08:30:12 +0000
+++ Makefile.in 2014-02-10 16:29:22 +0000
@@ -510,6 +510,7 @@
   $(MAKE) install $(MFLAGS) prefix="${prefix}" \
     exec_prefix="${exec_prefix}" bindir="${bindir}" \
     libexecdir="${libexecdir}" archlibdir="${archlibdir}" \
+    datadir="${datadir}" \
     INSTALL_STRIP=${INSTALL_STRIP}

 ## In the share directory, we are deleting:

=== modified file 'nt/Makefile.in'
--- nt/Makefile.in 2014-01-01 07:43:34 +0000
+++ nt/Makefile.in 2014-02-10 17:32:34 +0000
@@ -56,6 +56,15 @@
 # to `../configure'.
 bindir=@bindir@

+# The root of the directory tree for read-only architecture-independent
+# data files.  ${datadir}, ${infodir} and ${mandir} are based on this.
+datarootdir=@datarootdir@
+
+# Where to install architecture-independent data files.  ${lispdir}
+# and ${etcdir} are subdirectories of this.  This is set with the
+# --datadir option to `../configure'.
+datadir=@datadir@
+
 # Where to install and expect executable files to be run by Emacs
 # rather than directly by users, and other architecture-dependent
 # data.  ${archlibdir} is usually below this.  This is set with the
@@ -95,6 +104,7 @@

 # ../configure figures out the correct values for these.
 INSTALL = @INSTALL@
+INSTALL_DATA = @INSTALL_DATA@
 INSTALL_PROGRAM = @INSTALL_PROGRAM@
 INSTALL_SCRIPT = @INSTALL_SCRIPT@
 # By default, we uphold the dignity of our programs.
@@ -161,8 +171,10 @@
  for file in ${INSTALLABLES} ; do \
   $(INSTALL_PROGRAM) $(INSTALL_STRIP) $${file}
"$(DESTDIR)${bindir}"/`echo $${file} | sed -e 's/${EXEEXT}$$//' -e
'$(TRANSFORM)'`${EXEEXT} ; \
  done
+ $(INSTALL_DATA) README.W32 "$(DESTDIR)${datadir}/emacs/$(version)"

 uninstall:
+ rm -f "$(DESTDIR)${datadir}/emacs/$(version)/README.W32"
  for file in ${INSTALLABLES}; do \
   rm -f "$(DESTDIR)${bindir}"/`echo $${file} | sed -e
's/${EXEEXT}$$//' -e '$(TRANSFORM)'`${EXEEXT} ; \
  done

Message #32 received at 14757 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14757 <at> debbugs.gnu.org, larsi <at> gnus.org, drew.adams <at> oracle.com
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Mon, 10 Feb 2014 20:16:38 +0200

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Mon, 10 Feb 2014 18:49:45 +0100
> Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 14757 <at> debbugs.gnu.org, 
> 	Drew Adams <drew.adams <at> oracle.com>
> 
> Won't pretend that I know what I'm doing, but this patch seems to work
> as expected.
> 
> Adding datarootdir to nt/Makefile.in is because adding datadir and not
> datarootdir causes a warning when recreating the makefiles.
> 
> Comments?

None from me.  I suggest to wait for a couple of days, and if nothing
pops up, please commit.

Thanks.

Message #37 received at 14757-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 14757-done <at> debbugs.gnu.org,
 Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#14757: 24.3.50; cannot find README.W32 in MS Windows builds
Date: Thu, 13 Feb 2014 04:21:37 +0100

On Mon, Feb 10, 2014 at 7:16 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> I suggest to wait for a couple of days, and if nothing
> pops up, please commit.

Committed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.