GNU bug report logs - #1482
cleanup: term.c dead code

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1482 in the body.
You can then email your comments to 1482 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: cleanup: term.c dead code
Date: Tue, 2 Dec 2008 22:33:45 -0800 (PST)

These terminal types are not supported by terminfo, so probably they are
long dead.  This code can be cleaned up whenever cleanups are allowed.

  /* Special handling for certain terminal types known to need it */

  if (!strcmp (terminal_type, "supdup"))
    {
      terminal->memory_below_frame = 1;
      tty->Wcm->cm_losewrap = 1;
    }
  if (!strncmp (terminal_type, "c10", 3)
      || !strcmp (terminal_type, "perq"))
    {

Message #8 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 1482 <at> debbugs.gnu.org
Subject: Re: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 15:00:46 +0200

Dan Nicolaescu <dann <at> ics.uci.edu> writes:

> These terminal types are not supported by terminfo, so probably they are
> long dead.  This code can be cleaned up whenever cleanups are allowed.
>
>   /* Special handling for certain terminal types known to need it */
>
>   if (!strcmp (terminal_type, "supdup"))
>     {
>       terminal->memory_below_frame = 1;
>       tty->Wcm->cm_losewrap = 1;
>     }
>   if (!strncmp (terminal_type, "c10", 3)
>       || !strcmp (terminal_type, "perq"))
>     {

I think cleaning up this now would be OK, but how do we know that these
three terminal types aren't supported?  Is there a list somewhere?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #11 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 1482 <at> debbugs.gnu.org
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 11:45:45 -0400

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Dan Nicolaescu <dann <at> ics.uci.edu> writes:
>
>> These terminal types are not supported by terminfo, so probably they are
>> long dead.  This code can be cleaned up whenever cleanups are allowed.
>>
>>   /* Special handling for certain terminal types known to need it */
>>
>>   if (!strcmp (terminal_type, "supdup"))
>>     {
>>       terminal->memory_below_frame = 1;
>>       tty->Wcm->cm_losewrap = 1;
>>     }
>>   if (!strncmp (terminal_type, "c10", 3)
>>       || !strcmp (terminal_type, "perq"))
>>     {
>
> I think cleaning up this now would be OK, but how do we know that these
> three terminal types aren't supported?  Is there a list somewhere?

/etc/termcap or the terminfo datatbase, none of them has these...

Message #14 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 1482 <at> debbugs.gnu.org
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 17:59:10 +0200

Dan Nicolaescu <dann <at> gnu.org> writes:

> /etc/termcap or the terminfo datatbase, none of them has these...

Could /etc/termcap files on other OSs have these?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Message #17 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Dan Nicolaescu <dann <at> ics.uci.edu>, 1482 <at> debbugs.gnu.org
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 18:26:48 +0200

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

>>   if (!strcmp (terminal_type, "supdup"))

RFC734

>>       || !strcmp (terminal_type, "perq"))

http://www.bitsavers.org/pdf/perq/PERQ_Brochure.pdf

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Message #20 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 1482 <at> debbugs.gnu.org
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 13:47:58 -0400

Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

> Dan Nicolaescu <dann <at> gnu.org> writes:
>
>> /etc/termcap or the terminfo datatbase, none of them has these...
>
> Could /etc/termcap files on other OSs have these?

Doubtful, AFAIK /etc/termcap on GNU/Linux is the most comprehensive of its kind.

Message #23 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Dan Nicolaescu <dann <at> gnu.org>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 1482 <at> debbugs.gnu.org
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Sun, 10 Jul 2011 13:57:54 -0400

Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:
>
>>>   if (!strcmp (terminal_type, "supdup"))
>
> RFC734
>
>>>       || !strcmp (terminal_type, "perq"))
>
> http://www.bitsavers.org/pdf/perq/PERQ_Brochure.pdf

Thank you!

Then it's quite safe to get rid of these.  They are so old and obscure
that they can't have a significant number of users (If they didn't make
it to /etc/termcap in the '80s/'90's it means they were not used much).  
We stopped supporting a lot of old systems a number of years ago, so IMO
these should go the same way.

Message #26 received at 1482 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Dan Nicolaescu <dann <at> gnu.org>
Cc: 1482 <at> debbugs.gnu.org, Andreas Schwab <schwab <at> linux-m68k.org>
Subject: Re: bug#1482: cleanup: term.c dead code
Date: Mon, 11 Jul 2011 17:16:50 +0200

Dan Nicolaescu <dann <at> gnu.org> writes:

> Then it's quite safe to get rid of these.  They are so old and obscure
> that they can't have a significant number of users (If they didn't make
> it to /etc/termcap in the '80s/'90's it means they were not used much).  
> We stopped supporting a lot of old systems a number of years ago, so IMO
> these should go the same way.

I agree.  I've now removed the code in question.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.