GNU bug report logs - #14901
Trunk bootstrap broken

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14901 in the body.
You can then email your comments to 14901 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: bug-emacs <bug-gnu-emacs <at> gnu.org>
Cc: Juanma Barranquero <lekktu <at> gmail.com>
Subject: Trunk bootstrap broken
Date: Thu, 18 Jul 2013 22:07:50 +0200

At least on Cygwin, the rev. 113450 fails to bootstrap:

[...]
gcc -std=gnu99 -c  -Demacs  -I. -I/work/emacs/src  -I../lib 
-I/work/emacs/src/../lib    -D_REENTRANT -I/usr/include/gtk-3.0 
-I/usr/include/atk-1.0 -I/usr/include/at-spi2-atk/2.0 
-I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ 
-I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/pixman-1 
-I/usr/include/libpng15   -DGDK_DISABLE_DEPRECATION_WARNINGS 
-DGLIB_DISABLE_DEPRECATION_WARNINGS -I/usr/include/freetype2 
-D_REENTRANT -I/usr/include/librsvg-2.0 -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include -I/usr/include/gdk-pixbuf-2.0 
-I/usr/include/cairo -I/usr/include/libpng15 -I/usr/include/pixman-1 
-I/usr/include/freetype2   -fopenmp -I/usr/include/ImageMagick 
-I/usr/include/libxml2   -I/usr/include/dbus-1.0 
-I/usr/lib/dbus-1.0/include      -D_REENTRANT -I/usr/include/glib-2.0 
-I/usr/lib/glib-2.0/include   -D_REENTRANT -I/usr/include/gconf/2 
-I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include 
-I/usr/include/freetype2     -I/usr/include/freetype2    -MMD -MF 
deps/keyboard.d -MP  -I/usr/include/p11-kit-1   -D_REENTRANT 
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include      -g3 -O2 
/work/emacs/src/keyboard.c
/work/emacs/src/keyboard.c: In function ‘kbd_buffer_get_event’:
/work/emacs/src/keyboard.c:4079:59: error: ‘struct x_display_info’ has 
no member named ‘output_data’
/work/emacs/src/keyboard.c:4080:23: error: ‘struct x_display_info’ has 
no member named ‘output_data’
Makefile:356: recipe for target `keyboard.o' failed
make[2]: *** [keyboard.o] Error 1
make[2]: uscita dalla directory "/work/emacs/Work/src"
Makefile:381: recipe for target `src' failed
make[1]: *** [src] Error 2
make[1]: uscita dalla directory "/work/emacs/Work"
Makefile:992: recipe for target `bootstrap' failed
make: *** [bootstrap] Error 2

I guess these changes are the culprit:

=========================
2013-07-18  Juanma Barranquero

        * keyboard.c (kbd_buffer_get_event):
        * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT 
changes to W32.
        Followup to revno:113431.
=========================


(notice that rev. 113449 bootstraps fine on Kubuntu...)


Ciao,
 Angelo.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: Trunk bootstrap broken
Date: Thu, 18 Jul 2013 22:24:35 +0200

On Thu, Jul 18, 2013 at 10:07 PM, Angelo Graziosi
<angelo.graziosi <at> alice.it> wrote:

> I guess these changes are the culprit:
>
> =========================
> 2013-07-18  Juanma Barranquero
>
>         * keyboard.c (kbd_buffer_get_event):
>         * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to
> W32.
>         Followup to revno:113431.
> =========================

Does it work with the following patch?


=== modified file 'src/keyboard.c'
--- src/keyboard.c 2013-07-18 16:50:05 +0000
+++ src/keyboard.c 2013-07-18 20:22:48 +0000
@@ -4066,7 +4066,7 @@
         }
       else if (event->kind == FOCUS_OUT_EVENT)
         {
-#if defined (HAVE_NS) || defined (HAVE_X11) || defined (WINDOWSNT)
+#if defined (HAVE_NS) || defined (HAVE_X11) || defined (HAVE_NTGUI)

 #ifdef HAVE_NS
           struct ns_display_info *di;
@@ -4080,7 +4080,7 @@
             focused = FRAME_X_DISPLAY_INFO (di)->x_highlight_frame = 0;

           if (! focused) obj = make_lispy_focus_out (frame);
-#endif /* HAVE_NS || HAVE_X11 || WINDOWSNT */
+#endif /* HAVE_NS || HAVE_X11 || HAVE_NTGUI */

           kbd_fetch_ptr = event + 1;
         }

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: Trunk bootstrap broken
Date: Thu, 18 Jul 2013 23:09:36 +0200

Il 18/07/2013 22.24, Juanma Barranquero ha scritto:
> On Thu, Jul 18, 2013 at 10:07 PM, Angelo Graziosi
> <angelo.graziosi <at> alice.it> wrote:
>
>> I guess these changes are the culprit:
>>
>> =========================
>> 2013-07-18  Juanma Barranquero
>>
>>          * keyboard.c (kbd_buffer_get_event):
>>          * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to
>> W32.
>>          Followup to revno:113431.
>> =========================
>
> Does it work with the following patch?
>
>
> === modified file 'src/keyboard.c'
> --- src/keyboard.c 2013-07-18 16:50:05 +0000
> +++ src/keyboard.c 2013-07-18 20:22:48 +0000
> @@ -4066,7 +4066,7 @@
>           }
>         else if (event->kind == FOCUS_OUT_EVENT)
>           {
> -#if defined (HAVE_NS) || defined (HAVE_X11) || defined (WINDOWSNT)
> +#if defined (HAVE_NS) || defined (HAVE_X11) || defined (HAVE_NTGUI)
>
>   #ifdef HAVE_NS
>             struct ns_display_info *di;
> @@ -4080,7 +4080,7 @@
>               focused = FRAME_X_DISPLAY_INFO (di)->x_highlight_frame = 0;
>
>             if (! focused) obj = make_lispy_focus_out (frame);
> -#endif /* HAVE_NS || HAVE_X11 || WINDOWSNT */
> +#endif /* HAVE_NS || HAVE_X11 || HAVE_NTGUI */
>
>             kbd_fetch_ptr = event + 1;
>           }
>

No, it fails...

Sincerely, I expected the failure. Why changing WINDOWSNT with 
HAVE_NTGUI should work? Cygwin, ideally, should work as on GNU/Linux. 
Here I do GTK builds.

BTW, rev. 113449 bootstraps fine on Cygwin too.

Ciao,
 Angelo.

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 00:19:14 +0200

After Paul's changes, rev. 113451 bootstraps... Thanks.

Ciao,
 Angelo.

Message #19 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: 14901 <at> debbugs.gnu.org
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 01:02:50 +0200

On Thu, Jul 18, 2013 at 11:09 PM, Angelo Graziosi
<angelo.graziosi <at> alice.it> wrote:

> Sincerely, I expected the failure. Why changing WINDOWSNT with HAVE_NTGUI
> should work?

Because the point of using HAVE_NTGUI was *excluding* Cygwin. If
Cygwin already satisfies HAVE_X11, why would it fail?

   J

Message #22 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: 14901 <at> debbugs.gnu.org
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 01:13:48 +0200

On Thu, Jul 18, 2013 at 11:09 PM, Angelo Graziosi
<angelo.graziosi <at> alice.it> wrote:

> BTW, rev. 113449 bootstraps fine on Cygwin too.

The only part of revno:113450 relevant to this bug is changing di to
FRAME_X_DISPLAY_INFO (di), and that should work on Cygwin. Please, try
to find why it doesn't.

Thanks,

   Juanma

Message #25 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: 14901 <at> debbugs.gnu.org
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 01:17:13 +0200

> After Paul's changes, rev. 113451 bootstraps... Thanks.

Yes, I just saw. Wonderful.

But in ay case, could you please test that it works by changing WINDOWSNT
to HAVE_NTGUI in that #ifdef? I think it's the right test anyway.

Thanks,

   Juanma

Message #28 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 11:54:00 +0200

Il 19/07/2013 1.17, Juanma Barranquero ha scritto:
>> After Paul's changes, rev. 113451 bootstraps... Thanks.
>
> Yes, I just saw. Wonderful.
>
> But in ay case, could you please test that it works by changing WINDOWSNT
> to HAVE_NTGUI in that #ifdef? I think it's the right test anyway.
>

Do you mean this patch?

--- work/emacs/src/keyboard.c~	2013-07-18 23:32:06.000000000 +0200
+++ work/emacs/src/keyboard.c	2013-07-19 11:32:26.125000000 +0200
@@ -4068,7 +4068,7 @@
         {
 #if defined HAVE_X11 || defined HAVE_NS
 # define DISPLAY_LIST_INFO(di) (di)
-#elif defined WINDOWSNT
+#elif defined HAVE_NTGUI
 # define DISPLAY_LIST_INFO(di) FRAME_X_DISPLAY_INFO (di)
 #endif
 #ifdef DISPLAY_LIST_INFO


It works.. or at least it passes the critical point (I haven't completed 
the build,, here it take > 30 min.)


Ciao,
 Angelo.

Message #31 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 11:58:39 +0200

On Fri, Jul 19, 2013 at 11:54 AM, Angelo Graziosi
<angelo.graziosi <at> alice.it> wrote:

> Do you mean this patch?
>
> -#elif defined WINDOWSNT
> +#elif defined HAVE_NTGUI

Yes.

> It works.. or at least it passes the critical point (I haven't completed the
> build,, here it take > 30 min.)

OK, I'll change it later if you don't report back any trouble.

Thanks,

   Juanma

Message #34 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juanma Barranquero <lekktu <at> gmail.com>
Cc: 14901 <at> debbugs.gnu.org, angelo.graziosi <at> alice.it
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 14:02:07 +0300

> From: Juanma Barranquero <lekktu <at> gmail.com>
> Date: Fri, 19 Jul 2013 01:17:13 +0200
> Cc: 14901 <at> debbugs.gnu.org
> 
> > After Paul's changes, rev. 113451 bootstraps... Thanks.
> 
> Yes, I just saw. Wonderful.

Not so wonderful.  (Doesn't anyone watch compiler warnings these
days?)  Using this:

    struct x_display_info *di;

on anything but X11 is a no-no, since that struct is not portable.
The portable way is to use Display_Info, which a type defined on any
platform we support (including TTYs and even MS-DOS).  No need for the
DISPLAY_INFO macro, either.

> But in ay case, could you please test that it works by changing WINDOWSNT
> to HAVE_NTGUI in that #ifdef? I think it's the right test anyway.

This whole rigmarole with multiple HAVE_* is not needed at all, since
HAVE_WINDOW_SYSTEM captures all of them.

I fixed both of the above in trunk revision 113456.  I've verified
this to compile on GNU/Linux and on MS-Windows, I expect the NS port
will build without any problems, too.

Message #37 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 14901 <at> debbugs.gnu.org, Angelo Graziosi <angelo.graziosi <at> alice.it>
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 13:38:52 +0200

On Fri, Jul 19, 2013 at 1:02 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:

> Not so wonderful.

I mean't "wonderful that the Cygwin port is not broken".

>  (Doesn't anyone watch compiler warnings these days?)

I compile with full warnings, so unfortunately that means that there
are almost too many warnings. So I check the warnings mostly on
bootstrap (where I compare the previous log with the latest one to
detect any new warning).

> Using this:
>
>     struct x_display_info *di;
>
> on anything but X11 is a no-no, since that struct is not portable.
> The portable way is to use Display_Info, which a type defined on any
> platform we support (including TTYs and even MS-DOS).  No need for the
> DISPLAY_INFO macro, either.

Cool, thanks.

> This whole rigmarole with multiple HAVE_* is not needed at all, since
> HAVE_WINDOW_SYSTEM captures all of them.

We have tons of macros, and only a few of them are described in
admin/CPP-DEFINES.

> I fixed both of the above in trunk revision 113456.  I've verified
> this to compile on GNU/Linux and on MS-Windows, I expect the NS port
> will build without any problems, too.

Thanks.

Message #40 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Angelo Graziosi <angelo.graziosi <at> alice.it>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 14:18:48 +0200

Il 19/07/2013 13.02, Eli Zaretskii ha scritto:
>
> I fixed both of the above in trunk revision 113456.  I've verified
> this to compile on GNU/Linux and on MS-Windows, I expect the NS port
> will build without any problems, too.
>

On Cygwin, it bootstraps fine too... :-)

Ciao,
Angelo.

Message #43 received at 14901 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: Juanma Barranquero <lekktu <at> gmail.com>, 14901 <at> debbugs.gnu.org
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Thu, 18 Jul 2013 23:45:37 +0200

Hello.

18 jul 2013 kl. 23:09 skrev Angelo Graziosi <angelo.graziosi <at> alice.it>:

> Il 18/07/2013 22.24, Juanma Barranquero ha scritto:
>> On Thu, Jul 18, 2013 at 10:07 PM, Angelo Graziosi
>> <angelo.graziosi <at> alice.it> wrote:
>> 
>>> I guess these changes are the culprit:
>>> 
>>> =========================
>>> 2013-07-18  Juanma Barranquero
>>> 
>>>         * keyboard.c (kbd_buffer_get_event):
>>>         * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to
>>> W32.
>>>         Followup to revno:113431.
>>> =========================
>> 
>> Does it work with the following patch?
>> 
>> 
>> === modified file 'src/keyboard.c'
>> --- src/keyboard.c 2013-07-18 16:50:05 +0000
>> +++ src/keyboard.c 2013-07-18 20:22:48 +0000
>> @@ -4066,7 +4066,7 @@
>>          }
>>        else if (event->kind == FOCUS_OUT_EVENT)
>>          {
>> -#if defined (HAVE_NS) || defined (HAVE_X11) || defined (WINDOWSNT)
>> +#if defined (HAVE_NS) || defined (HAVE_X11) || defined (HAVE_NTGUI)
>> 
>>  #ifdef HAVE_NS
>>            struct ns_display_info *di;
>> @@ -4080,7 +4080,7 @@
>>              focused = FRAME_X_DISPLAY_INFO (di)->x_highlight_frame = 0;
>> 
>>            if (! focused) obj = make_lispy_focus_out (frame);
>> -#endif /* HAVE_NS || HAVE_X11 || WINDOWSNT */
>> +#endif /* HAVE_NS || HAVE_X11 || HAVE_NTGUI */
>> 
>>            kbd_fetch_ptr = event + 1;
>>          }
>> 
> 
> No, it fails...
> 
> Sincerely, I expected the failure. Why changing WINDOWSNT with HAVE_NTGUI should work? Cygwin, ideally, should work as on GNU/Linux. Here I do GTK builds.
> 
> BTW, rev. 113449 bootstraps fine on Cygwin too.

FWIW, trunk compiles fine on GNU/Linux (with Gtk+ 3 on Fedora 18).

	Jan D.

Message #46 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Angelo Graziosi <angelo.graziosi <at> alice.it>
Cc: lekktu <at> gmail.com, bug-gnu-emacs <at> gnu.org
Subject: Re: bug#14901: Trunk bootstrap broken
Date: Fri, 19 Jul 2013 16:45:00 +0300

> Date: Fri, 19 Jul 2013 14:18:48 +0200
> From: Angelo Graziosi <angelo.graziosi <at> alice.it>
> CC: Juanma Barranquero <lekktu <at> gmail.com>, 
>  bug-emacs <bug-gnu-emacs <at> gnu.org>
> 
> Il 19/07/2013 13.02, Eli Zaretskii ha scritto:
> >
> > I fixed both of the above in trunk revision 113456.  I've verified
> > this to compile on GNU/Linux and on MS-Windows, I expect the NS port
> > will build without any problems, too.
> >
> 
> On Cygwin, it bootstraps fine too... :-)

Thanks for testing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.