GNU bug report logs - #14909
Subject: 24.3; imag-dired key-bindings not working

Previous Next

Package: emacs;

Reported by: dieter <at> duenenhof-wilhelm.de

Date: Fri, 19 Jul 2013 15:28:02 UTC

Severity: normal

Merged with 15884

Found in version 24.3

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14909 in the body.
You can then email your comments to 14909 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14909; Package emacs. (Fri, 19 Jul 2013 15:28:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to dieter <at> duenenhof-wilhelm.de:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 19 Jul 2013 15:28:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Dieter Wilhelm, H." <dieter <at> duenenhof-wilhelm.de>
To: bug-gnu-emacs <at> gnu.org
Subject: Subject: 24.3; imag-dired key-bindings not working
Date: Fri, 19 Jul 2013 17:26:53 +0200
This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org.  Please check that
the From: line contains a valid email address.  After a delay of up
to one day, you should receive an acknowledgment at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug.  If you can, give a recipe
starting from `emacs -Q':

Hi,

please open Emacs with -Q and load a directory with image-dired, then
display an original file with RET.  After this basically all the
movement keybindings in the *image-dired* buffer are not working any
longer.

Thanks for tumme

    Dieter

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/appl/emacs-24.3/etc/DEBUG.


In GNU Emacs 24.3.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.18.9)
 of 2013-03-19 on sbav106x.vs.de.conti.de
Windowing system distributor `Red Hat, Inc.', version 11.0.11006000
System Description:    Red Hat Enterprise Linux Server release 6.3 (Santiago)

Important settings:
  value of $LANG: en_GB.utf8
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: image-dired-thumbnail

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
<kp-begin> <kp-begin> <kp-begin> <kp-begin> <kp-up>
<kp-up> <kp-up> <kp-down> <kp-down> <kp-down> <kp-begin>
<kp-begin> <kp-begin> <kp-begin> <kp-begin> <kp-begin>
<kp-begin> <kp-down> <kp-begin> C-n C-p C-p C-p C-p
C-p C-a C-a C-a <up> <up> <up> <left> <left> <left>
<up> <up> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1> <mouse-1>
<mouse-1> <mouse-1> <down-mouse-1> <mouse-1> <down-mouse-4>
<mouse-4> <double-down-mouse-4> <double-mouse-4> <triple-down-mouse-4>
<triple-mouse-4> <triple-down-mouse-4> <triple-mouse-4>
<down-mouse-1> <mouse-1> <down-mouse-1> <mouse-1> <down-mouse-4>
<mouse-4> <down-mouse-4> <mouse-4> <double-down-mouse-4>
<double-mouse-4> <triple-down-mouse-4> <triple-mouse-4>
<down-mouse-4> <mouse-4> <down-mouse-1> <mouse-1> <down-mouse-4>
<mouse-4> <double-down-mouse-4> <double-mouse-4> <triple-down-mouse-4>
<triple-mouse-4> <down-mouse-4> <mouse-4> <down-mouse-4>
<mouse-4> <down-mouse-1> <mouse-1> <down-mouse-4> <mouse-4>
<double-down-mouse-4> <double-mouse-4> <triple-down-mouse-4>
<triple-mouse-4> <triple-down-mouse-4> <triple-mouse-4>
<triple-down-mouse-4> <triple-mouse-4> <triple-down-mouse-4>
<triple-mouse-4> <triple-down-mouse-4> <triple-mouse-4>
C-b C-b C-a C-p C-p C-p C-n C-n C-p C-f C-f C-h m C-M-v
C-v C-v C-v C-v C-v C-v C-v C-v C-v M-x M-p <return>
<return> y C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f
C-f C-f C-f C-f C-f C-f C-f C-f C-f C-b C-b C-b C-b
C-b C-b C-b C-b C-b C-b C-f C-f C-f C-f C-f <return>
C-b C-b C-b C-f C-f C-b C-b C-b C-b C-b C-b <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<menu-bar> <help-menu> <send-emacs-bug-report>

Recent messages:

zkv4d045g0: IMG_0968.JPG ():

zkv4d045g0: IMG_0969.JPG ():

zkv4d045g0: IMG_0970.JPG ():

zkv4d045g0: IMG_0971.JPG ():

zkv4d045g0: IMG_0972.JPG ():
image-dired-forward-image: At last image [2 times]

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils help-fns image-file image-dired format-spec novice dired
help-mode easymenu time-date tooltip ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow
timer select scroll-bar mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces
cus-face macroexp files text-properties overlay sha1 md5 base64 format
env code-pages mule custom widget hashtable-print-readable backquote
make-network-process dynamic-setting font-render-setting move-toolbar
gtk x-toolkit x multi-tty emacs)

--
    Best wishes

    H. Dieter Wilhelm
    Schwalbach, Germany




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14909; Package emacs. (Fri, 19 Jul 2013 20:24:01 GMT) Full text and rfc822 format available.

Message #8 received at 14909 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: dieter <at> duenenhof-wilhelm.de
Cc: 14909 <at> debbugs.gnu.org
Subject: Re: bug#14909: Subject: 24.3; imag-dired key-bindings not working
Date: Fri, 19 Jul 2013 16:23:47 -0400
Thanks, this should fix it:

*** lisp/image-dired.el	2013-01-01 09:11:05 +0000
--- lisp/image-dired.el	2013-07-19 20:21:46 +0000
***************
*** 1035,1049 ****
  See documentation for `image-dired-toggle-movement-tracking'.
  Interactive use only useful if `image-dired-track-movement' is nil."
    (interactive)
!   (let ((old-buf (current-buffer))
          (dired-buf (image-dired-associated-dired-buffer))
!         (file-name (image-dired-original-file-name)))
      (when (and (buffer-live-p dired-buf) file-name)
        (set-buffer dired-buf)
        (if (not (dired-goto-file file-name))
            (message "Could not track file")
!         (set-window-point
!          (image-dired-get-buffer-window dired-buf) (point)))
        (set-buffer old-buf))))
  
  (defun image-dired-toggle-movement-tracking ()
--- 1035,1049 ----
  See documentation for `image-dired-toggle-movement-tracking'.
  Interactive use only useful if `image-dired-track-movement' is nil."
    (interactive)
!   (let* ((old-buf (current-buffer))
           (dired-buf (image-dired-associated-dired-buffer))
!          (file-name (image-dired-original-file-name))
!          (window (image-dired-get-buffer-window dired-buf)))
      (when (and (buffer-live-p dired-buf) file-name)
        (set-buffer dired-buf)
        (if (not (dired-goto-file file-name))
            (message "Could not track file")
!         (if window (set-window-point window (point))))
        (set-buffer old-buf))))
  
  (defun image-dired-toggle-movement-tracking ()





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14909; Package emacs. (Sat, 20 Jul 2013 08:33:02 GMT) Full text and rfc822 format available.

Message #11 received at 14909 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: dieter <at> duenenhof-wilhelm.de, 14909 <at> debbugs.gnu.org
Subject: Re: bug#14909: Subject: 24.3; imag-dired key-bindings not working
Date: Sat, 20 Jul 2013 04:32:55 -0400
> !   (let* ((old-buf (current-buffer))
>            (dired-buf (image-dired-associated-dired-buffer))
> !          (file-name (image-dired-original-file-name))
> !          (window (image-dired-get-buffer-window dired-buf)))
>       (when (and (buffer-live-p dired-buf) file-name)
>         (set-buffer dired-buf)
>         (if (not (dired-goto-file file-name))
>             (message "Could not track file")
> !         (if window (set-window-point window (point))))
>         (set-buffer old-buf))))

I see this code could use with-current-buffer.


        Stefan




bug marked as fixed in version 24.4, send any further explanations to 14909 <at> debbugs.gnu.org and dieter <at> duenenhof-wilhelm.de Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Sat, 20 Jul 2013 19:19:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 18 Aug 2013 11:24:03 GMT) Full text and rfc822 format available.

bug unarchived. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 13 Nov 2013 16:56:01 GMT) Full text and rfc822 format available.

Forcibly Merged 14909 15884. Request was from Glenn Morris <rgm <at> gnu.org> to control <at> debbugs.gnu.org. (Wed, 13 Nov 2013 16:56:01 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 12 Dec 2013 12:24:03 GMT) Full text and rfc822 format available.

This bug report was last modified 10 years and 109 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.