GNU bug report logs -
#15138
Font rendering error on OSX
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15138 in the body.
You can then email your comments to 15138 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 20 Aug 2013 06:32:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Michael Toomim <toomim <at> cs.washington.edu>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Tue, 20 Aug 2013 06:32:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
- too small
- too tall (forcing an increase in line-height of a pixel or two)
The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
[Message part 2 (text/html, inline)]
[PastedGraphic-21.png (image/png, inline)]
[PastedGraphic-19.png (image/png, inline)]
[PastedGraphic-20.png (image/png, inline)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 20 Aug 2013 06:44:02 GMT)
Full text and
rfc822 format available.
Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):
A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
> - too small
> - too tall (forcing an increase in line-height of a pixel or two)
>
> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>
> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>
> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>
>
> <PastedGraphic-21.png>
> <PastedGraphic-19.png>
> <PastedGraphic-20.png>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs,ns
.
(Mon, 26 Aug 2013 16:15:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>
> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>
It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
Jan D.
> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>
>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>> - too small
>> - too tall (forcing an increase in line-height of a pixel or two)
>>
>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>
>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>
>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>
>>
>> <PastedGraphic-21.png>
>> <PastedGraphic-19.png>
>> <PastedGraphic-20.png>
>
>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs,ns
.
(Tue, 27 Aug 2013 16:00:04 GMT)
Full text and
rfc822 format available.
Message #14 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
This seems to be in the general font code. It does not even try to check if that glyph is present in the current font (it is), but instead asks for a font with script symbol. The logic seems strange to me.
Jan D.
26 aug 2013 kl. 18:14 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
> Hello.
>
> 20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>
>> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>>
>> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>
> It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
>
> Jan D.
>
>> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>>
>>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>>> - too small
>>> - too tall (forcing an increase in line-height of a pixel or two)
>>>
>>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>>
>>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>>
>>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>>
>>>
>>> <PastedGraphic-21.png>
>>> <PastedGraphic-19.png>
>>> <PastedGraphic-20.png>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs,ns
.
(Tue, 27 Aug 2013 19:09:02 GMT)
Full text and
rfc822 format available.
Message #17 received at 15138 <at> debbugs.gnu.org (full text, mbox):
That sounds very strange indeed! Thank you very much for investigating this. Where in the source are you looking?
On Aug 27, 2013, at 8:59 AM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
> Hello.
>
> This seems to be in the general font code. It does not even try to check if that glyph is present in the current font (it is), but instead asks for a font with script symbol. The logic seems strange to me.
>
> Jan D.
>
> 26 aug 2013 kl. 18:14 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
>
>> Hello.
>>
>> 20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>>
>>> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>>>
>>> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>>
>> It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
>>
>> Jan D.
>>
>>> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>>>
>>>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>>>> - too small
>>>> - too tall (forcing an increase in line-height of a pixel or two)
>>>>
>>>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>>>
>>>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>>>
>>>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>>>
>>>>
>>>> <PastedGraphic-21.png>
>>>> <PastedGraphic-19.png>
>>>> <PastedGraphic-20.png>
>>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Wed, 28 Aug 2013 04:56:02 GMT)
Full text and
rfc822 format available.
Message #20 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hi.
27 aug 2013 kl. 21:08 skrev Michael Toomim <toomim <at> cs.washington.edu>:
> That sounds very strange indeed! Thank you very much for investigating this. Where in the source are you looking?
>
Just tracing calls and parameters to functions in nsfont_driver in nsfont.m.
Jan D.
> On Aug 27, 2013, at 8:59 AM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
>
>> Hello.
>>
>> This seems to be in the general font code. It does not even try to check if that glyph is present in the current font (it is), but instead asks for a font with script symbol. The logic seems strange to me.
>>
>> Jan D.
>>
>> 26 aug 2013 kl. 18:14 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
>>
>>> Hello.
>>>
>>> 20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>>>
>>>> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>>>>
>>>> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>>>
>>> It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
>>>
>>> Jan D.
>>>
>>>> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>>>>
>>>>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>>>>> - too small
>>>>> - too tall (forcing an increase in line-height of a pixel or two)
>>>>>
>>>>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>>>>
>>>>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>>>>
>>>>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>>>>
>>>>>
>>>>> <PastedGraphic-21.png>
>>>>> <PastedGraphic-19.png>
>>>>> <PastedGraphic-20.png>
>>>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Sun, 01 Sep 2013 10:01:01 GMT)
Full text and
rfc822 format available.
Message #23 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
I've made a fix for this in the trunk, please try it.
Thanks,
Jan D.
28 aug 2013 kl. 06:55 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
> Hi.
>
> 27 aug 2013 kl. 21:08 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>
>> That sounds very strange indeed! Thank you very much for investigating this. Where in the source are you looking?
>>
>
> Just tracing calls and parameters to functions in nsfont_driver in nsfont.m.
>
> Jan D.
>
>> On Aug 27, 2013, at 8:59 AM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
>>
>>> Hello.
>>>
>>> This seems to be in the general font code. It does not even try to check if that glyph is present in the current font (it is), but instead asks for a font with script symbol. The logic seems strange to me.
>>>
>>> Jan D.
>>>
>>> 26 aug 2013 kl. 18:14 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
>>>
>>>> Hello.
>>>>
>>>> 20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>>>>
>>>>> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>>>>>
>>>>> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>>>>
>>>> It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
>>>>
>>>> Jan D.
>>>>
>>>>> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>>>>>
>>>>>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>>>>>> - too small
>>>>>> - too tall (forcing an increase in line-height of a pixel or two)
>>>>>>
>>>>>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>>>>>
>>>>>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>>>>>
>>>>>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>>>>>
>>>>>>
>>>>>> <PastedGraphic-21.png>
>>>>>> <PastedGraphic-19.png>
>>>>>> <PastedGraphic-20.png>
>>>>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Sun, 01 Sep 2013 18:52:02 GMT)
Full text and
rfc822 format available.
Message #26 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Fantastic! I will try it out and let you know.
On Sep 1, 2013, at 3:00 AM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
> Hello.
>
> I've made a fix for this in the trunk, please try it.
>
> Thanks,
>
> Jan D.
>
> 28 aug 2013 kl. 06:55 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
>
>> Hi.
>>
>> 27 aug 2013 kl. 21:08 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>>
>>> That sounds very strange indeed! Thank you very much for investigating this. Where in the source are you looking?
>>>
>>
>> Just tracing calls and parameters to functions in nsfont_driver in nsfont.m.
>>
>> Jan D.
>>
>>> On Aug 27, 2013, at 8:59 AM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
>>>
>>>> Hello.
>>>>
>>>> This seems to be in the general font code. It does not even try to check if that glyph is present in the current font (it is), but instead asks for a font with script symbol. The logic seems strange to me.
>>>>
>>>> Jan D.
>>>>
>>>> 26 aug 2013 kl. 18:14 skrev Jan Djärv <jan.h.d <at> swipnet.se>:
>>>>
>>>>> Hello.
>>>>>
>>>>> 20 aug 2013 kl. 04:44 skrev Michael Toomim <toomim <at> cs.washington.edu>:
>>>>>
>>>>>> A simple way to reproduce this bug is to press option-8 (inserts a bullet on a mac) anywhere in a text buffer. You can see the line grow taller.
>>>>>>
>>>>>> In default OSX settings, you'll need to (setq ns-alternate-modifier 'none) before you can use option-8.
>>>>>
>>>>> It is strictly not a font rendering error, but a font selection error. The bullet is from a different font than the surrounding text.
>>>>>
>>>>> Jan D.
>>>>>
>>>>>> On Aug 19, 2013, at 7:37 PM, Michael Toomim <toomim <at> gmail.com> wrote:
>>>>>>
>>>>>>> Some extended characters are rendered incorrectly in the new Cocoa 24.3 emacs on OSX. They are rendered:
>>>>>>> - too small
>>>>>>> - too tall (forcing an increase in line-height of a pixel or two)
>>>>>>>
>>>>>>> The result is that some lines are too tall, and monospace layouts (like ASCII art) lose alignment.
>>>>>>>
>>>>>>> Here is an example in three screenshots, where the "•" bullet character is rendered incorrectly. The first screenshot shows the bug on the current release. You can see that the center line takes up too much vertical space, and not enough horizontal space. This is a monospace font (apple monaco).
>>>>>>>
>>>>>>> The second and third show the correct rendering. The second is an older emacs build I have that rendered text with Carbon. The third is Apple's native TextEdit.app, for reference.
>>>>>>>
>>>>>>>
>>>>>>> <PastedGraphic-21.png>
>>>>>>> <PastedGraphic-19.png>
>>>>>>> <PastedGraphic-20.png>
>>>>>
>>
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Mon, 02 Sep 2013 14:51:02 GMT)
Full text and
rfc822 format available.
Message #29 received at 15138 <at> debbugs.gnu.org (full text, mbox):
In article <B1058569-FA76-4B76-84DF-46A38916008F <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
> I've made a fix for this in the trunk, please try it.
Do you mean this change?
* fontset.c (face_for_char): Check char in the current face font first
if HAVE_NS (Bug#15138).
I agree that this change improves font selection for
symbols, but it's not good for many scripts for which just
having a glyph is not enough. For instance, if the default
font has Hindi glyphs but doesn't have the OTF features for
Hindi script, we must find another proper font for Hindi.
How about modifying the current fontset mechanism as this?
(1) Allow t for FONT-SPEC of set-fontset-font to tell that
the default font should be tried.
(2) Modiyf the default fontset to include `t' as the
font-spec for scripts/characters for which the default
font is ok.
---
Kenichi Handa
handa <at> gnu.org
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Mon, 02 Sep 2013 15:58:02 GMT)
Full text and
rfc822 format available.
Message #32 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
2 sep 2013 kl. 16:50 skrev Kenichi Handa <handa <at> gnu.org>:
> In article <B1058569-FA76-4B76-84DF-46A38916008F <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
>
>> I've made a fix for this in the trunk, please try it.
>
> Do you mean this change?
>
> * fontset.c (face_for_char): Check char in the current face font first
> if HAVE_NS (Bug#15138).
>
> I agree that this change improves font selection for
> symbols, but it's not good for many scripts for which just
> having a glyph is not enough. For instance, if the default
> font has Hindi glyphs but doesn't have the OTF features for
> Hindi script, we must find another proper font for Hindi.
>
> How about modifying the current fontset mechanism as this?
>
> (1) Allow t for FONT-SPEC of set-fontset-font to tell that
> the default font should be tried.
> (2) Modiyf the default fontset to include `t' as the
> font-spec for scripts/characters for which the default
> font is ok.
libotf is genrelly not available on OSX, and probably not working with GNUStep either (unless they use it at a lower level). So the OTF case is not relevant to HAVE_NS anyway.
For OSX the way to go is to use Core text for this. I think GNUStep is looking at implementing Core text to replace their old display postscript implementation. So this is basically a temporary fix. Anyway, if you prefer OTF for some script, why not mark those scripts with "prefer-otf" and check if any otf-features are available? HAVE_NS will not have any OTF features.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Mon, 02 Sep 2013 17:31:01 GMT)
Full text and
rfc822 format available.
Message #35 received at 15138 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
it causes wrong font selection, if revert this change, it shows ok.
[chinese-character-not-shown.png (image/png, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Mon, 02 Sep 2013 18:35:01 GMT)
Full text and
rfc822 format available.
Message #38 received at 15138 <at> debbugs.gnu.org (full text, mbox):
I just tried it out; this solves my problems with "•" characters. Thanks!
Reply sent
to
Jan Djärv <jan.h.d <at> swipnet.se>
:
You have taken responsibility.
(Mon, 02 Sep 2013 19:14:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Michael Toomim <toomim <at> cs.washington.edu>
:
bug acknowledged by developer.
(Mon, 02 Sep 2013 19:14:02 GMT)
Full text and
rfc822 format available.
Message #43 received at 15138-done <at> debbugs.gnu.org (full text, mbox):
Hi.
2 sep 2013 kl. 20:34 skrev Michael Toomim <toomim <at> cs.washington.edu>:
> I just tried it out; this solves my problems with "•" characters. Thanks!
Ok, closing, thanks for testing.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 03 Sep 2013 07:01:01 GMT)
Full text and
rfc822 format available.
Message #46 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
I've checked in a fix, please test it.
Thanks,
Jan D.
2 sep 2013 kl. 19:29 skrev Darren Hoo <darren.hoo <at> gmail.com>:
> it causes wrong font selection, if revert this change, it shows ok.
> <chinese-character-not-shown.png>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 03 Sep 2013 12:11:02 GMT)
Full text and
rfc822 format available.
Message #49 received at 15138 <at> debbugs.gnu.org (full text, mbox):
In article <2ADB2AAF-31B8-4271-B4C4-6A26EDFB5858 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
> libotf is genrelly not available on OSX, and probably not
> working with GNUStep either (unless they use it at a lower
> level). So the OTF case is not relevant to HAVE_NS
> anyway.
Hindi is just an example. CJK characters are another
example. We should select a proper CJK font depending of
the current language environment.
> For OSX the way to go is to use Core text for this. I
> think GNUStep is looking at implementing Core text to
> replace their old display postscript implementation. So
> this is basically a temporary fix. Anyway, if you prefer
> OTF for some script, why not mark those scripts with
> "prefer-otf" and check if any otf-features are available?
?? The default fontset alreay has such a specification. For
devanagari script, for instance, Emacs tries to find an OTF
font which support "rphf" OTF Feature for "deva" script.
(devanagari ,(font-spec :registry "iso10646-1" :otf '(deva nil (rphf)))
(nil . "iso10646.indian-1"))
---
Kenichi Handa
handa <at> gnu.org
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 03 Sep 2013 14:38:02 GMT)
Full text and
rfc822 format available.
Message #52 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello,
I've tried it and fixed for me.
Thanks.
On Tue, Sep 3, 2013 at 3:00 PM, Jan Djärv <jan.h.d <at> swipnet.se> wrote:
> Hello.
>
> I've checked in a fix, please test it.
>
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 03 Sep 2013 15:19:01 GMT)
Full text and
rfc822 format available.
Message #55 received at 15138-done <at> debbugs.gnu.org (full text, mbox):
Hi.
3 sep 2013 kl. 16:37 skrev Darren Hoo <darren.hoo <at> gmail.com>:
> Hello,
>
> I've tried it and fixed for me.
Good, closing.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Tue, 03 Sep 2013 15:27:02 GMT)
Full text and
rfc822 format available.
Message #58 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
3 sep 2013 kl. 14:10 skrev Kenichi Handa <handa <at> gnu.org>:
> In article <2ADB2AAF-31B8-4271-B4C4-6A26EDFB5858 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
>
>> For OSX the way to go is to use Core text for this. I
>> think GNUStep is looking at implementing Core text to
>> replace their old display postscript implementation. So
>> this is basically a temporary fix. Anyway, if you prefer
>> OTF for some script, why not mark those scripts with
>> "prefer-otf" and check if any otf-features are available?
>
> ?? The default fontset alreay has such a specification. For
> devanagari script, for instance, Emacs tries to find an OTF
> font which support "rphf" OTF Feature for "deva" script.
>
> (devanagari ,(font-spec :registry "iso10646-1" :otf '(deva nil (rphf)))
> (nil . "iso10646.indian-1"))
That is nice. But rphf is totally ignored for HAVE_NS, it accepts any font with devanagari.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 12:59:01 GMT)
Full text and
rfc822 format available.
Message #61 received at 15138 <at> debbugs.gnu.org (full text, mbox):
In article <313DC5C9-7B2D-48B1-AF49-10540DF126E1 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
> That is nice. But rphf is totally ignored for HAVE_NS, it accepts any font with devanagari.
It should not be ignored. Instead, the underlying font
driver should return nil for a font spec requiring an OTF
feature if the driver doesn't support OTF. Then the fontset
mechanism fallbacks to the default fontset which has non-OTF
font spec for Devanagari.
---
Kenichi Handa
handa <at> gnu.org
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 13:51:02 GMT)
Full text and
rfc822 format available.
Message #64 received at 15138-done <at> debbugs.gnu.org (full text, mbox):
In article <7FEF1248-81A6-4E06-8F08-29A02CE72E00 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
> Good, closing.
I have another question about this change.
/* Fonts often have characters in other scripts, like symbol, even if they
don't match script: symbol. So check if the character is present
in the current face first. Only enable for NS for now, but should
perhaps be general? */
Lisp_Object font_object;
XSETFONT (font_object, face->font);
if (font_has_char (f, font_object, c)) return face->id;
With it, face->font may vary depending on the preceding
character. So if you have these lines:
abc•
あいう•
the two "•"s will be displayed by different fonts. Isn't it
better to try the font selected for ASCII as this:
XSETFONT (font_object, face->ascii_face->font);
---
Kenichi Handa
handa <at> gnu.org
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 16:35:02 GMT)
Full text and
rfc822 format available.
Message #67 received at 15138-done <at> debbugs.gnu.org (full text, mbox):
Hello.
5 sep 2013 kl. 15:49 skrev Kenichi Handa <handa <at> gnu.org>:
> In article <7FEF1248-81A6-4E06-8F08-29A02CE72E00 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
>
>> Good, closing.
>
> I have another question about this change.
>
> /* Fonts often have characters in other scripts, like symbol, even if they
> don't match script: symbol. So check if the character is present
> in the current face first. Only enable for NS for now, but should
> perhaps be general? */
> Lisp_Object font_object;
> XSETFONT (font_object, face->font);
> if (font_has_char (f, font_object, c)) return face->id;
>
> With it, face->font may vary depending on the preceding
> character. So if you have these lines:
> abc•
> あいう•
> the two "•"s will be displayed by different fonts. Isn't it
> better to try the font selected for ASCII as this:
>
> XSETFONT (font_object, face->ascii_face->font);
I don't know, I never had that situation. I guess if the goal is to show same glyphs, ascii_face->font is a better choice. But if it is to have a consistent look with the surrounding text, it it not.
Consider a buffer where only あいう• is entered. I would assume the current font would be a better choice in this case.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 16:57:01 GMT)
Full text and
rfc822 format available.
Message #70 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
5 sep 2013 kl. 14:57 skrev Kenichi Handa <handa <at> gnu.org>:
> In article <313DC5C9-7B2D-48B1-AF49-10540DF126E1 <at> swipnet.se>, Jan Djärv <jan.h.d <at> swipnet.se> writes:
>
>> That is nice. But rphf is totally ignored for HAVE_NS, it accepts any font with devanagari.
>
> It should not be ignored. Instead, the underlying font
> driver should return nil for a font spec requiring an OTF
> feature if the driver doesn't support OTF. Then the fontset
> mechanism fallbacks to the default fontset which has non-OTF
> font spec for Devanagari.
I guess the original author didn't know that, and tried to do the best font selection possible. I'll fix that shortly.
Jan D.
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 17:05:02 GMT)
Full text and
rfc822 format available.
Message #73 received at 15138 <at> debbugs.gnu.org (full text, mbox):
> I don't know, I never had that situation. I guess if the goal is to show
> same glyphs, ascii_face->font is a better choice. But if it is to
> have a consistent look with the surrounding text, it it not.
> Consider a buffer where only あいう• is entered. I would assume the
> current font would be a better choice in this case.
Seeking a "consistent look" is good, but I think doing it this way is
a hack (consider the case where you have •あいう instead).
Stefan
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#15138
; Package
emacs
.
(Thu, 05 Sep 2013 17:26:01 GMT)
Full text and
rfc822 format available.
Message #76 received at 15138 <at> debbugs.gnu.org (full text, mbox):
Hello.
5 sep 2013 kl. 19:04 skrev Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
>> I don't know, I never had that situation. I guess if the goal is to show
>> same glyphs, ascii_face->font is a better choice. But if it is to
>> have a consistent look with the surrounding text, it it not.
>> Consider a buffer where only あいう• is entered. I would assume the
>> current font would be a better choice in this case.
>
> Seeking a "consistent look" is good, but I think doing it this way is
> a hack (consider the case where you have •あいう instead).
>
One can always construct cases that favors one or the other approach.
Let possible bug reports sort this out, one can hope they are based on real usage and not thought out examples.
Jan D.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Fri, 04 Oct 2013 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 10 years and 209 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.